phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pmd: fix #1102 False positive: shift operator parenthesis

Browse Source
This commit is contained in:
Andreas Dangel
2013-08-03 22:05:23 +02:00
parent cc095674b0
commit 91f2137679
3 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pmd/etc/changelog.txt
View File

@ -4,6 +4,7 @@ Fixed bug 991: AvoidSynchronizedAtMethodLevel for static methods
Fixed bug 1084: NPE at UselessStringValueOfRule.java:36 Fixed bug 1084: NPE at UselessStringValueOfRule.java:36
Fixed bug 1092: Wrong Attribute "excludemarker" in Ant Task Documentation Fixed bug 1092: Wrong Attribute "excludemarker" in Ant Task Documentation
Fixed bug 1099: UseArraysAsList false positives Fixed bug 1099: UseArraysAsList false positives
Fixed bug 1102: False positive: shift operator parenthesis
Fixed bug 1104: IdempotentOperation false positive Fixed bug 1104: IdempotentOperation false positive
Fixed bug 1107: PMD 5.0.4 couldn't parse call of parent outer java class method from inner class Fixed bug 1107: PMD 5.0.4 couldn't parse call of parent outer java class method from inner class
Fixed bug 1111: False positive: Useless parentheses Fixed bug 1111: False positive: Useless parentheses

3
pmd/src/main/resources/rulesets/java/unnecessary.xml
View File

@ -241,7 +241,8 @@ public class Test {
//Expression/AdditiveExpression[not(./PrimaryExpression/PrimaryPrefix/Literal[@StringLiteral = 'true'])]/PrimaryExpression/PrimaryPrefix/Expression[ //Expression/AdditiveExpression[not(./PrimaryExpression/PrimaryPrefix/Literal[@StringLiteral = 'true'])]/PrimaryExpression/PrimaryPrefix/Expression[
count(*)=1 and count(*)=1 and
not(./CastExpression) and not(./CastExpression) and
not(./ConditionalExpression)] not(./ConditionalExpression) and
not(./ShiftExpression)]
| |
//Expression/EqualityExpression/PrimaryExpression/PrimaryPrefix/Expression[ //Expression/EqualityExpression/PrimaryExpression/PrimaryPrefix/Expression[
count(*)=1 and count(*)=1 and

11
pmd/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessParentheses.xml
View File

@ -205,4 +205,15 @@ return (absolute ? amount.abs() : amount).toString();
} } } }
]]></code> ]]></code>
</test-code> </test-code>
<test-code>
<description>#1102 False positive: shift operator parenthesis</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Test {
public void foo() {
xCoord = e.getX() - (MainFrame.TILESIZE >> 1);
}
}
]]></code>
</test-code>
</test-data> </test-data>