phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix NPE with empty rulesets.

Browse Source 
This is the fix for bug #1155 (https://sourceforge.net/p/pmd/bugs/1155/)

The whole code is in dire need of revisiting its behaviour when a
value is null or empty. Same goes for e.g. createRules whether it
should return null values (then the caller will have to deal with it)
or empty Rulesets.

Catching and discarding the rule not found exception looks pretty
suspicious.
This commit is contained in:
Henning Schmiedehausen 2013-11-26 11:00:49 -08:00
parent 973fd1c4d4
commit 957afd6625
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pmd/src/main/java/net/sourceforge/pmd/RuleSetReferenceId.java
View File

@ -251,11 +251,13 @@ public class RuleSetReferenceId {
*/
public static List<RuleSetReferenceId> parse(String referenceString) {
List<RuleSetReferenceId> references = new ArrayList<RuleSetReferenceId>();
if (referenceString.indexOf(',') == -1) {
references.add(new RuleSetReferenceId(referenceString));
} else {
for (String name : referenceString.split(",")) {
references.add(new RuleSetReferenceId(name));
if (referenceString != null && referenceString.trim().length() > 0) {
if (referenceString.indexOf(',') == -1) {
references.add(new RuleSetReferenceId(referenceString));
} else {
for (String name : referenceString.split(",")) {
references.add(new RuleSetReferenceId(name));
}
}
}
return references;

2
pmd/src/main/java/net/sourceforge/pmd/processor/AbstractPMDProcessor.java
View File

@ -56,7 +56,7 @@ public abstract class AbstractPMDProcessor {
return factory.createRuleSets(configuration.getRuleSets());
} catch (RuleSetNotFoundException rsnfe) {
// should not happen: parent already created a ruleset
return null;
return new RuleSets();
}
}