phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix dead link detection for image links

Browse Source
This commit is contained in:
Clément Fournier
2019-08-01 00:57:58 +02:00
parent 091ce3d40e
commit 959c98c906
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pmd-doc/src/main/java/net/sourceforge/pmd/docs/DeadLinksChecker.java
View File

@@ -49,7 +49,7 @@ public class DeadLinksChecker {
private static final boolean CHECK_EXTERNAL_LINKS = Boolean.parseBoolean(System.getProperty(CHECK_EXTERNAL_LINKS_PROPERTY));
// Markdown-Link: something in []'s followed by something in ()'s
private static final Pattern LOCAL_LINK_PATTERN = Pattern.compile("\\[.*?\\]\\((.*?)\\)");
private static final Pattern LOCAL_LINK_PATTERN = Pattern.compile("(!?)\\[.*?\\]\\((.*?)\\)");
// Markdown permalink-header and captions
private static final Pattern MD_HEADER_PERMALINK = Pattern.compile("permalink:\\s*(.*)");
@@ -78,8 +78,10 @@ public class DeadLinksChecker {
public void checkDeadLinks(Path rootDirectory) {
final Path pagesDirectory = rootDirectory.resolve("docs/pages");
final Path docsDirectory = rootDirectory.resolve("docs");
if (!Files.isDirectory(pagesDirectory)) {
// docsDirectory is implicitly checked by this statement too
LOG.severe("can't check for dead links, didn't find \"pages\" directory at: " + pagesDirectory);
System.exit(1);
}
@@ -111,7 +113,8 @@ public class DeadLinksChecker {
linkCheck:
while (matcher.find()) {
final String linkText = matcher.group();
final String linkTarget = matcher.group(1);
final boolean isImageLink = !matcher.group(1).isEmpty();
final String linkTarget = matcher.group(2);
boolean linkOk;
if (linkTarget.charAt(0) == '/') {
@@ -168,7 +171,12 @@ public class DeadLinksChecker {
continue;
}
linkOk = linkTarget.isEmpty() || htmlPages.contains(linkTarget);
if (isImageLink) {
Path localResource = docsDirectory.resolve(linkTarget);
linkOk = Files.exists(localResource);
} else {
linkOk = linkTarget.isEmpty() || htmlPages.contains(linkTarget);
}
}
if (!linkOk) {