phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[java] CheckSkipResult - use rulechain

Browse Source 
While there is no fixed false negative, this is more correct
and in PMD 7, rule chain is already used.
This commit is contained in:
Andreas Dangel
2021-11-13 11:29:21 +01:00
parent 62dd4c89fd
commit 9747f76f5c
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/CheckSkipResultRule.java
View File

@ -19,6 +19,10 @@ import net.sourceforge.pmd.lang.symboltable.NameOccurrence;
public class CheckSkipResultRule extends AbstractJavaRule { public class CheckSkipResultRule extends AbstractJavaRule {
public CheckSkipResultRule() {
addRuleChainVisit(ASTVariableDeclaratorId.class);
}
@Override @Override
public Object visit(ASTVariableDeclaratorId node, Object data) { public Object visit(ASTVariableDeclaratorId node, Object data) {
if (!TypeTestUtil.isA(InputStream.class, node.getTypeNode())) { if (!TypeTestUtil.isA(InputStream.class, node.getTypeNode())) {

2
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/CheckSkipResult.xml
View File

@ -7,6 +7,7 @@
<test-code> <test-code>
<description>failure case</description> <description>failure case</description>
<expected-problems>1</expected-problems> <expected-problems>1</expected-problems>
<expected-linenumbers>8</expected-linenumbers>
<code><![CDATA[ <code><![CDATA[
import java.io.FileInputStream; import java.io.FileInputStream;
@ -24,6 +25,7 @@ public class Foo {
<test-code> <test-code>
<description>failure case but obfuscated</description> <description>failure case but obfuscated</description>
<expected-problems>1</expected-problems> <expected-problems>1</expected-problems>
<expected-linenumbers>8</expected-linenumbers>
<code><![CDATA[ <code><![CDATA[
import java.io.FileInputStream; import java.io.FileInputStream;