phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[java] UseUnderscoresInNumericLiterals false positive on floating point numbers

Browse Source 
Fixes #1527
This commit is contained in:
Andreas Dangel
2019-03-29 18:16:45 +01:00
parent f6549d6c0b
commit a0876f71f5
3 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/pages/release_notes.md
View File

@ -60,6 +60,7 @@ The designer will still be shipped with PMD's binaries.
* java-bestpractices * java-bestpractices
* [#1701](https://github.com/pmd/pmd/issues/1701): \[java] UseTryWithResources does not handle multiple argument close methods * [#1701](https://github.com/pmd/pmd/issues/1701): \[java] UseTryWithResources does not handle multiple argument close methods
* java-codestyle * java-codestyle
* [#1527](https://github.com/pmd/pmd/issues/1527): \[java] UseUnderscoresInNumericLiterals false positive on floating point numbers
* [#1674](https://github.com/pmd/pmd/issues/1674): \[java] documentation of CommentDefaultAccessModifier is wrong * [#1674](https://github.com/pmd/pmd/issues/1674): \[java] documentation of CommentDefaultAccessModifier is wrong
### API Changes ### API Changes

4
pmd-java/src/main/resources/category/java/codestyle.xml
View File

@ -1405,11 +1405,11 @@ public class ClassInDefaultPackage {
(: Filter out ignored field name :) (: Filter out ignored field name :)
[not(ancestor::VariableDeclarator[1][@Name = 'serialVersionUID'])] [not(ancestor::VariableDeclarator[1][@Name = 'serialVersionUID'])]
[ [
some $num in tokenize(@Image, "[.dDfFlLeE+\-]") some $num in tokenize(@Image, "[dDfFlLeE+\-]")
satisfies not( satisfies not(
string-length($num) <= $acceptableDecimalLength string-length($num) <= $acceptableDecimalLength
and not(contains($num,"_")) and not(contains($num,"_"))
or matches($num, "^[0-9]{1,3}(_[0-9]{3})*$") or matches($num, "^[0-9]{1,3}(_[0-9]{3})*(\.([0-9]{3}_)*[0-9]{1,3})?$")
) )
] ]
]]> ]]>

17
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UseUnderscoresInNumericLiterals.xml
View File

@ -322,8 +322,23 @@ public class Foo {
<expected-problems>0</expected-problems> <expected-problems>0</expected-problems>
<code><![CDATA[ <code><![CDATA[
public class Foo { public class Foo {
int value = 0.3936; double value1 = 0.393_6;
double value2 = 0.39;
double value3 = -0.1;
double value4 = -0.123_456;
double value5 = +0.123_456;
} }
]]></code> ]]></code>
</test-code> </test-code>
<test-code>
<description>#1527 [java] UseUnderscoresInNumericLiterals false positive on floating point numbers</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Foo {
double value1 = 36.363_636_363_636_37;
double value2 = 0.000_000_1;
}
]]></code>
</test-code>
</test-data> </test-data>