phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary source-type tags in rule tests

Browse Source 
source-type is actually only needed if
* the language supports more than one version
* the parser behaves differently with different versions
  (this has to do with compatibility, e.g. assert/enum keywords
  in java)
* the test needs a newer version than the default version
  (e.g. to test new language features)
* the test needs an older version than the default version
  (e.g. the rule has a maximumLanguageVersion specified)
* the rule behaves differently for different versions
  (e.g. BigIntegerInstantiation)
This commit is contained in:
Andreas Dangel
2020-05-23 14:16:13 +02:00
parent 561825703f
commit a3a292d591
80 changed files with 0 additions and 330 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/AvoidWithStatement.xml
View File

@ -12,6 +12,5 @@ with (object) {
property = 3; // Might be on object, might be on window: who knows.
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

6
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/ConsistentReturn.xml
View File

@ -11,7 +11,6 @@
function foo() {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -22,7 +21,6 @@ function foo() {
return true;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -33,7 +31,6 @@ function foo() {
return;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -47,7 +44,6 @@ function foo() {
return;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -61,7 +57,6 @@ function foo() {
return;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -81,6 +76,5 @@ function foo() {
return;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

2
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/GlobalVariable.xml
View File

@ -16,7 +16,6 @@ function(arg) {
};
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -36,6 +35,5 @@ function(arg) {
};
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

6
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/ScopeForInVariable.xml
View File

@ -12,7 +12,6 @@ for (var p in obj) {
obj[p] = obj[p];
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -25,7 +24,6 @@ function foo() {
}
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -46,7 +44,6 @@ function foo() {
// 'p' still has value of 'clean'.
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -57,7 +54,6 @@ for (p in obj) {
obj[p] = obj[p];
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -70,7 +66,6 @@ function() {
}
};
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -91,6 +86,5 @@ function bar() {
// 'p' is trashed and has value of 'dirty'!
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

2
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/UseBaseWithParseInt.xml
View File

@ -10,7 +10,6 @@
<code><![CDATA[
parseInt("10");
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -19,6 +18,5 @@ parseInt("10");
<code><![CDATA[
parseInt("10", 16);
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

10
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/codestyle/xml/AssignmentInOperand.xml
View File

@ -20,7 +20,6 @@ x ? true : false;
x ? true : false;
x ? true : false;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -39,7 +38,6 @@ for (var i = 0; x = true; i++) {
x ? x = true : false;
x ? true : x = false;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -50,7 +48,6 @@ x ? true : x = false;
if (x = true) {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -61,7 +58,6 @@ if (x = true) {
while (x = true) {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -72,7 +68,6 @@ while (x = true) {
do {
} while(x = true);
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -83,7 +78,6 @@ do {
for (var i = 0; x = true; i++) {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -93,7 +87,6 @@ for (var i = 0; x = true; i++) {
<code><![CDATA[
(x = true) ? true : false;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -104,7 +97,6 @@ for (var i = 0; x = true; i++) {
x ? x = true : false;
x ? true : x = false;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -123,7 +115,6 @@ do {
x ? (++x || --x || x++ || x--) : false;
x ? true : (++x || --x || x++ || x--);
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -143,6 +134,5 @@ do {
x ? (++x || --x || x++ || x--) : false;
x ? true : (++x || --x || x++ || x--);
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

7
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/codestyle/xml/ForLoopsMustUseBraces.xml
View File

@ -12,7 +12,6 @@ for (var i=0; i<42; i++) {
foo();
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -23,7 +22,6 @@ for (var i in obj) {
foo();
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -33,7 +31,6 @@ for (var i in obj) {
for (var i=0; i<42; i++)
foo();
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -43,7 +40,6 @@ for (var i=0; i<42; i++)
for (var i=0; i<42;)
foo();
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -53,7 +49,6 @@ for (var i=0; i<42;)
for (var i=0;;)
foo();
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -63,7 +58,6 @@ for (var i=0;;)
for (;;)
foo();
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -73,6 +67,5 @@ for (;;)
for (var i in obj)
foo();
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

9
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/codestyle/xml/IfElseStmtsMustUseBraces.xml
View File

@ -14,7 +14,6 @@ if (true) {
x = 4;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -29,7 +28,6 @@ if (true) {
y = 4;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -39,7 +37,6 @@ if (true) {
if (true)
x=2;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -50,7 +47,6 @@ if (true)
if (false)
x=2;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -62,7 +58,6 @@ if (true) {
} else
y=4;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -74,7 +69,6 @@ if (true)
else
x=4;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -88,7 +82,6 @@ if (true) {
} else
y=4;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -102,7 +95,6 @@ if (true) {
else
y=4;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -116,6 +108,5 @@ else if (true)
else
y=4;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

3
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/codestyle/xml/IfStmtsMustUseBraces.xml
View File

@ -12,7 +12,6 @@ if (true) {
x=2;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -22,7 +21,6 @@ if (true) {
if (true)
x=2;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -34,6 +32,5 @@ if (true) {
bar();
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

17
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/codestyle/xml/UnnecessaryBlock.xml
View File

@ -11,7 +11,6 @@
function foo() {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -23,7 +22,6 @@ if (true) {
} else {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -33,7 +31,6 @@ if (true) {
for (var i = 0; i < 10; i++) {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -43,7 +40,6 @@ for (var i = 0; i < 10; i++) {
for (var i in obj) {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -53,7 +49,6 @@ for (var i in obj) {
while(true) {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -63,7 +58,6 @@ while(true) {
do {
} while(true)
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -75,7 +69,6 @@ switch(1) {
break;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -87,7 +80,6 @@ try {
} finally {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -97,7 +89,6 @@ try {
{
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -109,7 +100,6 @@ function foo() {
}
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -127,7 +117,6 @@ if (true) {
}
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -139,7 +128,6 @@ for (var i = 0; i < 10; i++) {
}
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -151,7 +139,6 @@ for (var i in obj) {
}
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -163,7 +150,6 @@ while(true) {
}
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -175,7 +161,6 @@ do {
}
} while(true)
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -189,7 +174,6 @@ switch(1) {
break;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -207,6 +191,5 @@ try {
}
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

4
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/codestyle/xml/UnnecessaryParentheses.xml
View File

@ -10,7 +10,6 @@
<code><![CDATA[
var x = (1);
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -19,7 +18,6 @@ var x = (1);
<code><![CDATA[
var x = ((1));
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -28,7 +26,6 @@ var x = ((1));
<code><![CDATA[
var x = ((1 > 2) || (3 < 4));
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -37,6 +34,5 @@ var x = ((1 > 2) || (3 < 4));
<code><![CDATA[
var x = (((1 > 2)) || (3 < 4));
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

10
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/codestyle/xml/UnreachableCode.xml
View File

@ -12,7 +12,6 @@ function foo() {
return 1;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -23,7 +22,6 @@ while (true) {
continue;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -34,7 +32,6 @@ while (true) {
break;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -48,7 +45,6 @@ switch (foo) {
break;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -59,7 +55,6 @@ if (true) {
throw new Error();
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -71,7 +66,6 @@ function foo() {
x = 1;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -83,7 +77,6 @@ while (true) {
x = 1;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -95,7 +88,6 @@ while (true) {
x = 1;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -111,7 +103,6 @@ switch (foo) {
x = 1;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -123,6 +114,5 @@ if (true) {
x = 1;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

2
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/codestyle/xml/WhileLoopsMustUseBraces.xml
View File

@ -12,7 +12,6 @@ while (true) {
x++;
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -22,6 +21,5 @@ while (true) {
while (true)
x++;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

10
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/errorprone/xml/AvoidTrailingComma.xml
View File

@ -11,7 +11,6 @@
x = {a : 1};
x = {a : 1, b : 2};
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -21,7 +20,6 @@ x = {a : 1, b : 2};
x = {a: 1,};
x = {a: 1, b: 2,};
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -38,7 +36,6 @@ x = {
},
};
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -47,7 +44,6 @@ x = {
<code><![CDATA[
x={a:1,b:{c:{d:{},},},};
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -59,7 +55,6 @@ x = {,};
x = {a: 1,};
x = {a: 1, b : 2,};
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -70,7 +65,6 @@ x = [];
x = [1];
x = [1, 2];
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -81,7 +75,6 @@ x = [,];
x = [1,];
x = [1,2,];
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -96,7 +89,6 @@ x = [1,
],
];
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -105,7 +97,6 @@ x = [1,
<code><![CDATA[
x=[1,[2,[3,[4,],],],];
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -117,6 +108,5 @@ x = [,];
x = [1,];
x = [1,2,];
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

2
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/errorprone/xml/EqualComparison.xml
View File

@ -17,7 +17,6 @@ if (x !== 5) {
if (x === 1.2) {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -33,6 +32,5 @@ if (x != 5) {
if (x == 1.2) {
}
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>

7
pmd-javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/rule/errorprone/xml/InnaccurateNumericLiteral.xml
View File

@ -10,14 +10,12 @@
<code><![CDATA[
var x = 1;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
<description>Bad integer</description>
<expected-problems>1</expected-problems>
<code>var x = 999999999999999999999999;</code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -26,7 +24,6 @@ var x = 1;
<code><![CDATA[
var x = 1.1234567890123;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -35,7 +32,6 @@ var x = 1.1234567890123;
<code><![CDATA[
var z = 1.12345678901234567;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -44,7 +40,6 @@ var z = 1.12345678901234567;
<code><![CDATA[
var x = 1.12e-4;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -53,7 +48,6 @@ var x = 1.12e-4;
<code><![CDATA[
var x = 1.12345678901234567e-4;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
<test-code>
@ -63,6 +57,5 @@ var x = 1.12345678901234567e-4;
var hex1 = 0x20;
var hex2 = 0X20;
]]></code>
<source-type>ecmascript 3</source-type>
</test-code>
</test-data>