phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

changes in response to feedback

Browse Source 
Remove wrapping HashMap
Add log4j2 to test descriptions
This commit is contained in:
markhall1982
2019-09-19 21:04:01 +01:00
parent 96449c2ae5
commit ab434f3747
2 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/InvalidSlf4jMessageFormatRule.java
View File

@@ -55,8 +55,7 @@ public class InvalidSlf4jMessageFormatRule extends AbstractJavaRule {
loggersMap.put("org.apache.logging.log4j.Logger", Collections
.unmodifiableSet(new HashSet<String>(Arrays.asList("trace", "debug", "info", "warn", "error", "fatal", "all"))));
LOGGERS = Collections
.unmodifiableMap(new HashMap<String, Set<String>>(loggersMap));
LOGGERS = loggersMap;
}
public InvalidSlf4jMessageFormatRule() {

24
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/InvalidSlf4jMessageFormat.xml
View File

@@ -382,7 +382,7 @@ public final class Main {
</test-code>
<test-code>
<description><![CDATA[
missing argument
log4j2: missing argument
]]></description>
<expected-problems>1</expected-problems>
<expected-linenumbers>9</expected-linenumbers>
@@ -402,7 +402,7 @@ public class Foo {
</test-code>
<test-code>
<description><![CDATA[
too many arguments
log4j2: too many arguments
]]></description>
<expected-problems>1</expected-problems>
<expected-linenumbers>9</expected-linenumbers>
@@ -422,7 +422,7 @@ public class Foo {
</test-code>
<test-code>
<description><![CDATA[
Logger without problems
log4j2: Logger without problems
]]></description>
<expected-problems>0</expected-problems>
<code><![CDATA[
@@ -441,7 +441,7 @@ public class Foo {
</test-code>
<test-code>
<description><![CDATA[
ignore the exception param
log4j2: ignore the exception param
]]></description>
<expected-problems>0</expected-problems>
<code><![CDATA[
@@ -459,7 +459,7 @@ public class Foo {
</test-code>
<test-code>
<description>Class cast exception with Method calls</description>
<description>log4j2: Class cast exception with Method calls</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class MethodCallClassCastExceptionProblem {
@@ -475,7 +475,7 @@ public class MethodCallClassCastExceptionProblem {
</test-code>
<test-code>
<description>Null pointer with VariableNameDeclaration / VariableDeclaratorId</description>
<description>log4j2: Null pointer with VariableNameDeclaration / VariableDeclaratorId</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class NullPointerTypeProblem {
@@ -648,7 +648,7 @@ public final class Main {
</test-code>
<test-code>
<description>NPE in static block (see #1512)</description>
<description>log4j2: NPE in static block (see #1512)</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import org.apache.logging.log4j.Logger;
@@ -663,7 +663,7 @@ public final class Main {
</test-code>
<test-code>
<description>missing argument in static block</description>
<description>log4j2: missing argument in static block</description>
<expected-problems>1</expected-problems>
<expected-linenumbers>8</expected-linenumbers>
<code><![CDATA[
@@ -681,7 +681,7 @@ public final class Main {
</test-code>
<test-code>
<description>NPE in lambda call (see #1512)</description>
<description>log4j2: NPE in lambda call (see #1512)</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import org.apache.logging.log4j.Logger;
@@ -695,7 +695,7 @@ public final class Main {
</test-code>
<test-code>
<description>missing argument in lambda call</description>
<description>log4j2: missing argument in lambda call</description>
<expected-problems>1</expected-problems>
<expected-linenumbers>9</expected-linenumbers>
<code><![CDATA[
@@ -714,7 +714,7 @@ public final class Main {
</test-code>
<test-code>
<description>NPE in enums (see #1549)</description>
<description>log4j2: NPE in enums (see #1549)</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import org.apache.logging.log4j.Logger;
@@ -737,7 +737,7 @@ public final class Main {
</test-code>
<test-code>
<description>missing argument in enum</description>
<description>log4j2: missing argument in enum</description>
<expected-problems>1</expected-problems>
<expected-linenumbers>12</expected-linenumbers>
<code><![CDATA[