phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert check on initializers

Browse Source
This commit is contained in:
Juan Martín Sotuyo Dodero
2018-04-07 21:06:02 -03:00
parent de68b4902f
commit ae48542132
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/ClassNamingConventionsRule.java
View File

@@ -12,6 +12,7 @@ import net.sourceforge.pmd.lang.java.ast.ASTAnyTypeDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTAnyTypeDeclaration.TypeKind;
import net.sourceforge.pmd.lang.java.ast.ASTClassOrInterfaceDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTEnumDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTInitializer;
import net.sourceforge.pmd.lang.java.ast.AccessNode;
import net.sourceforge.pmd.lang.java.rule.AbstractJavaRule;
import net.sourceforge.pmd.properties.PropertyDescriptor;
@@ -77,6 +78,11 @@ public class ClassNamingConventionsRule extends AbstractJavaRule {
return false;
}
break;
case INITIALIZER:
if (!((ASTInitializer) decl.getDeclarationNode()).isStatic()) {
return false;
}
default:
break;

4
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/ClassNamingConventions.xml
View File

@@ -119,8 +119,8 @@
</test-code>
<test-code>
<description>Class with instance initializer should be a utility class</description>
<expected-problems>1</expected-problems>
<description>Class with instance initializer should not be a utility class</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Foo {