phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rule messages can no longer be declared in Java

Browse Source 
This caused problems with the RuleSetWriter. Schade.
This commit is contained in:
Clément Fournier
2018-06-10 04:05:21 +02:00
parent 059b0f15c0
commit b08da58069
4 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pmd-core/src/main/java/net/sourceforge/pmd/rules/RuleBuilder.java
View File

@ -186,11 +186,6 @@ public class RuleBuilder {
rule.setLanguage(language);
}
// The message can be set in Java, but the XML takes precedence
if (!StringUtils.isBlank(message)) {
rule.setMessage(message);
}
loadLanguageMinMaxVersions(rule);
rule.setSince(since);
rule.setExternalInfoUrl(externalInfoUrl);

4
pmd-core/src/main/java/net/sourceforge/pmd/rules/RuleFactory.java
View File

@ -146,10 +146,6 @@ public class RuleFactory {
builder.since(ruleElement.getAttribute(SINCE));
}
if (ruleElement.hasAttribute(MESSAGE)) {
builder.message(ruleElement.getAttribute(MESSAGE));
}
builder.externalInfoUrl(ruleElement.getAttribute(EXTERNAL_INFO_URL));
builder.setDeprecated(hasAttributeSetTrue(ruleElement, DEPRECATED));
builder.usesDFA(hasAttributeSetTrue(ruleElement, "dfa"));