phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixes #1453 Test Class Without Test Cases gives false positive

Browse Source
This commit is contained in:
Andreas Dangel
2016-01-28 22:24:34 +01:00
parent e6f5380719
commit b9f8f2d4fb
4 changed files with 29 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/junit/AbstractJUnitRule.java
View File

@ -82,11 +82,13 @@ public abstract class AbstractJUnitRule extends AbstractJavaRule {
return false; // skip various inapplicable method variations
}
boolean result = false;
if (isJUnit3Class) {
return isJUnit3Method(method);
} else {
return isJUnit4Method(method);
result = isJUnit3Method(method);
}
result |= isJUnit4Method(method);
return result;
}
private boolean isJUnit4Method(ASTMethodDeclaration method) {

13
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/junit/TestClassWithoutTestCasesRule.java
View File

@ -3,7 +3,6 @@
*/
package net.sourceforge.pmd.lang.java.rule.junit;
import java.util.Iterator;
import java.util.List;
import net.sourceforge.pmd.lang.java.ast.ASTClassOrInterfaceDeclaration;
@ -21,17 +20,15 @@ public class TestClassWithoutTestCasesRule extends AbstractJUnitRule {
boolean testsFound = false;
if (m != null) {
for (Iterator<ASTMethodDeclaration> it = m.iterator(); it.hasNext() && !testsFound;) {
ASTMethodDeclaration md = it.next();
if (!isInInnerClassOrInterface(md)
&& isJUnitMethod(md, data)) {
testsFound = true;
}
for (ASTMethodDeclaration md : m) {
if (!isInInnerClassOrInterface(md) && isJUnitMethod(md, data)) {
testsFound = true;
}
}
}
if (!testsFound) {
addViolation(data, node);
addViolation(data, node);
}
return data;

17
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/junit/xml/TestClassWithoutTestCases.xml
View File

@ -96,6 +96,23 @@ failure case does not extend TestCase
<expected-problems>0</expected-problems>
<code><![CDATA[
public class FooTest {
}
]]></code>
</test-code>
<test-code>
<description>#1453 False positive when the test class extends an other.</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import static org.junit.Assert.*;
import org.junit.Test;
public class MyTest extends YourTest {
@Test
public void falseMethod() {
assertFalse(0 == 1);
}
}
]]></code>
</test-code>