phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Temporarily disable the unit tests until the rules are moved into the"

Browse Source 
This reverts commit ded09b6498.
This commit is contained in:
Andreas Dangel
2017-11-01 18:54:10 +01:00
parent 1d07ad353e
commit c29f2a44e6
4 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pmd-java/src/test/java/net/sourceforge/pmd/RuleSetFactoryTest.java
View File

@ -7,7 +7,6 @@ package net.sourceforge.pmd;
import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull; import static org.junit.Assert.assertNull;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
/** /**
@ -45,10 +44,4 @@ public class RuleSetFactoryTest extends AbstractRuleSetFactoryTest {
RuleSet ruleset = ruleSetFactory.createRuleSet(ref); RuleSet ruleset = ruleSetFactory.createRuleSet(ref);
assertNotNull(ruleset); assertNotNull(ruleset);
} }
@Test
@Ignore("Rule classes need to be moved into the correct packages corresponding to their categories")
public void testAllPMDBuiltInRulesMeetConventions() {
// disabled test from super class
}
} }

2
pmd-java/src/test/java/net/sourceforge/pmd/ant/PMDTaskTest.java
View File

@ -12,14 +12,12 @@ import java.util.Objects;
import org.apache.commons.io.FileUtils; import org.apache.commons.io.FileUtils;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Ignore;
import org.junit.Rule; import org.junit.Rule;
import org.junit.Test; import org.junit.Test;
import org.junit.contrib.java.lang.system.RestoreSystemProperties; import org.junit.contrib.java.lang.system.RestoreSystemProperties;
import org.junit.rules.ExternalResource; import org.junit.rules.ExternalResource;
import org.junit.rules.TestRule; import org.junit.rules.TestRule;
@Ignore
public class PMDTaskTest extends AbstractAntTestHelper { public class PMDTaskTest extends AbstractAntTestHelper {
public PMDTaskTest() { public PMDTaskTest() {

2
pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/metrics/MetricsRulesTest.java
View File

@ -27,6 +27,6 @@ public class MetricsRulesTest extends SimpleAggregatorTst {
public void setUp() { public void setUp() {
addRule(RULESET, "CyclomaticComplexity"); addRule(RULESET, "CyclomaticComplexity");
addRule(RULESET, "NPathComplexity"); addRule(RULESET, "NPathComplexity");
//addRule(RULESET, "DataClass"); addRule(RULESET, "DataClass");
} }
} }

2
pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/strictexception/StrictExceptionRulesTest.java
View File

@ -21,7 +21,7 @@ public class StrictExceptionRulesTest extends SimpleAggregatorTst {
addRule(RULESET, "AvoidThrowingNullPointerException"); addRule(RULESET, "AvoidThrowingNullPointerException");
addRule(RULESET, "AvoidThrowingRawExceptionTypes"); addRule(RULESET, "AvoidThrowingRawExceptionTypes");
addRule(RULESET, "DoNotExtendJavaLangError"); addRule(RULESET, "DoNotExtendJavaLangError");
//addRule(RULESET, "DoNotExtendJavaLangThrowable"); addRule(RULESET, "DoNotExtendJavaLangThrowable");
addRule(RULESET, "ExceptionAsFlowControl"); addRule(RULESET, "ExceptionAsFlowControl");
addRule(RULESET, "SignatureDeclareThrowsException"); addRule(RULESET, "SignatureDeclareThrowsException");
addRule(RULESET, "DoNotThrowExceptionInFinally"); addRule(RULESET, "DoNotThrowExceptionInFinally");