phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pmd: fixed #878 False positive: UnusedFormalParameter for abstract methods

Browse Source
This commit is contained in:
Andreas Dangel 2013-01-23 21:24:36 +01:00
parent 7ee96a6b52
commit cb9861dd1f
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pmd/etc/changelog.txt
View File

@ -1,5 +1,6 @@
???? ??, 2012 - 5.0.2: ???? ??, 2012 - 5.0.2:
Fixed bug 878: False positive: UnusedFormalParameter for abstract methods
Fixed bug 1012: False positive: Useless parentheses. Fixed bug 1012: False positive: Useless parentheses.
Fixed bug 1026: PMD doesn't handle 'value =' in SuppressWarnings annotation Fixed bug 1026: PMD doesn't handle 'value =' in SuppressWarnings annotation
Fixed bug 1037: Facing a showstopper issue in PMD Report Class (report listeners) Fixed bug 1037: Facing a showstopper issue in PMD Report Class (report listeners)

2
pmd/src/main/java/net/sourceforge/pmd/lang/java/rule/unusedcode/UnusedFormalParameterRule.java
View File

@ -33,7 +33,7 @@ public class UnusedFormalParameterRule extends AbstractJavaRule {
if (!node.isPrivate() && !getProperty(CHECKALL_DESCRIPTOR)) { if (!node.isPrivate() && !getProperty(CHECKALL_DESCRIPTOR)) {
return data; return data;
} }
if (!node.isNative()) { if (!node.isNative() && !node.isAbstract()) {
check(node, data); check(node, data);
} }
return data; return data;

10
pmd/src/test/resources/net/sourceforge/pmd/lang/java/rule/unusedcode/xml/UnusedFormalParameter.xml
View File

@ -234,4 +234,14 @@ class Foo {
]]> ]]>
</code> </code>
</test-code> </test-code>
<test-code>
<description>#878 don't flag abstract methods even if checkall property is set when checking an abstract class</description>
<rule-property name="checkAll">true</rule-property>
<expected-problems>0</expected-problems>
<code><![CDATA[
abstract class Foo {
protected abstract void foo(Long s);
}
]]></code>
</test-code>
</test-data> </test-data>