phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core] Remove deprecated methods in RuleReference

Browse Source 
RuleReference#setRuleSetReference
RuleReference#hasOverriddenProperty
This commit is contained in:
Andreas Dangel
2024-02-08 08:29:55 +01:00
parent 1900aa79c4
commit cdc70c633a
2 changed files with 3 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/pages/release_notes.md
View File

@ -212,6 +212,9 @@ The following previously deprecated rules have been finally removed:
Note: These methods were only marked as deprected in javadoc.
* `addViolationWithMessage(...)` - use {%jdoc core::RuleContext#addViolationWithMessage(core::lang.ast.Node,java.lang.String) %} instead, e.g. via
`asCtx(data).addViolationWithMessage(...)`. Note: These methods were only marked as deprected in javadoc.
* {%jdoc !!core::lang.rule.RuleReference %} - the following methods have been removed:
* `setRuleSetReference(RuleSetReference)` - without replacement. Just construct new {%jdoc core::lang.rule.RuleReference %} instead.
* `hasOverriddenProperty(PropertyDescriptor)` - use {%jdoc core::lang.rule.RuleReference#isPropertyOverridden(core::properties.PropertyDescriptor) %} instead.
* pmd-apex
* {%jdoc apex::lang.apex.ast.ApexNode %} and {% jdoc apex::lang.apex.ast.ASTApexFile %}
* `#getApexVersion()`: In PMD 6, this method has been deprecated but was defined in the class `ApexRootNode`.

16
pmd-core/src/main/java/net/sourceforge/pmd/lang/rule/RuleReference.java
View File

@ -279,14 +279,6 @@ public class RuleReference implements Rule {
}
/**
* @deprecated There's no use in setting the ruleset reference after construction
*/
@Deprecated
public void setRuleSetReference(RuleSetReference ruleSetReference) {
this.ruleSetReference = ruleSetReference;
}
private static boolean isSame(String s1, String s2) {
return StringUtil.isSame(s1, s2, true, false, true);
}
@ -307,14 +299,6 @@ public class RuleReference implements Rule {
|| rule.hasDescriptor(descriptor);
}
/**
* @deprecated Use {@link #isPropertyOverridden(PropertyDescriptor)} instead
*/
@Deprecated
public boolean hasOverriddenProperty(PropertyDescriptor<?> descriptor) {
return isPropertyOverridden(descriptor);
}
@Override
public boolean isPropertyOverridden(PropertyDescriptor<?> descriptor) {
return propertyValues != null && propertyValues.containsKey(descriptor);