phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pmd: #1031 false DontImportJavaLang

Browse Source
This commit is contained in:
Andreas Dangel
2012-10-21 19:57:51 +02:00
parent d1d4fca5d5
commit ce8a166a11
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pmd/etc/changelog.txt
View File

@ -41,6 +41,7 @@ Fixed bug 1025: Regression of Crash in PMDTask due to multithreading (Eclipse an
Fixed bug 1017: Type resolution very slow for big project. Thanks to Roman for the patch. Fixed bug 1017: Type resolution very slow for big project. Thanks to Roman for the patch.
Fixed bug 1036: Documentation: default threshold values removed from v5.0 Fixed bug 1036: Documentation: default threshold values removed from v5.0
Fixed bug 1035: UseObjectForClearerAPI has misspelled message Fixed bug 1035: UseObjectForClearerAPI has misspelled message
Fixed bug 1031: false DontImportJavaLang
Improved JSP parser to be less strict with not valid XML documents (like HTML). Thanks to Victor Bucutea. Improved JSP parser to be less strict with not valid XML documents (like HTML). Thanks to Victor Bucutea.
Fixed bgastviewer not working. Thanks to Victor Bucutea. Fixed bgastviewer not working. Thanks to Victor Bucutea.

3
pmd/src/main/java/net/sourceforge/pmd/lang/java/rule/imports/DontImportJavaLangRule.java
View File

@ -23,7 +23,8 @@ public class DontImportJavaLangRule extends AbstractJavaRule {
if (img.startsWith("java.lang")) { if (img.startsWith("java.lang")) {
if (img.startsWith("java.lang.ref") || img.startsWith("java.lang.reflect") if (img.startsWith("java.lang.ref") || img.startsWith("java.lang.reflect")
|| img.startsWith("java.lang.annotation") || img.startsWith("java.lang.instrument") || img.startsWith("java.lang.annotation") || img.startsWith("java.lang.instrument")
|| img.startsWith("java.lang.management") || img.startsWith("java.lang.Thread.")) { || img.startsWith("java.lang.management") || img.startsWith("java.lang.Thread.")
|| img.startsWith("java.lang.ProcessBuilder.")) {
return data; return data;
} }
addViolation(data, node); addViolation(data, node);

9
pmd/src/test/resources/net/sourceforge/pmd/lang/java/rule/imports/xml/DontImportJavaLang.xml
View File

@ -55,4 +55,13 @@ import java.lang.Thread.UncaughtExceptionHandler;
public class Foo {} public class Foo {}
]]></code> ]]></code>
</test-code> </test-code>
<test-code>
<description>import java.lang.ProcessBuilder.Redirect: #1031 false DontImportJavaLang</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import java.lang.ProcessBuilder.Redirect;
public class Foo {}
]]></code>
</test-code>
</test-data> </test-data>