phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

1503099, fixed false positive for

Browse Source 
new StringBuffer(str1.length() + str2.length());

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5585 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Wouter Zelle
2007-10-25 14:56:24 +00:00
parent 3fe03f18d7
commit dee7967d2a
2 changed files with 53 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
pmd/regress/test/net/sourceforge/pmd/rules/strings/xml/InefficientStringBuffering.xml
View File

@ -303,4 +303,47 @@ StringBuffer buffer = new StringBuffer(
} } } }
]]></code> ]]></code>
</test-code> </test-code>
<test-code>
<description><![CDATA[
1503099, init with two string lengths
]]></description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Foo {
public void bar(String str1, String str2) {
StringBuffer buf = new StringBuffer(str1.length() + str2.length());
buf.append(str1);
buf.append(str2);
}
}
]]></code>
</test-code>
<test-code>
<description><![CDATA[
1503099, append with two string lengths
]]></description>
<expected-problems>1</expected-problems>
<code><![CDATA[
public class Foo {
public void bar(String str1, String str2) {
StringBuffer buf = new StringBuffer();
buf.append(str1.length() + str2.length());
}
}
]]></code>
</test-code>
<!--test-code>
<description><![CDATA[
1503099, adding two integers
]]></description>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Foo {
public void bar(int a, int b) {
StringBuffer buf = new StringBuffer();
buf.append(a + b);
}
}
]]></code>
</test-code-->
</test-data> </test-data>

11
pmd/src/net/sourceforge/pmd/rules/strings/InefficientStringBuffering.java
View File

@ -17,6 +17,7 @@ import net.sourceforge.pmd.ast.SimpleNode;
import net.sourceforge.pmd.symboltable.VariableNameDeclaration; import net.sourceforge.pmd.symboltable.VariableNameDeclaration;
import net.sourceforge.pmd.typeresolution.TypeHelper; import net.sourceforge.pmd.typeresolution.TypeHelper;
import java.util.Iterator;
import java.util.List; import java.util.List;
/* /*
@ -65,8 +66,16 @@ public class InefficientStringBuffering extends AbstractRule {
} }
} }
if (bs.isAllocation()) { if (bs.isAllocation()) {
for (Iterator<ASTName> iterator = nameNodes.iterator(); iterator.hasNext();) {
ASTName name = iterator.next();
if (!name.getImage().endsWith("length")) {
break;
} else if (!iterator.hasNext()) {
return data; //All names end with length
}
}
if (isAllocatedStringBuffer(node)) { if (isAllocatedStringBuffer(node)) {
addViolation(data, node); addViolation(data, node);
} }