phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Danger: Update PmdTester execution to report also configuration errors

Browse Source 
Refs pmd/pmd-regression-tester#57
This commit is contained in:
Andreas Dangel 2019-01-20 20:17:23 +01:00
parent dbe2442a2a
commit ecd60e8e3e
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Dangerfile
View File

@ -9,7 +9,7 @@ def run_pmdtester
argv = ['-r', './pmd', '-b', "#{ENV['TRAVIS_BRANCH']}", '-p', 'FETCH_HEAD', '-m', 'online', '-a']
begin
runner = PmdTester::Runner.new(argv)
@new_errors, @removed_errors, @new_violations, @removed_violations = runner.run
@new_errors, @removed_errors, @new_violations, @removed_violations, @new_configerrors, @removed_configerrors = runner.run
upload_report
rescue StandardError => e
warn("Running pmdtester failed, this message is mainly used to remind the maintainers of PMD.")
@ -32,8 +32,11 @@ def upload_report
@logger.info "Successfully uploaded #{tar_filename} to chunk.io"
# set value of sticky to true and the message is kept after new commits are submited to the PR
message("This changeset introduces #{@new_violations} new violations and #{@new_errors} new errors,\n" +
"removes #{@removed_violations} violations and #{@removed_errors} errors. [Full report](#{report_url.chomp}/diff/index.html)", sticky: true)
message("This changeset introduces #{@new_violations} new violations, #{@new_errors} new errors and " +
"#{@new_configerrors} new configuration errors,\n" +
"removes #{@removed_violations} violations, #{@removed_errors} errors and " +
"#{@removed_configerrors} configuration errors.\n" +
"[Full report](#{report_url.chomp}/diff/index.html)", sticky: true)
else
@logger.error "Error while uploading #{tar_filename} to chunk.io: #{report_url}"
warn("Uploading the diff report failed, this message is mainly used to remind the maintainers of PMD.")