phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Set beginColumn for the test nodes, so that no RuntimeException is thrown.

Browse Source
This commit is contained in:
Andreas Dangel
2014-11-16 12:00:11 +01:00
parent 5f35ded04b
commit fbe6742666
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pmd-plsql/src/test/java/net/sourceforge/pmd/lang/plsql/dfa/StatementAndBraceFinderTest.java
View File

@ -7,6 +7,7 @@ import java.util.List;
import net.sourceforge.pmd.PMD; import net.sourceforge.pmd.PMD;
import net.sourceforge.pmd.lang.LanguageRegistry; import net.sourceforge.pmd.lang.LanguageRegistry;
import net.sourceforge.pmd.lang.ast.AbstractNode;
import net.sourceforge.pmd.lang.dfa.DataFlowNode; import net.sourceforge.pmd.lang.dfa.DataFlowNode;
import net.sourceforge.pmd.lang.dfa.NodeType; import net.sourceforge.pmd.lang.dfa.NodeType;
import net.sourceforge.pmd.lang.dfa.StartOrEndDataFlowNode; import net.sourceforge.pmd.lang.dfa.StartOrEndDataFlowNode;
@ -16,6 +17,7 @@ import net.sourceforge.pmd.lang.plsql.ast.ASTExpression;
import net.sourceforge.pmd.lang.plsql.ast.ASTMethodDeclaration; import net.sourceforge.pmd.lang.plsql.ast.ASTMethodDeclaration;
import net.sourceforge.pmd.lang.plsql.ast.ASTProgramUnit; import net.sourceforge.pmd.lang.plsql.ast.ASTProgramUnit;
import net.sourceforge.pmd.lang.plsql.ast.ASTVariableOrConstantDeclarator; import net.sourceforge.pmd.lang.plsql.ast.ASTVariableOrConstantDeclarator;
import net.sourceforge.pmd.lang.plsql.ast.PLSQLNode;
import org.junit.Test; import org.junit.Test;
@ -184,12 +186,16 @@ public class StatementAndBraceFinderTest extends AbstractPLSQLParserTst {
assertTrue(dfn.isType(NodeType.LABEL_STATEMENT)); assertTrue(dfn.isType(NodeType.LABEL_STATEMENT));
} }
@Test(expected = RuntimeException.class) @Test
public void testOnlyWorksForMethodsAndConstructors() { public void testOnlyWorksForMethodsAndConstructors() {
StatementAndBraceFinder sbf = new StatementAndBraceFinder(LanguageRegistry.getLanguage(PLSQLLanguageModule.NAME).getDefaultVersion().getLanguageVersionHandler().getDataFlowHandler()); StatementAndBraceFinder sbf = new StatementAndBraceFinder(LanguageRegistry.getLanguage(PLSQLLanguageModule.NAME).getDefaultVersion().getLanguageVersionHandler().getDataFlowHandler());
sbf.buildDataFlowFor(new ASTMethodDeclaration(1)); PLSQLNode node = new ASTMethodDeclaration(1);
((AbstractNode)node).testingOnly__setBeginColumn(1);
sbf.buildDataFlowFor(node);
//sbf.buildDataFlowFor(new ASTConstructorDeclaration(1)); //sbf.buildDataFlowFor(new ASTConstructorDeclaration(1));
sbf.buildDataFlowFor(new ASTProgramUnit(1)); node = new ASTProgramUnit(1);
((AbstractNode)node).testingOnly__setBeginColumn(1);
sbf.buildDataFlowFor(node);
} }
private static final String TEST1 = private static final String TEST1 =