Clément Fournier
13009e78b2
Merge branch 'master' into 7.0.x
2020-11-28 15:24:10 +01:00
Clément Fournier
4f36ac3bd2
Merge branch 'master' into pr/2934
2020-11-28 14:40:09 +01:00
Clément Fournier
7eb530f035
Merge branch 'master' into pr/2940
2020-11-28 14:25:28 +01:00
Clément Fournier
ee59732ec5
[java-xpath] Cleanups after #2917
...
* Improve docs
* Add missing tests for XPath functions
* TypeIsFunction has been replaced with BaseContextNodeTestFun,
so this deletes the file
getCommentOn is still untested. I wonder whether we really need it,
also, it's inefficient and not specified at all (because it's unused).
2020-11-25 18:39:19 +01:00
Andreas Dangel
9d51879088
Small fixes (since=7.0.0, unused ExpectedExeption)
2020-11-25 15:58:35 +01:00
Andreas Dangel
3651e66c12
Merge branch 'pmd/7.0.x' into pr-2917
2020-11-24 09:11:08 +01:00
Andreas Dangel
346e67b3f0
Merge branch 'master' into pmd/7.0.x
2020-11-23 16:00:01 +01:00
Clément Fournier
9aaae814c4
Handle TNPE and LinkageE when loading type params
2020-11-23 14:40:32 +01:00
Clément Fournier
a5bcdb328a
Merge branch 'master' into issue-2911-class-leak
2020-11-23 14:37:17 +01:00
Andreas Dangel
1783b1daa1
Update pmd-java/src/main/resources/category/java/bestpractices.xml
...
Co-authored-by: Igor Moreno <igormoreno@gmail.com>
2020-11-23 13:55:48 +01:00
Andreas Dangel
e701f52d96
[java] Catch additional TypeNotPresentExceptions / LinkageErrors
...
These exceptions are indications of an incomplete auxclasspath
but should not fail PMD entirely.
Incomplete auxclasspath can still result in invalid violations,
either false positives or false negatives.
2020-11-21 16:38:26 +01:00
Andreas Dangel
02135513c9
[java] CompareObjectsWithEquals: Fix more false positives
2020-11-20 20:39:45 +01:00
Andreas Dangel
cda99a1629
[java] CompareObjectsWithEquals - whitelist java.lang.class and this
2020-11-20 16:41:41 +01:00
Andreas Dangel
2c950641d2
[java] Avoid false positives with literals
2020-11-20 15:50:30 +01:00
Andreas Dangel
a1297dfd09
[java] Consider comparison with null literal as valid
2020-11-20 12:20:25 +01:00
Igor Moreno
ff77650801
Fix typo: "an accessor" not "a"
2020-11-19 22:59:17 +01:00
Andreas Dangel
1e6c79c19f
[java] CompareObjectsWithEquals / UseEqualsToCompareStrings - Fix FN
...
Fixes false negatives in case fields are referenced with this.
Type resolution on PrimaryExpression works well enough to
simply check the type.
2020-11-19 21:08:15 +01:00
abhishek-kumar09
84e6c0997b
Correct Annotation Array Initialiation indents from checkstyle #8083
2020-11-16 00:36:30 +05:30
Clément Fournier
51c0df8770
Remove cache entirely
2020-11-14 17:48:14 +01:00
Clément Fournier
3ccdb5597a
Make overload without varargs
2020-11-14 17:15:42 +01:00
Clément Fournier
30124fef11
Don't cache enclosing class (pretty rare to hit it)
2020-11-14 16:54:11 +01:00
Clément Fournier
4ee7b7ae02
Load fewer class names
2020-11-14 16:44:27 +01:00
Clément Fournier
307eacd20a
Fix errors
2020-11-14 15:37:04 +01:00
Clément Fournier
00d76b03ab
Restrict caching to classes loaded by the bootstrap loader
2020-11-14 15:02:15 +01:00
Clément Fournier
4fe3874824
Simplify constructor of JavaTypeDefinitionSimple
2020-11-14 14:57:25 +01:00
Clément Fournier
7635a19ea4
Fix exception not thrown
2020-11-13 16:22:43 +01:00
Clément Fournier
2b10c79caa
Fix documentation
2020-11-13 15:15:44 +01:00
Clément Fournier
fbc12562ba
Extract changes to ast
2020-11-13 14:35:18 +01:00
Clément Fournier
c35b4e879e
Extract changes to invocation matchers
2020-11-13 14:32:32 +01:00
Clément Fournier
150f8c746e
Extract changes to xpath functions
2020-11-13 14:29:20 +01:00
Clément Fournier
51ca1a5961
Merge branch 'master' into 7.0.x
2020-11-11 22:19:14 +01:00
Clément Fournier
dfb5c4e2d2
Merge branch 'finish-905'
2020-11-11 22:18:32 +01:00
Clément Fournier
a5c42ddefc
Add test case for #2595
2020-11-11 15:33:38 +01:00
Clément Fournier
56a5ee536b
Deprecations for #905
2020-11-10 14:02:02 +01:00
Clément Fournier
9fab59cd45
Add test case for #2910
2020-11-10 11:30:01 +01:00
Andreas Dangel
770bfbe4d7
Merge branch 'pr-2900' into pmd/7.0.x
...
[java] Update UselessParentheses #2900
2020-11-06 14:57:26 +01:00
Andreas Dangel
77daa30bcc
Merge branch 'pr-2897' into pmd/7.0.x
...
[java] Update UnnecessaryFullyQualifiedName #2897
2020-11-06 14:28:54 +01:00
Andreas Dangel
a3f365a3fd
[java] UnnecessaryFullyQualifiedName - add comment for false positive
2020-11-06 14:25:16 +01:00
Andreas Dangel
18c2ab5621
Revert kotest workaround
...
This is a partial revert of bc0d26eeb5f5b626c2a5e98a0d7856da49cc4135
2020-11-06 11:16:22 +01:00
Andreas Dangel
54d4cc8f87
Revert "Add workaround for kotest/kotest#1815"
...
This reverts commit 930581d8440aec9d1b270932cd0c3465336dbe37.
2020-11-06 11:16:22 +01:00
Clément Fournier
f5690e1712
Add test cases from fixed issues
2020-11-05 10:05:24 +01:00
Clément Fournier
7665204310
Set ignore clarifying as default
2020-11-05 09:41:36 +01:00
Clément Fournier
d75b0d3462
Keep old name
2020-11-05 09:21:46 +01:00
Clément Fournier
a830c20225
Reimplement UselessParentheses
2020-11-05 09:19:58 +01:00
Clément Fournier
a26aeaf56a
Update reference files
2020-11-03 15:11:31 +01:00
Clément Fournier
2a6e631e85
Fix warnings
2020-11-03 14:37:22 +01:00
Clément Fournier
4351839f0e
Test effective visibility
2020-11-03 14:33:54 +01:00
Clément Fournier
b661abe3bd
Checkstyle
2020-11-03 14:16:58 +01:00
Clément Fournier
f8a3b2a1f6
Fix concurrent modification exception
2020-11-03 14:07:25 +01:00
Clément Fournier
afa5a168eb
Checkstyle
2020-11-03 07:55:44 +01:00