5415 Commits

Author SHA1 Message Date
Ryan Gustafson
4d127404d3 Fix bug 1928009 - Error using migration ruleset in PMD 4.2
AbstractRuleChainVisitor changed an 'if' to a 'while' to ensure all RuleReferences were followed to find the real underlying Rule.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5942 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-28 22:45:43 +00:00
Xavier Le Vourch
e84d41bebb '41' and '42' shortcuts for rulesets added
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@5933 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-26 21:31:19 +00:00
Xavier Le Vourch
8e193d6f2c preparing for the 4.2 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5926 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-26 00:43:37 +00:00
Romain Pelisse
1bd08483ad Adding missing license header here and there.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5925 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-24 03:40:43 +00:00
Romain Pelisse
36864eace5 Fix mvn2 build
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5924 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-24 01:37:15 +00:00
Tom Copeland
6b90caa59f Fixed licenses, these were files that I missed when PMD went to BSD several years ago.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5923 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-23 19:18:17 +00:00
Xavier Le Vourch
cceb12bbd7 invalid rule urls corrected
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5922 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-23 16:56:09 +00:00
Romain Pelisse
b23d90ce08 Removing this rule. It's not ready and not for 4.2.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5921 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-23 11:15:02 +00:00
Romain Pelisse
1e1d75fc1a Removing now useless System.err.println()
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5920 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-23 11:09:16 +00:00
Romain Pelisse
d0aae45ebd Mvn2 javadoc plugin seems to have "issues" when i build pmd javadoc. Disabling it.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5919 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 18:06:32 +00:00
Romain Pelisse
1ccaebd29e Adding a Checkstyle configuration file and enabling it in the mvn2 build.
This checkstyle configuration will check for missing/invalid javadoc or missing license (Already 5000 erros to correct with only those !)
Also added xref and javadoc generation in mvn2 build.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5918 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 17:54:39 +00:00
Romain Pelisse
ceab009812 Switching from deprecated AbstractRule to AbstractJavaRule.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5917 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 17:39:56 +00:00
Romain Pelisse
a9131b8146 Upgrade on the externalURLInfo control.
Removing a test case from a non yet finished rule (thks for the continous integration report :) )

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5916 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 17:34:59 +00:00
Romain Pelisse
f0290f8051 As suggested by Ryan, i added a control on the externalURLInfo. Now if there are some invalid ExternalInfoURL.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5915 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 17:26:41 +00:00
Romain Pelisse
8a2f5ec3de 1920155 - CheckResultSet: Does not pass for loop conditionals
Adding on more testcase

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5914 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 17:21:07 +00:00
Romain Pelisse
f2ca3e2029 Adding missing license header here and there.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5913 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 17:19:51 +00:00
Romain Pelisse
0576ff859f Adding missing license header here and there.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5912 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 17:00:13 +00:00
Xavier Le Vourch
0d1a48c825 download links updated
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5911 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 01:29:23 +00:00
Xavier Le Vourch
8f0b73c24e preparing 4.2rc2 release
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5909 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-22 00:46:16 +00:00
Xavier Le Vourch
5770de00f8 extra doc for testing correctness of new rule
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5908 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-21 02:28:25 +00:00
Xavier Le Vourch
5fc614d1ff xdocs: renaming finalising-rules.xml as rule-guidelines.xml
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5907 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-20 22:17:26 +00:00
Romain Pelisse
333d9f09b7 Correcting an erronous link.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5906 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-19 22:22:20 +00:00
Xavier Le Vourch
6619e19d35 Fixed formatting problems in loggers
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5905 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-19 21:47:08 +00:00
Romain Pelisse
7bb6e060ec Typo and TODO
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5904 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-19 12:42:01 +00:00
Xavier Le Vourch
e734404f20 code cleanup: extra debug log message removed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5903 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-17 05:12:05 +00:00
Xavier Le Vourch
a58cd8442e auxclasspath nested element for Type Resolution classpath
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5902 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-17 05:08:02 +00:00
Romain Pelisse
01eb3cadad Upgraded documentation and code of the new maxProblemCount attribute in PmdAntTask:
failOnViolation == true + problemCount not setted => fail if one violation or more is reported.
failOnViolation == true + problemCount is setted => fail if the problemCount threshold is reached
failOnViolation not setted + problemCount is setted => fail if the problemCount threshold
failOnViolation to false + problemCount is setted => depends on the order ant to the setting, most likely going not to fail.

I think this is the more appropriate solution. maxProblemCount is no longer tied up to the failOnViolation parameter. 

When a use maxProblemCount, it will automaticly set failOnViolation to true.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5901 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-15 10:54:56 +00:00
Ryan Gustafson
508e7ca7e2 Preserve checked rules across table sorts on Project PMD Preferences.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5900 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-15 08:31:13 +00:00
Ryan Gustafson
4c8b07d9a8 Remove unused JSmartPanel class.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5899 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-15 03:46:42 +00:00
Ryan Gustafson
2ca4f85eef Fixed bug 1913536 - Rule Designer does not recognize JSP(XML)
Remove duplicate knowledge of PMD language internals and replace with SourceTypeHandler.  Much cleaner!

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5898 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-15 03:37:00 +00:00
Ryan Gustafson
2fa65a65ab Fixed bug 1912831 - False + UnusedPrivateMethod with varargs
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5897 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 20:09:55 +00:00
Ryan Gustafson
635e29a219 Add on demand import test case for typeresolution/UnusedImports. For real this time. :)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5896 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 20:07:28 +00:00
Ryan Gustafson
dcbb0f70d6 Add on demand import test case for typeresolution/UnusedImports.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5895 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 19:55:36 +00:00
Ryan Gustafson
4dfa856188 Clear Symbol Table view when code is re-parsed (e.g. Go button pressed).
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5894 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 19:23:49 +00:00
Ryan Gustafson
2ecbe0361a Added MethodNameDeclarations at ClassScope in the Designer Symbol Table view.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5893 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 19:17:13 +00:00
Ryan Gustafson
b01cb0139b Fix ClassCastException when not an ASTTreeNode (e.g. when browsing symbol table).
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5892 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-13 19:06:53 +00:00
Romain Pelisse
e77489b37a Applied patch 1849474 - New property for PMD ant task
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5891 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-12 15:38:35 +00:00
Ryan Gustafson
c595c61edd Add -auxclasspath option for specifying Type Resolution classpath from command line.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5890 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-11 20:03:29 +00:00
Ryan Gustafson
e9ccc61428 Fix 1909929 - clean violation review is not selective enough
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5889 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-11 01:21:18 +00:00
Ryan Gustafson
8c0e1d6b3d Fix 1909929 - clean violation review is not selective enough
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5888 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-11 01:21:10 +00:00
Ryan Gustafson
1e810aa4e1 Correct logger class.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5887 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-10 08:53:19 +00:00
Ryan Gustafson
058b983b55 Don't die when selecting multiple projects, and one happens to be a non-Java project.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5886 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-10 06:59:34 +00:00
Ryan Gustafson
29ba46ce41 Don't puke on Classes in the default package.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5885 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-10 06:45:38 +00:00
Tom Copeland
758c7865ee Removed wrong link
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5884 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-08 17:03:40 +00:00
Xavier Le Vourch
7bfac6fd95 version updated to 3.2.4.v200803071500
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5883 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 23:06:44 +00:00
Xavier Le Vourch
9cdb5b2f8d version updated to 3.2.4.v200803071500
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5882 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 23:05:10 +00:00
Xavier Le Vourch
25fe8e6021 update to pmd 4.2rc1
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5881 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 22:40:03 +00:00
Xavier Le Vourch
36644e4a09 updates to release script
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5880 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 21:44:53 +00:00
Xavier Le Vourch
d4f47ac9ee 4.2rc1 download and what's new links
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5879 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 21:24:13 +00:00
Xavier Le Vourch
6b1b6324e4 preparing for 4.2rc1:
- version number and release date updated

- maven2.beta used for deployment as this release should not be mirrored
on official mvn mirrors.

The use of two maven repositories should be configurable based on version
info in release script.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5877 51baf565-9d33-0410-a72c-fc3788e3496d
2008-03-07 20:53:38 +00:00