2665 Commits

Author SHA1 Message Date
Clément Fournier
27d7a6c02c Accomodate children iterable for specialization 2020-01-19 05:57:39 +01:00
Clément Fournier
436409e707 Merge branch 'issue-1984' 2020-01-17 18:32:16 +01:00
Andreas Dangel
0e2b9cf5b4 [java][apex] Move *MetricsProvider into own classes into metrics packages
Make *Metrics.reset package private again
2020-01-17 15:41:54 +01:00
Andreas Dangel
4450d826f7 Merge branch 'pr-2225'
[core] CPD: report endLine / column informations for found duplications
2020-01-17 14:59:02 +01:00
Clément Fournier
d9ad819dab Replace usages of node methods everywhere 2020-01-17 11:57:19 +01:00
Andreas Dangel
b71575fa36 [java] Cyclomatic complexity is misreported (lack of clearing metrics cache)
Fixes #1984
2020-01-17 11:35:32 +01:00
Andreas Dangel
f53993427c Merge branch 'pr-2172'
[core] Deprecate jjtree methods from the Node interface
2020-01-17 08:18:50 +01:00
Clément Fournier
741bb0b218 Update usages 2020-01-16 22:29:41 +01:00
Clément Fournier
3062d59892 Merge branch 'master' of github.com:pmd/pmd 2020-01-16 22:28:52 +01:00
Clément Fournier
d9719e850c Deprecate ASTCatchStatement::getBlock for #2202 2020-01-16 22:28:40 +01:00
Andreas Dangel
9c682e4a88 Merge branch 'pr-2200'
[java] InvalidLogMessageFormat: handle zero placeholders correctly
2020-01-16 18:08:26 +01:00
Maikel Steneker
8ed19b5da6 Added CPD column information for Java. 2020-01-15 15:43:56 +01:00
Clément Fournier
99fdede0aa Merge branch 'issue-2212' 2020-01-12 23:28:33 +01:00
Clément Fournier
904fb14e8b Use interface instead of AbstractAnyTypeDeclaration 2020-01-12 23:27:24 +01:00
Clément Fournier
820edada4f Add 'children' iterable method to Node interface 2020-01-12 18:18:38 +01:00
Clément Fournier
f7bd2d54b3 Add kotlin test sources to build-helper-mvn-plugin
Intellij doesn't pick up on the sources
correctly and classifies them as resources otherwise
2020-01-11 20:33:58 +01:00
Andreas Dangel
bc92fa4590 [java] JavaRuleViolation reports wrong class name
Fixes #2212
2020-01-11 12:51:21 +01:00
Andreas Dangel
398b683565 Merge branch 'pr-2177'
[lang-test] Factorize parsing logic for tests
2020-01-10 14:07:29 +01:00
Andreas Dangel
c53d9508e9 Small changes from code review
* rename BaseParserHelper
* Not using org.jetbrains.annotations.NotNull
2020-01-10 12:18:43 +01:00
Andreas Dangel
6bea1e618b [java] InvalidLogMessageFormat: handle zero placeholders correctly
Fixes #2196

Also refactors the implementation to not use a XPath query anymore.
2020-01-06 18:02:41 +01:00
Clément Fournier
e335e069f8 Merge branch 'master' into deprecate-jjtree-methods 2020-01-05 23:17:25 +01:00
Clément Fournier
0ff87229ff Remove TokenBasedNode
I don't think we should expose tokens as an API
yet. They're an implementation detail, not used
much, and the AST should be able to reflect all
the information that can be found in the tokens.

The methods of AbstractNode can be pulled down
to AbstractJjtreeNode and made protected.
2020-01-05 23:13:04 +01:00
Andreas Dangel
a0d0a22e7b Merge branch 'pr-2190'
[java] Deprecations for statements PR

Prerequisite for #2164 for PMD 7.0.0
2020-01-05 19:30:52 +01:00
Andreas Dangel
f973ad6ef3 Merge branch 'pr-2185'
[core] Internalize API that exposes ResourceLoader
2020-01-05 19:18:18 +01:00
Andreas Dangel
4cf6291ecb Fix pmd 2020-01-05 18:20:26 +01:00
Juan Martín Sotuyo Dodero
caaa5eba9a Fix issue with analysis of IPv6 mapper IPv4 2020-01-04 04:37:13 -03:00
Egor18
3b8d694be3 Fix odd logic in AvoidUsingHardCodedIPRule 2019-12-29 22:00:13 +03:00
Clément Fournier
f33291e372 Deprecate ASTYieldStatement implementing TypeNode 2019-12-26 18:53:22 +01:00
Clément Fournier
0a0bb6e4bb Rename getGuardExpressionNode -> getCondition 2019-12-26 18:47:28 +01:00
Clément Fournier
41baa353b0 Deprecate API of TryStatement that will be renamed 2019-12-26 18:40:24 +01:00
Clément Fournier
05870c98cc Deprecate RulesetFactory constructors 2019-12-24 14:39:20 +01:00
Clément Fournier
9023d86945 Merge branch 'master' into deprecate-jjtree-methods 2019-12-23 12:41:08 +01:00
Clément Fournier
a7c5a1f0be Cleanup PMD.EOL in tests
Instead, normalize line endings in parse method.
This makes sure test code snippets are portable
and readable. For now they're platform-specific,
and assume that the resource files are saved with
the platform-specific line separator. This may not
be the case, as eg a git file may be checked out
with CRLF on a unix system.
2019-12-22 20:16:19 +01:00
Clément Fournier
80534a7e69 Fix line endings 2019-12-22 19:53:10 +01:00
Clément Fournier
5906564e23 Fix resource path 2019-12-20 19:01:10 +01:00
Clément Fournier
8afe5ae7a8 Abstract away parser utils
Convert a few pieces of code

Share with modelica

Remove yet another dup

Fix tests

Doc

Share with plsql

Fix tests

Fix build

Cleanup

Minimize diff

Share with JSP module

Share with JS module

Share with XML module

Share with VisualForce module

Share with Scala module

Fix last tests
2019-12-20 18:30:17 +01:00
Andreas Dangel
f67819e05a Merge branch 'pr-2069'
[java] CommentRequired: make property names consistent
2019-12-20 11:38:03 +01:00
Andreas Dangel
0ff3216b48 Merge branch 'pr-2150'
[java] Fix false negative in AvoidLiteralsInIfCondition
2019-12-18 09:50:19 +01:00
Clément Fournier
627e258458 Revert 2019-12-17 17:49:01 +01:00
Clément Fournier
86b274c681 Make generic visitor superclass
Use raw supertype to avoid conflicts
2019-12-17 17:39:13 +01:00
Clément Fournier
2f37e1c256 Deprecate jjt* methods 2019-12-17 17:39:13 +01:00
Clément Fournier
1aabc53fa2 Deprecate childrenAccept in all modules 2019-12-17 17:39:13 +01:00
Clément Fournier
98df6bda1c Add TokenBasedNode, AbstractJjtreeNode 2019-12-17 17:39:13 +01:00
Andreas Dangel
d8ed0cf45e [java] CommentRequired: Deprecated property "headerCommentRequirement" 2019-12-17 15:44:02 +01:00
snuyanzin
6cec74851a [java] CommentRequired: Make headerCommentRequirement ignored by default, make tests more targeted
Refs #1683
2019-12-17 12:31:17 +01:00
snuyanzin
88ff3f0628 [java] CommentRequired: Separate header comment from class comment and header top-level comment
Refs #1683
2019-12-17 12:30:05 +01:00
Andreas Dangel
1480bfeaa4 Merge branch 'pr-2165'
[java] Deprecate JavaQualifiedName and a few other things
2019-12-17 10:45:34 +01:00
Clément Fournier
6aadcb29a3 Fix UnnecessaryLocalBeforeReturn FP with method reference 2019-12-16 17:31:56 +01:00
Clément Fournier
50560e0aac Fix deprecated attribute usage 2019-12-16 16:23:27 +01:00
Andreas Dangel
7b5e9703ec [java] AvoidLiteralsInIfCondition: add property ignoreExpressions
The property ignoreExpressions is set to true in order to keep
the rule backwards compatible.
2019-12-16 11:17:25 +01:00