824 Commits

Author SHA1 Message Date
Artem Krosheninnikov
2b882e8655 fix issue #2594, update exec-maven-plugin everywhere 2020-06-18 00:48:57 +03:00
Clément Fournier
d631b79307 Deprecate stuff for #2491 2020-06-14 21:36:33 +02:00
Andreas Dangel
8defb2fde2 Add missing relativePath configuration in all pom modules 2020-06-07 12:36:58 +02:00
Andreas Dangel
ab04bdacdd [maven-release-plugin] prepare for next development iteration 2020-05-24 17:34:34 +02:00
Andreas Dangel
229cb2bdca [maven-release-plugin] prepare release pmd_releases/6.24.0 2020-05-24 17:34:25 +02:00
Andreas Dangel
e1cd3b4c8d Merge branch 'pr-2487'
[all] Cleanup rule test xml #2487
2020-05-22 19:41:01 +02:00
Andreas Dangel
6049126228 Merge branch 'pr-2465'
[dependencies] Upgrade hamcrest, mockito and JUnit #2465
2020-05-22 11:46:04 +02:00
Andreas Dangel
f930491538 [apex] Cleanup rule test xml files
Avoid unnecessary CDATA for description
Use 4 space indentation instead of tabs
Remove trailing whitespace
End file with a newline
2020-05-16 18:55:58 +02:00
Gwilym Kuiper
3571608234 Handle chained method calls.
This wasn't working because they had a null image. Turns out that nodes
have a method called `hasImageEqualTo` which handles the null case for
us.
2020-05-06 11:26:14 +01:00
Gwilym Kuiper
acbf53e8ab Variable is used if method is called on it 2020-05-06 11:11:13 +01:00
Artem Krosheninnikov
3fba3f6217 Update hamcrest to 2.2, Junit to 4.13, mockito to 2.28.2 2020-05-04 23:00:28 +03:00
Andreas Dangel
522e98b65f Merge branch 'pr-2446'
[core] Update maven-compiler-plugin to 3.8.1 #2446
2020-04-30 19:29:38 +02:00
Andreas Dangel
4192f04c1d [apex] clarify AvoidGlobalModifier, refs #2298 2020-04-27 19:41:33 +02:00
Artem Krosheninnikov
3a72f3c4fa update maven-compiler-plugin to 3.8.1 and remove workaround for a bug in IDEA that was closed 2020-04-26 14:27:37 +03:00
Andreas Dangel
4308c545e5 [maven-release-plugin] prepare for next development iteration 2020-04-24 10:53:12 +02:00
Andreas Dangel
921c65f5ab [maven-release-plugin] prepare release pmd_releases/6.23.0 2020-04-24 10:53:00 +02:00
Andreas Dangel
96d542c00d Prepare pmd release 6.23.0 2020-04-24 10:42:57 +02:00
Clément Fournier
96e9127eae Cleanup TooManyFieldsRule
It used a descendant check unnecessarily,
can use the rulechain now
2020-04-23 19:33:55 +02:00
Clément Fournier
f7fc5c5687 Merge branch 'master' into apex-deprecate-ast 2020-04-20 10:56:40 +02:00
Andreas Dangel
56ab75bfd1 [apex] Refactor usage of internal getNode()
This exposes more information directly on PMD's AST node
rather then giving away the inner jorje node.
2020-04-17 20:10:37 +02:00
Andreas Dangel
74200132e3 [apex] Internalize AST constructors and helper implementations 2020-04-17 18:44:18 +02:00
Andreas Dangel
08d31c62a9 Merge branch 'master' into pr-2377 2020-04-16 17:52:03 +02:00
Clément Fournier
bcf90ceb8a Externalize creator for XPath rule 2020-04-08 21:35:34 +02:00
Andreas Dangel
a86e172b98 Merge branch 'pr-2395'
[apex] New Rule: Unused local variables #2395
2020-04-04 18:08:41 +02:00
Andreas Dangel
9db695eee2 [apex] Add additional test case for unused local var shadowing a field 2020-04-04 18:07:23 +02:00
Andreas Dangel
6196da44b0 Merge branch 'pr-2396'
[apex] New rule: field declarations should be at start #2396
2020-04-04 17:44:07 +02:00
Andreas Dangel
f1759c68c6 [apex] Move new rule def up in codestyle.xml 2020-04-04 17:38:13 +02:00
Kieran Black
746797e805 added tests for line breaks 2020-04-03 15:43:56 -04:00
Kieran Black
d09d4de308 fixed WITH SECURITY_ENFORCED regex to recognise line break characters 2020-04-03 12:25:22 -04:00
Gwilym Kuiper
7b06d3001f Make UnusedLocalVariableRule a rule chain rule 2020-04-03 15:27:37 +01:00
Gwilym Kuiper
6a70bda5e6 Should be 6.23.0 for release 2020-04-03 15:19:12 +01:00
Gwilym Kuiper
e94db8bf22 Make rule a RuleChain 2020-04-03 15:18:22 +01:00
Gwilym Kuiper
58185fce2f Extract constant 2020-04-03 15:17:29 +01:00
Gwilym Kuiper
1331eec208 Make comment clearer 2020-04-03 15:17:01 +01:00
Gwilym Kuiper
4aae0e2ebf Fix checkstyle violations 2020-04-03 15:16:52 +01:00
Gwilym Kuiper
9e07836659 Correctly detect fields that appear after static initialization blocks 2020-04-03 15:10:30 +01:00
Gwilym Kuiper
292bcbbf04 Correctly detect that fields should go before block statements 2020-04-03 15:01:56 +01:00
Gwilym Kuiper
eeac579661 Correctly detect properties before fields 2020-04-03 13:58:49 +01:00
Gwilym Kuiper
5d1ffa5a55 Correctly detect fields after inner classes 2020-04-03 13:57:34 +01:00
Gwilym Kuiper
1359c88e90 Also produce errors in inner classes 2020-04-03 13:48:31 +01:00
Gwilym Kuiper
eb8e7eabd8 Fix field declaration location rule around nested classes 2020-04-03 13:45:34 +01:00
Gwilym Kuiper
9c13702e39 Massively simplify rule with custom comparator 2020-04-03 13:38:40 +01:00
Gwilym Kuiper
41f6a595a9 Include variable name in violation message 2020-04-01 11:58:32 +01:00
Gwilym Kuiper
504cf440a3 Inculde field name in violation message 2020-04-01 11:55:50 +01:00
Gwilym Kuiper
3f0dc27a4a Add tests for apex field declarations should be at start 2020-04-01 11:47:32 +01:00
Gwilym Kuiper
1d62a1f984 Add rule definition in codestyle.xml 2020-04-01 11:28:14 +01:00
Gwilym Kuiper
8acb63870c Add basic implmentation of FieldDeclarationsShouldBeAtStart for apex 2020-04-01 11:24:34 +01:00
Gwilym Kuiper
abbe46c7ba Add another test for variable usage in blocks 2020-04-01 09:28:18 +01:00
Gwilym Kuiper
705fa2563a Fixup checkstyle issues 2020-04-01 09:28:11 +01:00
Gwilym Kuiper
80c26bf537 Add tests and fix up issues found while writing them 2020-04-01 09:15:04 +01:00