3249 Commits

Author SHA1 Message Date
Tom Copeland
5391fc6d8e Some rule name normalization
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3392 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-22 14:10:56 +00:00
Tom Copeland
8e3a03e2d3 Oops, missed a few
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3391 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-22 14:06:23 +00:00
Tom Copeland
30ff27a3f2 tweak
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3390 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-22 13:55:47 +00:00
Miguel Griffa
e7d0ba95ba implemented [ 1151286 ] Use ArrayList instead of Vector
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3389 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-16 15:54:38 +00:00
Miguel Griffa
2b6d1c03b6 fixed [ 1162245 ] Empty while statement misses while(true) ;
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3388 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-14 14:07:11 +00:00
Miguel Griffa
1cac56ca42 implemented [ 1161586 ] Add new rules to junit
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3387 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-14 14:01:32 +00:00
Tom Copeland
e70f255cdc Rewrote MethodWithSameNameAsEnclosingClass in Java, which cut its execution time by two orders of magnitude. Good times!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3386 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-11 03:41:32 +00:00
Tom Copeland
44388aa5c7 Oops, had removed image by mistake
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3385 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-11 02:23:32 +00:00
Tom Copeland
0101fa2dde Added newrules
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3384 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-11 01:33:03 +00:00
Tom Copeland
078ca08953 Added benchmarking utility
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3383 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 23:00:02 +00:00
Tom Copeland
9d035416e2 Fixed several places where rules were erroring out
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3382 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 22:38:00 +00:00
Tom Copeland
2025cb02b0 Renamed file to avoid confusion with net.sourceforge.pmd.RuleSet
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3381 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 21:32:28 +00:00
Tom Copeland
aabe8c3e82 Renamed file to avoid confusion with net.sourceforge.pmd.RuleSet
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3380 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 21:29:30 +00:00
Tom Copeland
65b5004c8f Fixed ConstructorCallsOverridableMethod, all tests pass, w00t!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3379 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 14:50:47 +00:00
Tom Copeland
2be79a57b7 Fixed DoubleCheckedLocking
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3378 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 14:30:57 +00:00
Tom Copeland
0d691dce3c More notes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3377 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 04:11:51 +00:00
Tom Copeland
d41ba361ae Added more small tasks
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3376 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 04:03:13 +00:00
Tom Copeland
ab392027c1 Added comment about odd 'final' modifier handling
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3375 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 03:58:03 +00:00
Tom Copeland
606e83b0f5 Fixed an apparent grammar bug - it wouldn't parse class declarations within methods. I wonder if I broke anything else, though... also, fixed AccessorClassGeneration
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3374 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 03:52:53 +00:00
Tom Copeland
ee2fd2fd2d Fixed CyclomaticComplexity
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3373 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:50:33 +00:00
Tom Copeland
4d9fc5a512 A bunch fixed at one fell swoop
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3372 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:41:40 +00:00
Tom Copeland
87fbfcb538 Fixed CloseConnection
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3371 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:30:35 +00:00
Tom Copeland
83e78918cc Fixed CouplingBetweenObjects
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3370 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:24:18 +00:00
Tom Copeland
2ffde8fa44 Fixed EmptyCatchBlock
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3369 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:19:41 +00:00
Tom Copeland
5b3efc7ad7 Fixed EmptyStaticInitializer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3368 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:18:07 +00:00
Tom Copeland
0563e34b70 Fixed FinalFieldCouldBeStatic
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3367 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:16:30 +00:00
Tom Copeland
7a92aedc44 MethodWithSameNameAsEnclosingClass
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3366 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:13:37 +00:00
Tom Copeland
46ed3ec366 Fixed MissingStaticMethodInNonInstantiatable
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3365 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:04:38 +00:00
Tom Copeland
5c4ed921d8 Fixed NonStaticInitializer
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3364 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 01:02:36 +00:00
Tom Copeland
487ba9cfdc Fixed OverrideBothEqualsAndHashcode
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3363 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 00:51:23 +00:00
Tom Copeland
0571da05e5 Fixed SimpleDateFormatNeedsLocale
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3362 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 00:47:17 +00:00
Tom Copeland
91ff16f2b0 Fixed SuspiciousConstantFieldName
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3361 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 00:45:36 +00:00
Tom Copeland
19349e9d88 Fixed SuspiciousEqualsMethodName
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3360 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 00:40:36 +00:00
Tom Copeland
1bed68129f Fixed TestClassWithoutTestCases
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3359 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-10 00:37:54 +00:00
Tom Copeland
1c25dd374a Fixed UnnecessaryConstructor
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3358 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 23:33:45 +00:00
Tom Copeland
8502055ebb Fixed UnnecessaryFinalModifier
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3357 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 22:50:28 +00:00
Tom Copeland
bdf72f19a0 Fixed UnnecessaryTemporaries
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3356 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 22:37:50 +00:00
Tom Copeland
e9ccb76a8f Fixed UnusedImports
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3355 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 22:32:13 +00:00
Tom Copeland
1629d81cfe Fixed UnusedModifier
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3354 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 15:59:18 +00:00
Tom Copeland
d3ebbadea3 Fixed UnusedPrivateMethod
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3353 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 15:07:26 +00:00
Tom Copeland
a6ddfba16e Fixed VariableNamingConventions. I probably changed the behavior with respect to local variables (since I deleted that callback), but no tests are defined for that case, so, until someone has some test cases that define what this rule is supposed to do with locals, word.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3352 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 15:00:53 +00:00
Tom Copeland
7c958f3fcf Fixed CloneThrowsCloneNotSupportedException
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3351 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:27:04 +00:00
Tom Copeland
ef0f52dd26 Fixed CloneMethodMustImplementCloneable
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3350 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:24:39 +00:00
Tom Copeland
e1f4d90b2a Fixed ProperCloneImplementation
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3349 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:21:07 +00:00
Tom Copeland
af693f7d0a Fixed AvoidProtectedFieldInFinalClass
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3348 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:16:53 +00:00
Tom Copeland
2ce8964724 Fixed EmptyStatementNotInLoop
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3347 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:15:08 +00:00
Tom Copeland
e4ae774db6 Fixed LooseCoupling
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3346 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:11:36 +00:00
Tom Copeland
5e99dff1b8 Fixed TooManyFields
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3345 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 14:06:43 +00:00
Tom Copeland
69912a415d Fixed UseSingleton
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3344 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 00:34:23 +00:00
Tom Copeland
865f9f90cc Fixed MissingSerialVersionUID
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3343 51baf565-9d33-0410-a72c-fc3788e3496d
2005-03-09 00:19:50 +00:00