1964 Commits

Author SHA1 Message Date
Andreas Dangel
5d72bd8deb Merge branch 'master' into experimental-apex-parser 2023-11-10 11:55:18 +01:00
Andreas Dangel
bd28fbea5e Merge branch 'master' into issue-4722-apex-fixes 2023-11-09 11:56:45 +01:00
Andreas Dangel
195d56d8d0 [apex] Verify qualified names for method arguments with generics
Note: previously, there was no space between type params, now there is.

Refs #4722
2023-11-09 11:51:13 +01:00
Andreas Dangel
31a1b86769 [apex] Fix formal comment handling for Fields
Note: Apex Jorje variant didn't consider comments for fields at all.

Refs #4722
2023-11-09 10:42:46 +01:00
Andreas Dangel
e33fe924e9 [apex] Fix ApexDoc for interface methods
Interface methods are implicit public and abstract

Refs #4722
2023-11-09 09:38:21 +01:00
Andreas Dangel
83e6377752 [apex] Fix FieldNamingConventions reporting wrong lines
Using now FieldDeclarations instead of Fields for report location.

Refs #4722
2023-11-09 09:15:32 +01:00
Andreas Dangel
d586a3d23e [apex] Fix FieldDeclarationsShouldBeAtStartRule reporting wrong lines
Using now FieldDeclarations instead of Fields for report location.

Refs #4722
2023-11-07 20:05:30 +01:00
Andreas Dangel
3428baec4f [apex] AvoidDeeplyNestedIfStmts - add test
now the reported violations are correct: each if block is reported.
With Apex Jorje, the line numbers of the second if block were wrong and
two violations on the same line were
reported.
2023-11-07 19:52:44 +01:00
Andreas Dangel
cd6712598e [apex] Fix EmptyStatementBlock false positive with empty catch
For empty catch blocks, there is the separate rule EmptyCatchBlock.
EmptyStatementBlock shouldn't report these.

Refs #4722
2023-11-07 19:33:04 +01:00
Andreas Dangel
4574cb251c [apex] Fix AvoidNonExistentAnnotationsRule for enum values 2023-11-05 21:42:29 +01:00
Andreas Dangel
cf51fa2c45 [apex] Fix AntlrVersionCheckSuppression
This must not be called in multiple threads as we otherwise stop logging
to System.err.
2023-11-05 19:28:23 +01:00
Andreas Dangel
5f5c63bab9 [apex] OperationWithHighCostInLoop: add test for SObjectDescribeOptions 2023-10-28 12:25:27 +02:00
Andreas Dangel
8b4f677774 Merge branch 'master' into pr-4677 2023-10-28 12:10:35 +02:00
Andreas Dangel
c7cc050983 [apex] OperationWithHighCostInLoop - support System.Schema... as well
And improve test cases
2023-10-28 12:07:23 +02:00
Andreas Dangel
95609960ac [apex] OperationWithHighCostInLoop - improve rule doc 2023-10-28 11:52:59 +02:00
Andreas Dangel
6d240b2a75 [apex] performance.xml - sort rules alphabetically 2023-10-28 11:24:56 +02:00
Juan Martín Sotuyo Dodero
8e3d60a772 Merge branch 'master' into remove-apexversion 2023-10-19 21:34:35 -03:00
Andreas Dangel
b811d3097e Merge branch 'master' into update-experimental-apex-parser 2023-10-19 11:07:21 +02:00
Andreas Dangel
0c53b69e82 Merge pull request #4586 from adangel:ruleset-xml
Use explicit encoding in ruleset xml files #4586
2023-10-19 09:41:57 +02:00
Thomas Prouvot
f4c3fc02a8 Update pmd-apex/src/main/resources/category/apex/performance.xml
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2023-10-18 15:42:09 +02:00
Thomas Prouvot
f0f05c6e2c Update pmd-apex/src/main/resources/category/apex/performance.xml
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
2023-10-18 15:41:38 +02:00
Andreas Dangel
8528a8ed7d Merge branch 'master' into experimental-apex-parser 2023-10-02 19:40:59 +02:00
Andreas Dangel
345bb24a25 [release] prepare for next development iteration 2023-09-30 17:15:59 +02:00
Andreas Dangel
720b9a328b [release] prepare release pmd_releases/7.0.0-rc4 2023-09-30 17:15:54 +02:00
Andreas Dangel
abbee4bb5c Merge pull request #4610 from adangel:issue-4453-apex-link-arrayoutofbounds
[apex] Add rule test for UnusedMethod #4610
2023-09-28 11:16:36 +02:00
Andreas Dangel
4d185d5a76 Merge branch 'master' into pr-4605 2023-09-28 09:26:01 +02:00
Andreas Dangel
3e7e050251 [apex] Remove ApexNode.getApexVersion() 2023-09-22 19:39:42 +02:00
Andreas Dangel
e191bb913a Fix unused import 2023-09-21 17:31:09 +02:00
Andreas Dangel
3757191d4b [apex] Refactor AntlrVersionCheckSuppression 2023-09-21 17:20:39 +02:00
Andreas Dangel
b015bda6ce [apex] Use current languageVersion for ApexVersion property 2023-09-21 17:05:52 +02:00
Andreas Dangel
55ee8b3461 [apex] Improve handling of <clinit> and such... 2023-09-21 16:47:58 +02:00
Andreas Dangel
22f5a09715 Fix pmd issues - LooseCoupling 2023-09-14 11:03:28 +02:00
Thomas Prouvot
2d7521401d Add apex new rule OperationWithHighCostInLoop 2023-09-14 10:10:37 +02:00
Andreas Dangel
82bc73c825 Merge branch 'master' into pr-4479 2023-09-14 09:56:38 +02:00
Andreas Dangel
30416aee1a [apex] ASTMethod#getImage - Use BaseApexClass
Refs #4479
2023-09-14 09:34:14 +02:00
Andreas Dangel
17601960a3 [core][apex] Support TextDocument#offsetAtLineColumn
- not for FragmentedTextDocuments

Refs #4479
2023-09-14 09:33:31 +02:00
Andreas Dangel
347d5992d1 Merge pull request #4649 from rcorfieldffdc:defect/4646-apex-soql-injection-sobjecttype-token-variables
[apex] Add SObjectType and SObjectField to list of injectable SOQL variable types #4649
2023-09-09 12:19:10 +02:00
Andreas Dangel
7d0e1f00cc [doc] Update release notes (#4649, #4646) 2023-09-09 12:11:19 +02:00
Andreas Dangel
32afa53f8e All language modules: getInstance()
Use a consistent implementation of getInstance().
Now all modules resolve against the LanguageRegistry.
2023-08-24 16:01:27 +02:00
Andreas Dangel
80856732cc Fix checkstyle 2023-08-24 14:19:36 +02:00
Andreas Dangel
8511c7b0e1 [core] Move PmdCapableLanguage to n.sf.pmd.lang 2023-08-24 11:42:50 +02:00
Andreas Dangel
932ac33d15 Merge branch 'master' into pr-4397 2023-08-24 09:48:28 +02:00
Andreas Dangel
df08d08608 [apex] Remove cpd property CASE_SENSITIVE 2023-08-24 09:10:06 +02:00
Richard Corfield
4151ca13f2 Fix Checkstyle errors by changing tab indentation to spaces
mvnw clean verify - now passes.
2023-08-18 17:53:19 +01:00
Richard Corfield
8f19067535 A neater set instantiation 2023-08-18 17:33:57 +01:00
Richard Corfield
2ab8447654 Remove the tests related to issue 4650
This commit will need to be reverted in 4650's branch.
2023-08-18 17:28:06 +01:00
Richard Corfield
bcbaffcf21 Add unit tests for the behavior I hope to see
Two of these tests are failing. It doesn't recognise constants.
I guess that it never has recognised constants, and this is another
problem in the code. I don't know whether to try to fix this or consider
it a different problem so I can make smaller pull requests.
2023-08-17 10:59:59 +01:00
Richard Corfield
d85a1a7cfe Add SObjectType and SObjectField to list of injectable SOQL variable types 2023-08-17 10:07:51 +01:00
Andreas Dangel
894d9fba84 Merge branch 'master' into pr-4397 2023-08-17 09:31:53 +02:00
Andreas Dangel
b73611f013 Merge branch 'master' into pr-4380 2023-08-10 17:37:36 +02:00