Commit Graph

2969 Commits

Author SHA1 Message Date
534bfe3c55 Merge branch 'pr-2572'
[cpd] Allow CPD tests based on a text dump #2572
2020-06-18 20:09:58 +02:00
0f06f5132a Merge branch 'pr-2593'
[java] NPathComplexity should mention the expected NPath complexity #2593
2020-06-18 15:09:35 +02:00
fd63c97d33 [java] NPathComplexityRule: Use String.valueOf consistently 2020-06-18 15:07:00 +02:00
ca44ca3964 Merge branch 'pr-2557'
[java] UseProperClassLoader can not detect the case with method call … #2557
2020-06-18 15:03:43 +02:00
5579ddc21a [java] UseStringBufferForStringAppends: add good example 2020-06-18 14:48:34 +02:00
dda76be8ae [java] UseStringBufferForStringAppends: fix false negative with fields
And also fix false positive when concatenation is local to each
for-loop iteration.

Test cases originally from #1932

Author: jborgers <jborgers@jpinpoint.com>
2020-06-18 14:37:47 +02:00
f1d46714a5 [java] InefficientStringBuffering: fix another ternary false positive 2020-06-18 12:10:36 +02:00
4feb44b373 [java] AvoidCalendarDateCreation: fix more false positives 2020-06-18 11:58:37 +02:00
93930c40fb Merge branch 'master' into perf-AvoidCalendarDateCreation 2020-06-18 11:13:55 +02:00
f1400e37f7 [java] AvoidCalendarDateCreation - fix false positives 2020-06-18 11:11:15 +02:00
1e986ed793 [java] Fix false positive for AppendCharacterWithChar and InefficientStringBuffering
Also make both rules use the rule chain.
2020-06-18 10:28:12 +02:00
8e47ed3188 Merge branch 'master' into cpd-text-comp 2020-06-17 20:00:50 +02:00
ca0f6535a4 Merge branch 'pr-2573'
[java] DefaultPackage: Allow package default JUnit 5 Test methods #2573
2020-06-15 20:26:04 +02:00
62c5ebe482 Merge branch 'issue-2545' 2020-06-15 17:46:11 +02:00
527b75ceb4 Merge branch 'master' into issue-2545 2020-06-15 17:42:27 +02:00
2b19527649 Change property name to be camelCase 2020-06-15 17:41:30 +02:00
5706dbc4b8 fix issue #2570, add information about expected NPath complexity to rule violation message 2020-06-14 22:42:51 +03:00
b8e9ff19b2 [java] Fix rules InefficientStringBuffering and refactor existing rules
Rules affected additionally: AppendCharacterWithChar,
ConsecutiveLiteralAppends, InsufficientStringBufferDeclaration

Deprecate InefficientStringBuffering::isInStringBufferOperation
2020-06-14 12:59:06 +02:00
18191a1814 [java] Allow package default JUnit 5 Test methods
JUnit 5 allows test methods to be default / package scoped.
2020-06-13 23:19:51 -04:00
9fc15f0b91 Remove test
This is already tested in SourceCodeTest in pmd-core
2020-06-13 23:34:00 +02:00
da371182aa Convert Go tests 2020-06-13 22:00:58 +02:00
0d23c04c1b Check-in reference files 2020-06-13 21:47:49 +02:00
6ff4a1c4d4 Rename test file 2020-06-13 21:37:47 +02:00
344d02600c Convert java tests 2020-06-13 21:09:31 +02:00
67cca2a123 [java] Add test cases for InefficientStringBuffering
Originally from #1932

Author: jborgers <jborgers@jpinpoint.com>
2020-06-13 20:00:51 +02:00
488f38871e [doc] Update release notes, refs #1932 2020-06-13 19:49:12 +02:00
9dea892121 [java] Update rule AvoidCalendarDateCreation to use XPath 2.0 2020-06-13 19:48:50 +02:00
ca6a1b6b1f Add performance rule AvoidCalendarDateCreation
Including unit tests and examples. Originating from github.com/jborgers/PMD-jPinpoint-rules.
Links to more doc later.
2020-06-13 19:39:32 +02:00
b8e1ec95e1 [doc] Update release notes, refs #1932 2020-06-13 18:59:23 +02:00
8132a4af8d [java] UseIOStreamsWithApacheCommonsFileItem - Upgrade to XPath 2.0 2020-06-13 18:51:30 +02:00
0d4ed1a2ff [java] UseIOStreamsWithApacheCommonsFileItem - improve description 2020-06-13 18:47:25 +02:00
48583f9f58 [java] Rename new rule to UseIOStreamsWithApacheCommonsFileItem 2020-06-13 18:44:07 +02:00
bb3223d92c Add performance rule AvoidApacheCommonsFileItemNonStreaming
Including unit tests and examples. Originating from github.com/jborgers/PMD-jPinpoint-rules.
Links to more doc later.
2020-06-13 18:36:52 +02:00
bff3bcb487 Merge branch 'pr-2349'
[java] Optimize UnusedPrivateMethodRule #2349
2020-06-13 18:14:53 +02:00
ae5fec78cd [java] UnusedPrivateMethod - improve javadoc 2020-06-13 18:12:20 +02:00
30f3d11795 Fix java test 2020-06-13 18:00:57 +02:00
6c51cec444 Merge branch 'master' into uselessoverridingmethod-false-negative 2020-06-12 17:36:38 +02:00
5653400257 Merge branch 'pr-2519'
[java] Enable rule UnnecessaryCast (codestyle) #2519
2020-06-12 13:55:44 +02:00
a171ab8512 [doc] Update release notes and releases ruleset 2020-06-12 13:54:40 +02:00
7820c17435 [java] UnnecessaryCastRule: fix false positive with maps (nested generics) 2020-06-12 13:11:24 +02:00
8defb2fde2 Add missing relativePath configuration in all pom modules 2020-06-07 12:36:58 +02:00
e4368c9f7c [java] UselessOverridingMethod false negative with already public methods 2020-06-03 19:23:22 +02:00
b21f3efcfd [java] UseProperClassLoader can not detect the case with method call on intermediate variable
Fixes #2544
2020-05-30 11:23:23 +02:00
cae1316472 [java] UseDiamondOperator - add property java7compatibility
This property is disabled by default, so that the rule
suggests changes that work on java8+ only by default.

Enable the version dependent tests.
2020-05-30 10:38:09 +02:00
c2cea9d15b [java] UseDiamondOperator - support nested type arguments
Fixes #2545 partially
2020-05-30 10:23:52 +02:00
ab04bdacdd [maven-release-plugin] prepare for next development iteration 2020-05-24 17:34:34 +02:00
229cb2bdca [maven-release-plugin] prepare release pmd_releases/6.24.0 2020-05-24 17:34:25 +02:00
7feb805f96 [java] UnnecessaryCastRule: verify clone is not flagged 2020-05-23 18:41:37 +02:00
473a806cb7 [java] UnnecessaryCastRule: Avoid cast false-positives 2020-05-23 18:38:14 +02:00
a3a292d591 Remove unnecessary source-type tags in rule tests
source-type is actually only needed if
* the language supports more than one version
* the parser behaves differently with different versions
  (this has to do with compatibility, e.g. assert/enum keywords
  in java)
* the test needs a newer version than the default version
  (e.g. to test new language features)
* the test needs an older version than the default version
  (e.g. the rule has a maximumLanguageVersion specified)
* the rule behaves differently for different versions
  (e.g. BigIntegerInstantiation)
2020-05-23 14:16:13 +02:00