57 Commits

Author SHA1 Message Date
Clément Fournier
6f4123afcc Annotated overriding #getDumpFacade as Deprecated 2019-05-02 16:22:04 +02:00
Andreas Dangel
1c9a73426c deprecate: DumpFacade will be removed in PMD 7
Refs #1801
2019-05-01 11:38:35 +02:00
Clément Fournier
b62b216b29 Merge branch 'pr-1399' 2018-10-27 22:55:10 +02:00
Clément Fournier
39f87ca5f3 Update schema location in rulesets 2018-10-27 21:02:16 +02:00
Andreas Dangel
1d48c49c81 Merge branch 'pr-1401' 2018-10-26 18:29:06 +02:00
Andreas Dangel
a5a189b2f3 [jsp] JspTokenManager has a problem about jsp scriptlet
Refs #1402

Add unit test
2018-10-25 20:02:22 +02:00
Will Herrmann
377baf7caf Replacing IOUtils.closeQuietly(foo) with try-with-resources statements 2018-10-19 14:23:51 -05:00
Andreas Dangel
6d00e74142 Use new base class PmdRuleTst for rule tests 2018-10-05 20:33:38 +02:00
Andreas Dangel
52be023f80 Simplify rule tests, directly inherit from SimpleAggregatorTst
for apex, javascript, jsp, plsql, visualforce, vm, xml
2018-09-09 13:10:44 +02:00
Andreas Dangel
8b4cdb83da [jsp] Split the rule tests 2018-09-09 12:01:36 +02:00
Andreas Dangel
a2d0b41388 [jsp] add test for jspx extension
Refs #1276
2018-08-06 09:44:06 +02:00
Andreas Dangel
2d87f575d3 Merge branch 'pr-1275' 2018-08-06 09:41:42 +02:00
jordillachmrf
57cba95386 #1276 add support for jspf and tag extensions 2018-08-01 17:22:43 +02:00
jordillachmrf
543aadad20 #1274 Support EL in tag attributes
Adding support to EL in tag attributes

<font size="2" ${something ? 'class=\"red\"' : ''}>
	<c:out value="some value" />
</font>
2018-08-01 16:27:40 +02:00
Andreas Dangel
5a7bbe19a2 dogfood: fix missing override
Note: the rule is disabled for pmd-xml, refs #1074
2018-06-16 17:48:36 +02:00
Andreas Dangel
8bd1e3b486 Fix PMD dogfood: UncommentedEmptyMethodBody, SimplifyBooleanReturns,
UnnecessaryLocalBeforeReturn, OptimizableToArrayCall,
ClassWithOnlyPrivateConstructorsShouldBeFinal,
UseLocaleWithCaseConversions, NonStaticInitializer, UseCollectionIsEmpty
2018-03-10 12:04:50 +01:00
Clément Fournier
b1c5e3dfc0 Revert making AbstractVFNode and AbstractJspNode abstract
Revert me for 7.0.0

see #881, #879
2018-01-25 12:14:22 +01:00
Clément Fournier
6a3b332aee Abstract toString into AbstractNode, deprecate the implementation
Log that the default implementation will be removed
2018-01-25 03:02:44 +01:00
Clément Fournier
3c0bb45a60 Add getXPathNodeName to the Node interface
A default implementation is available in AbstractNode
to preserve compatibility with the previous way, which
used Object.toString.

Fixes #569
2018-01-24 19:22:36 +01:00
Andreas Dangel
d6a9be55a8 Unify rule category names 2017-12-15 11:22:33 +01:00
Andreas Dangel
6bba28acbe Add categories.properties files 2017-11-07 22:23:17 +01:00
Andreas Dangel
15526591d4 [jsp] Move rules and tests to new packages 2017-11-03 15:31:00 +01:00
Andreas Dangel
f05c865a24 [jsp] Reorganize rules into categories 2017-11-03 15:20:42 +01:00
gonzalo
91b8a22b42 Update GenericToken specialToken method to obtain only comment tokens 2017-10-28 14:42:44 -03:00
gonzalo
e8fdbdbca4 Update GenericToken interface to expose directly region methods 2017-10-28 14:42:44 -03:00
gonzalo
26461e59c1 Simplify method name in GenericToken && improve ant task replacetoken 2017-10-28 14:42:44 -03:00
gonzalo
95835b8134 Update getter in GenericToken 2017-10-28 14:42:44 -03:00
gonzalo
020abafeab Change ant tasks over (JSP) Token class 2017-10-28 14:42:44 -03:00
Andreas Dangel
c903294c61 Apply schema for jsp rules tests 2017-09-11 21:56:05 +02:00
Andreas Dangel
69267eebdd [doc] [jsp] Adjust externalInfoUrl properties to new site - Part 7
Note: I also took the chance to fix tab damage
2017-08-15 14:31:03 +02:00
Andreas Dangel
3d9511a0e5 [doc] Remove old maven site 2017-08-15 14:31:03 +02:00
Juan Martín Sotuyo Dodero
e1f33504b9 [jsp] Update grammar to accept boolean attributes 2017-06-21 16:45:32 -03:00
Oowekyala
3b7c956596 Fixed unrecognised headers 2017-05-06 02:56:10 +02:00
Andreas Dangel
9e77578408 Merge branch 'pmd/5.5.x' 2017-02-25 20:59:21 +01:00
Andreas Dangel
e5a126c9d6 Merge branch 'pmd/5.4.x' into pmd/5.5.x 2017-02-25 20:31:17 +01:00
Andreas Dangel
d5d485f47a Fix javadoc. Since jdk8u121 no <script> tags are allowed by default.
See Release Notes of jdk8u121:
> tools/javadoc(tool)
> New --allow-script-in-comments option for javadoc
> The javadoc tool will now reject any occurrences of JavaScript code in
> the javadoc documentation comments and command-line options, unless the
> command-line option, --allow-script-in-comments is specified.
>
> With the --allow-script-in-comments option, the javadoc tool will
> preserve JavaScript code in documentation comments and command-line
> options. An error will be given by the javadoc tool if JavaScript
> code is found and the command-line option is not set.
> JDK-8138725 (not public)
2017-02-25 09:59:16 +01:00
Andreas Dangel
d92688a07d Introduce end-of-line normalization
References pmd/build-tools#2
2017-02-02 20:52:08 +01:00
Andreas Dangel
e1d12dd4f8 Further Javadoc doclint fixes
References #1516 [build] doclint error during build
2017-01-07 17:05:03 +01:00
Andreas Dangel
2dfd580e93 [jsp] Javadoc doclint fixes
References #1516 [build] doclint error during build
2017-01-05 22:01:17 +01:00
Andreas Dangel
544d22f9b8 Merge branch 'checksum-aware' of https://github.com/Monits/pmd into pr-145 2016-12-23 18:21:50 +01:00
Andreas Dangel
d2bc0f3739 Checkstyle fixes 2016-12-03 11:31:01 +01:00
Andreas Dangel
e3fd103aeb pmd-jsp: checkstyle / formatting 2016-12-02 14:03:21 +01:00
Juan Martín Sotuyo Dodero
1d6c9327a0 Refactor RuleSet creation
- RuleSet is now immutable
 - RuleSets are created through a RuleSetBuilder
 - RuleSetBuilder is accessed solely from RuleSetFactory
 - RuleSetFactory can now either parse XMLs for rule set creation,
    or create single rule rulesets
2016-11-30 15:25:19 -03:00
Dionisio Cortes Fernandez
511c7778c5 Small code enhancements, basically reordering variable declarations, constructors and variable modifiers 2016-05-15 22:41:26 +02:00
Andreas Dangel
ac51f480a3 Merge branch 'pr-29' 2016-01-07 10:59:33 +01:00
Andreas Dangel
078db01307 Merge branch 'pr-29' into pmd/5.4.x 2016-01-07 10:58:53 +01:00
Jan van Nunen
a735fb057e Added support for files with UTF-8 BOM to JSP tokenizer. 2015-12-10 16:24:51 +01:00
Andreas Dangel
d563eb30fc Java 7 changes and some compiler warnings fixed 2015-11-29 19:55:13 +01:00
amitbitcse
1d190605e5 Added capability in Java and JSP parser for tracking tokens. It is often useful to keep track of each node's first and last token so that input can be easily reproduced again. Ref - https://javacc.java.net/doc/JJTree.html 2015-10-06 11:04:22 +05:30
Andreas Dangel
dd6affeb6e Use new pmd-build plugin, adjust some rule documentation for markdown changes 2015-03-15 14:59:55 +01:00