1005 Commits

Author SHA1 Message Date
Andreas Dangel
c8ffb63e40 Merge remote-tracking branch 'origin/master' into pmd/7.0.x 2020-04-04 18:36:27 +02:00
Andreas Dangel
a86e172b98 Merge branch 'pr-2395'
[apex] New Rule: Unused local variables #2395
2020-04-04 18:08:41 +02:00
Andreas Dangel
9db695eee2 [apex] Add additional test case for unused local var shadowing a field 2020-04-04 18:07:23 +02:00
Andreas Dangel
6196da44b0 Merge branch 'pr-2396'
[apex] New rule: field declarations should be at start #2396
2020-04-04 17:44:07 +02:00
Andreas Dangel
f1759c68c6 [apex] Move new rule def up in codestyle.xml 2020-04-04 17:38:13 +02:00
Kieran Black
746797e805 added tests for line breaks 2020-04-03 15:43:56 -04:00
Kieran Black
d09d4de308 fixed WITH SECURITY_ENFORCED regex to recognise line break characters 2020-04-03 12:25:22 -04:00
Gwilym Kuiper
7b06d3001f Make UnusedLocalVariableRule a rule chain rule 2020-04-03 15:27:37 +01:00
Gwilym Kuiper
6a70bda5e6 Should be 6.23.0 for release 2020-04-03 15:19:12 +01:00
Gwilym Kuiper
e94db8bf22 Make rule a RuleChain 2020-04-03 15:18:22 +01:00
Gwilym Kuiper
58185fce2f Extract constant 2020-04-03 15:17:29 +01:00
Gwilym Kuiper
1331eec208 Make comment clearer 2020-04-03 15:17:01 +01:00
Gwilym Kuiper
4aae0e2ebf Fix checkstyle violations 2020-04-03 15:16:52 +01:00
Gwilym Kuiper
9e07836659 Correctly detect fields that appear after static initialization blocks 2020-04-03 15:10:30 +01:00
Gwilym Kuiper
292bcbbf04 Correctly detect that fields should go before block statements 2020-04-03 15:01:56 +01:00
Gwilym Kuiper
eeac579661 Correctly detect properties before fields 2020-04-03 13:58:49 +01:00
Gwilym Kuiper
5d1ffa5a55 Correctly detect fields after inner classes 2020-04-03 13:57:34 +01:00
Gwilym Kuiper
1359c88e90 Also produce errors in inner classes 2020-04-03 13:48:31 +01:00
Gwilym Kuiper
eb8e7eabd8 Fix field declaration location rule around nested classes 2020-04-03 13:45:34 +01:00
Gwilym Kuiper
9c13702e39 Massively simplify rule with custom comparator 2020-04-03 13:38:40 +01:00
Gwilym Kuiper
41f6a595a9 Include variable name in violation message 2020-04-01 11:58:32 +01:00
Gwilym Kuiper
504cf440a3 Inculde field name in violation message 2020-04-01 11:55:50 +01:00
Gwilym Kuiper
3f0dc27a4a Add tests for apex field declarations should be at start 2020-04-01 11:47:32 +01:00
Gwilym Kuiper
1d62a1f984 Add rule definition in codestyle.xml 2020-04-01 11:28:14 +01:00
Gwilym Kuiper
8acb63870c Add basic implmentation of FieldDeclarationsShouldBeAtStart for apex 2020-04-01 11:24:34 +01:00
Gwilym Kuiper
abbe46c7ba Add another test for variable usage in blocks 2020-04-01 09:28:18 +01:00
Gwilym Kuiper
705fa2563a Fixup checkstyle issues 2020-04-01 09:28:11 +01:00
Gwilym Kuiper
80c26bf537 Add tests and fix up issues found while writing them 2020-04-01 09:15:04 +01:00
Gwilym Kuiper
29cef7f23d Add rule to bestpractices.xml 2020-04-01 09:15:01 +01:00
Gwilym Kuiper
d95763c504 Basic implementation of detecting apex unused local variables 2020-03-30 10:54:58 +01:00
Clément Fournier
01c2389f58 Merge branch 'master' into xpath-update-rules 2020-03-28 17:32:22 +01:00
Clément Fournier
571a4167b8 Merge branch 'master' into 7.0.x 2020-03-28 15:14:09 +01:00
Gwilym Kuiper
954f6b09d5 int -> Integer in apex/errorprone.xml 2020-03-27 16:50:53 +00:00
Gwilym Kuiper
315afeae90 Fixup whitespace 2020-03-27 16:50:15 +00:00
Gwilym Kuiper
25139da564 int -> Integer and float -> Double 2020-03-27 16:48:59 +00:00
Gwilym Kuiper
0bd1523172 Fix typo in method 2020-03-27 16:47:51 +00:00
Gwilym Kuiper
4139fd4dd2 Integer rather than int 2020-03-27 16:47:18 +00:00
Gwilym Kuiper
1e286ed281 Fixup indentation in apex/bestpractices.xml 2020-03-27 16:46:10 +00:00
Gwilym Kuiper
22c66fde27 Add returns to setPhoneNumberIfNotExisting in documentation 2020-03-27 16:44:36 +00:00
Clément Fournier
3cf06909fb Merge branch 'master' into 7.0.x 2020-03-21 20:05:16 +01:00
Clément Fournier
0280668a51 [apex] Replace usages of AbstractApexNode in rules by ApexNode 2020-03-21 20:04:38 +01:00
Clément Fournier
0d65c2e6e6 Add relevant property tag 2020-03-20 18:47:40 +01:00
Clément Fournier
eaceefc39e Update XPath rules to 2.0 2020-03-20 18:47:40 +01:00
Clément Fournier
e9b65823bf Cleanup TokenMgrError 2020-03-20 18:07:56 +01:00
Clément Fournier
3cdcba2299 Fix file name for token manager error 2020-03-20 18:07:56 +01:00
Andreas Dangel
235e5f4160 Fix build (Apex Metrics) 2020-03-19 12:37:53 +01:00
Clément Fournier
fd87420953 Merge branch '7.0.x' into simplify-metrics-framework-on-7 2020-03-18 00:34:38 +01:00
Clément Fournier
903383d7cf Merge branch 'master' into 7.0.x 2020-03-17 15:14:46 +01:00
Andreas Dangel
5ff0814120 Merge branch 'pr-2312'
[apex] Update ApexCRUDViolation Rule
2020-03-14 18:27:19 +01:00
Andreas Dangel
383713fdbd [apex] Small refactorings in ApexCRUDViolationRule
To avoid some deprecations
2020-03-14 18:16:52 +01:00