Commit Graph
2012 Commits
Author SHA1 Message Date
Juan Martín Sotuyo Dodero dd6ef52289 Remove usage of deprecated methods 2018-05-26 18:00:48 -03:00
Andreas Dangel ba55164b2f Merge branch 'pr-1141' 2018-05-26 22:37:04 +02:00
Clément Fournier 929c2dfba2 Corrections for PR #1141 2018-05-26 21:54:39 +02:00
Juan Martín Sotuyo Dodero 0e44b279f7 Fix AvoidThrowingRawExceptionTypes 2018-05-26 14:48:26 -03:00
Juan Martín Sotuyo Dodero 7572a49d35 [java] Deprecate the old typeof function
- Have new functions typeIs() and typeIsExactly() with simpler syntaxes
 - Nag about the deprecated usage of the old method
 - Replace all internal usages with the new one
 - Have the functions use the TypeHelper to avoid multiple separate
implementations of the same behavior
 - Tidy up a little the TypeHelper
2018-05-26 06:01:56 -03:00
Juan Martín Sotuyo Dodero 56e4605eae Merge branch 'pr-1134' 2018-05-24 11:24:59 -03:00
Clément Fournier cf0eb9a9bd Checkstyle 2018-05-24 03:58:29 +02:00
Clément Fournier 463c1c03cd Fix #1114 - Star import overwritten by explicit import is not correctly handled 2018-05-24 01:33:01 +02:00
Clément Fournier fbd58c14d5 Make tests more readable 2018-05-24 01:25:34 +02:00
Clément Fournier f463038327 Cleanup UnnecessaryFQN 2018-05-24 01:25:31 +02:00
Clément Fournier 3e159310d2 Document ASTImportDeclaration 2018-05-24 01:10:20 +02:00
Clément Fournier c80cfd6113 Corrections for PR #1134 2018-05-23 21:25:22 +02:00
Clément Fournier 0fa74aacfb Improve test readability 2018-05-23 19:41:04 +02:00
Clément Fournier 9cc8068881 Whitelist lambda parameters 2018-05-23 19:38:06 +02:00
Clément Fournier 5ecf60b73c Refactor ShortVariable
No change in functionality, but less wasted tests
2018-05-23 19:32:22 +02:00
Clément Fournier 89bc6c94c8 Whitelist main classes with private static fields 2018-05-23 17:13:44 +02:00
Clément Fournier 8e1ff80573 Allow Helper as a suffix 2018-05-23 17:06:58 +02:00
Clément Fournier f5a0750557 Ignore main method when detecting utility classes 2018-05-22 16:17:10 +02:00
Clément Fournier 1140c1ec56 Allow Utils as suffix 2018-05-22 16:06:19 +02:00
Clément FournierandGitHub fe8752bf67 update tests 2018-05-22 15:49:43 +02:00
Clément FournierandGitHub ce0f151c66 Update codestyle.xml 2018-05-22 15:46:32 +02:00
Clément FournierandGitHub 56339f6793 Update rule desc 2018-05-22 15:45:34 +02:00
Clément FournierandGitHub 9e7aceed56 Allow numbers in utility class names by default
Refs #1065
2018-05-22 15:41:26 +02:00
Juan Martín Sotuyo Dodero c3dcb70e9c Further improvements 2018-05-22 01:45:13 -03:00
Karl-Philipp Richter 16ad6904bd Adjust InefficientEmptyStringCheck documentation
InefficientEmptyStringCheckRule.java and the corresponding section
both contain information which the other doesn't. The class Javadoc and
the description section in performance.xml has thus been adjusted.
2018-05-22 06:40:25 +02:00
Juan Martín Sotuyo Dodero aa2f8b70f1 [java] improve how we deal with broken classes 2018-05-22 01:34:37 -03:00
Juan Martín Sotuyo Dodero c417d68191 Merge branch 'pr-1126' 2018-05-21 17:00:10 -03:00
Andreas Dangel 4138cdc018 Merge branch 'pr-966' 2018-05-21 14:57:34 +02:00
Andreas Dangel 43f9237e63 Update release notes, fixes #955, refs #966 2018-05-21 14:55:16 +02:00
Andreas Dangel af7a8b3eb6 Merge branch 'pr-1123' 2018-05-21 13:45:20 +02:00
Andreas Dangel c95428d27a Merge branch 'pr-1046' 2018-05-21 13:12:24 +02:00
Andreas Dangel b3460f6951 whitespaces, javadoc 2018-05-21 12:53:51 +02:00
Andreas Dangel f14fbd02b5 Rework InsecureCryptoIvRule to use RuleChain on AllocationExpression
No need for Util. Use Symbol Table instead.
2018-05-21 12:46:29 +02:00
Andreas Dangel e9f6668c9b Rework HardCodedCryptoKeyRule to use RuleChain on AllocationExpression and symbol table 2018-05-21 12:40:34 +02:00
Andreas Dangel af250c3503 whitespaces 2018-05-21 11:56:23 +02:00
Andreas Dangel ac7b94aaa2 The rule is new with 6.4.0. Sort alphabetically 2018-05-21 11:52:11 +02:00
Andreas Dangel 4d31d1fb04 whitespaces 2018-05-21 11:51:24 +02:00
Andreas Dangel 1ee12a4792 Merge branch 'pr-1080'
Fixes #1018
2018-05-21 11:39:21 +02:00
Andreas Dangel a305f78e26 [java] Reuse isTypeInferred of ASTTYpe for variables 2018-05-21 11:17:25 +02:00
Andreas Dangel 8f4b2647c4 Merge branch 'master' into java10-basic-support 2018-05-21 10:07:05 +02:00
Karl-Philipp Richter 1f18181ef5 Improve implementation hint in InefficientEmptyStringCheck
The alternative implementation mentions iterating over the string and
checking for whitespace which is pretty clear, however, showing the
implementation doesn't hurt, nor does the hint for Apache
commons-lang's StringUtils.isBlank which does exactly that.

The if statement in the demonstration of inefficient code can lead to
confusion because users _might_ think that the check is only
inefficient inside an if statement although it's clear from the
description that it's not.
2018-05-21 06:15:17 +02:00
Juan Martín Sotuyo Dodero 625431f8b1 Remove unnecessary log 2018-05-20 20:33:26 -03:00
Juan Martín Sotuyo Dodero 998dd2d3ee Merge branch 'pr-1111' 2018-05-20 02:48:22 -03:00
Juan Martín Sotuyo Dodero 3bbebdcabd Fix checkstyle 2018-05-20 02:32:10 -03:00
Juan Martín Sotuyo Dodero 7a23ca638a Avoid NPE
- Fix a bunch of errors in message building along the way
2018-05-20 02:25:58 -03:00
Clément Fournier a4ea6f8fb5 Multiple improvements and bug corrections in VariableDeclaratorId 2018-05-20 01:09:24 +02:00
Clément Fournier 07b8c4f9b2 Merge branch 'pr-1068' 2018-05-20 01:09:10 +02:00
Andreas Dangel 25f51db8d7 [java] Parser Error / Nullpointer when analyzing local generic class 2018-05-19 14:33:30 +02:00
Andreas Dangel bdb48a963f whitespace 2018-05-19 14:09:32 +02:00
Andreas Dangel f5f07220ad [java] Fix NPE in InsecureCryptoIvRule 2018-05-19 14:06:02 +02:00