750 Commits

Author SHA1 Message Date
XenoAmess
244a39db0f fix typos. 2020-08-27 11:47:11 +08:00
Andreas Dangel
0b92a768da [apex] Deprecate ApexParserVisitorReducedAdapter
See also #2661
2020-08-22 18:30:42 +02:00
Andreas Dangel
89140d86ce Merge branch 'master' into pr-2656 2020-08-20 09:47:16 +02:00
Andreas Dangel
40f954f81a Merge branch 'pr-2675'
[core] Deprecate parser options #2675
2020-08-02 16:53:24 +02:00
Andreas Dangel
eb683569af Merge branch 'pr-2617'
[core] Deprecate missing language attribute on rule definition #2617
2020-07-30 10:19:03 +02:00
Clément Fournier
25d59beb37 Revert changes to apex rules
Someone may be using those properties, this would
be a breaking change
2020-07-28 14:26:06 +02:00
Clément Fournier
190addc1a9 Replace usages of ApexXPathRule 2020-07-28 14:26:05 +02:00
Clément Fournier
9a37ab4962 Deprecate parser options in some places
There is no way to introduce the new API
in a binary compatible change, so LVHandler::getDefaultParserOptions,
LVHandler::getParser and Parser::parse
will remain like this until 7.0 and be
broken.
2020-07-28 14:25:51 +02:00
Andreas Dangel
fe82f6a448 Dogfood - update PMD to 6.26.0, update build-tools 2020-07-25 15:27:24 +02:00
Andreas Dangel
8a6975f8ec [apex] Improve AST for try-catch-finally statements 2020-07-24 16:55:48 +02:00
Clément Fournier
6f9aedfaeb Merge branch 'master' into issue-2598 2020-07-23 15:51:13 +02:00
Maikel Steneker
6fb5ac59b9 Ensure CPD uses tab width of 1 for tabs consistently
The columns that are reported by CPD were inconsistent across languages
before. A language like Java (using a JavaCC-based tokenizer) would use
a width of 8 for tabs, whereas a language like C# (using an Antlr-based
tokenizer) would use 1 instead.

This includes unit tests for most languages to ensure a tab character is
counted as 1. The configuration for JavaCC has been adjusted to respect
this as well.
2020-07-20 10:42:21 +02:00
Andreas Dangel
7b3d31246e Merge branch 'master' into pr-2624 2020-07-17 15:16:24 +02:00
Andreas Dangel
7ae424a35b Add deprecation javadocs 2020-07-17 14:43:43 +02:00
Andreas Dangel
e24a26e211 Merge branch 'pr-2629'
[all] Dependencies cleanup #2629
2020-07-17 12:07:03 +02:00
Andreas Dangel
05933c646e [apex] AvoidSoqlInLoops false positive for SOQL with in For-Loop
Fixes #2598
2020-07-16 20:13:53 +02:00
Andreas Dangel
9168a76e84 Merge branch 'pr-2610'
[apex] Support top-level enums in rules #2610
2020-07-16 17:47:48 +02:00
Clément Fournier
7ccec3bcef Merge branch 'master' into deprecate-set-lang-in-java 2020-07-06 14:02:46 +02:00
Clément Fournier
8add323403 Fix other offenders 2020-07-06 14:02:21 +02:00
Andreas Dangel
1fb085f7ab Use StringUtils.equalsIgnoreCase 2020-07-03 11:58:38 +02:00
Andreas Dangel
147f1ac053 [apex] UnusedLocalVariable - false positive on case insensitivity allowed in Apex
Fixes #2626
2020-07-02 22:39:17 +02:00
Andreas Dangel
370c0b0b6d Remove unused dependency, explicitly declare used dependencies 2020-07-02 15:12:31 +02:00
Clément Fournier
49635c2a66 Deprecate Rulechain visitors 2020-07-01 11:27:38 +02:00
Clément Fournier
659066ee02 Deprecate BaseLanguageModule constructor 2020-07-01 11:27:38 +02:00
Clément Fournier
d7f96e08d9 Uniformize apply across languages 2020-07-01 11:27:38 +02:00
Clément Fournier
3dd49db9cc Reorder attributes
(name first)
2020-06-27 18:08:30 +02:00
Clément Fournier
50cd4668a8 Fix apex rules 2020-06-27 17:59:20 +02:00
Andreas Dangel
acbbbee685 Merge branch 'pr-2608'
[apex][plsql][java] Deprecate base rule classes #2608
2020-06-26 18:01:30 +02:00
Andreas Dangel
9810cdd654 Fix StdCyclomaticComplexity: enums should not be considered
In Apex enums, there can't be any custom methods.
2020-06-20 19:54:54 +02:00
Andreas Dangel
5b0c20a93f [apex] Support top-level enums in rules 2020-06-20 19:49:46 +02:00
Andreas Dangel
23c08b52b2 [apex] Internalize ApexParser and ApexHandler 2020-06-20 19:28:48 +02:00
Andreas Dangel
a19e50a804 [apex] Deprecate overly specific base rule classes
Refs #971
2020-06-20 12:01:38 +02:00
Andreas Dangel
534bfe3c55 Merge branch 'pr-2572'
[cpd] Allow CPD tests based on a text dump #2572
2020-06-18 20:09:58 +02:00
Andreas Dangel
45d3c07201 Merge branch 'pr-2556'
[apex] Exception applying rule UnusedLocalVariable on trigger #2556
2020-06-18 15:01:25 +02:00
Clément Fournier
2592c56229 Make apex end column inclusive 2020-06-17 20:03:16 +02:00
Clément Fournier
8e47ed3188 Merge branch 'master' into cpd-text-comp 2020-06-17 20:00:50 +02:00
Clément Fournier
d631b79307 Deprecate stuff for #2491 2020-06-14 21:36:33 +02:00
Clément Fournier
fb0819f319 Convert Apex tests 2020-06-14 00:29:58 +02:00
Andreas Dangel
c680b260b9 [apex] Exception applying rule UnusedLocalVariable on trigger
Fixes #2554
2020-05-30 11:08:44 +02:00
Andreas Dangel
e1cd3b4c8d Merge branch 'pr-2487'
[all] Cleanup rule test xml #2487
2020-05-22 19:41:01 +02:00
Andreas Dangel
6049126228 Merge branch 'pr-2465'
[dependencies] Upgrade hamcrest, mockito and JUnit #2465
2020-05-22 11:46:04 +02:00
Andreas Dangel
f930491538 [apex] Cleanup rule test xml files
Avoid unnecessary CDATA for description
Use 4 space indentation instead of tabs
Remove trailing whitespace
End file with a newline
2020-05-16 18:55:58 +02:00
Gwilym Kuiper
3571608234 Handle chained method calls.
This wasn't working because they had a null image. Turns out that nodes
have a method called `hasImageEqualTo` which handles the null case for
us.
2020-05-06 11:26:14 +01:00
Gwilym Kuiper
acbf53e8ab Variable is used if method is called on it 2020-05-06 11:11:13 +01:00
Artem Krosheninnikov
3fba3f6217 Update hamcrest to 2.2, Junit to 4.13, mockito to 2.28.2 2020-05-04 23:00:28 +03:00
Andreas Dangel
4192f04c1d [apex] clarify AvoidGlobalModifier, refs #2298 2020-04-27 19:41:33 +02:00
Andreas Dangel
96d542c00d Prepare pmd release 6.23.0 2020-04-24 10:42:57 +02:00
Clément Fournier
96e9127eae Cleanup TooManyFieldsRule
It used a descendant check unnecessarily,
can use the rulechain now
2020-04-23 19:33:55 +02:00
Clément Fournier
f7fc5c5687 Merge branch 'master' into apex-deprecate-ast 2020-04-20 10:56:40 +02:00
Andreas Dangel
56ab75bfd1 [apex] Refactor usage of internal getNode()
This exposes more information directly on PMD's AST node
rather then giving away the inner jorje node.
2020-04-17 20:10:37 +02:00