Commit Graph
2932 Commits
Author SHA1 Message Date
Mykhailo Palahuta 782cb9d262 [java] NullPointerException in rule ProperCloneImplementation 2020-07-14 14:00:42 +03:00
Andreas Dangel f4bf540bc3 [java] Remove usages of DummyJavaNode 2020-07-02 09:48:23 +02:00
Andreas Dangel 95d8e80c1b [maven-release-plugin] prepare for next development iteration 2020-06-27 11:31:27 +02:00
Andreas Dangel a219b2e1be [maven-release-plugin] prepare release pmd_releases/6.25.0 2020-06-27 11:31:16 +02:00
Andreas Dangel acbbbee685 Merge branch 'pr-2608'
[apex][plsql][java] Deprecate base rule classes #2608
2020-06-26 18:01:30 +02:00
Andreas Dangel 9508a92c2b [java] Change rule priority of new rules to 3 2020-06-22 19:34:58 +02:00
Andreas Dangel 6fded20178 Merge branch 'master' into perf-UseIOStreamsWithApacheCommonsFileItem 2020-06-22 19:32:29 +02:00
Clément Fournier ee8d77bf09 Merge branch 'master' into perf-UseStringBufferForStringAppends 2020-06-21 17:58:06 +02:00
Clément Fournier 75146a06bf Merge branch 'master' into perf-InefficientStringBuffering 2020-06-21 17:50:29 +02:00
Clément Fournier ae2b481aa2 Merge branch 'master' into perf-AvoidCalendarDateCreation 2020-06-21 17:42:25 +02:00
Andreas Dangel f6644c0eb0 [java] Deprecate overly specific base rule classes
Fixes #971
2020-06-20 11:54:55 +02:00
Andreas Dangel 26cfd347fd Merge branch 'master' into perf-UseStringBufferForStringAppends 2020-06-20 11:29:11 +02:00
Andreas Dangel 4b494899bf [java] UseStringBufferForStringAppends: fix false positives
Fix false positives with field assignment and shadowing parameters
2020-06-20 10:50:31 +02:00
Andreas Dangel 534bfe3c55 Merge branch 'pr-2572'
[cpd] Allow CPD tests based on a text dump #2572
2020-06-18 20:09:58 +02:00
Andreas Dangel 0f06f5132a Merge branch 'pr-2593'
[java] NPathComplexity should mention the expected NPath complexity #2593
2020-06-18 15:09:35 +02:00
Andreas Dangel fd63c97d33 [java] NPathComplexityRule: Use String.valueOf consistently 2020-06-18 15:07:00 +02:00
Andreas Dangel ca44ca3964 Merge branch 'pr-2557'
[java] UseProperClassLoader can not detect the case with method call … #2557
2020-06-18 15:03:43 +02:00
Andreas Dangel 5579ddc21a [java] UseStringBufferForStringAppends: add good example 2020-06-18 14:48:34 +02:00
Andreas Dangel dda76be8ae [java] UseStringBufferForStringAppends: fix false negative with fields
And also fix false positive when concatenation is local to each
for-loop iteration.

Test cases originally from #1932

Author: jborgers <jborgers@jpinpoint.com>
2020-06-18 14:37:47 +02:00
Andreas Dangel f1d46714a5 [java] InefficientStringBuffering: fix another ternary false positive 2020-06-18 12:10:36 +02:00
Andreas Dangel 4feb44b373 [java] AvoidCalendarDateCreation: fix more false positives 2020-06-18 11:58:37 +02:00
Andreas Dangel 93930c40fb Merge branch 'master' into perf-AvoidCalendarDateCreation 2020-06-18 11:13:55 +02:00
Andreas Dangel f1400e37f7 [java] AvoidCalendarDateCreation - fix false positives 2020-06-18 11:11:15 +02:00
Andreas Dangel 1e986ed793 [java] Fix false positive for AppendCharacterWithChar and InefficientStringBuffering
Also make both rules use the rule chain.
2020-06-18 10:28:12 +02:00
Clément Fournier 8e47ed3188 Merge branch 'master' into cpd-text-comp 2020-06-17 20:00:50 +02:00
Andreas Dangel ca0f6535a4 Merge branch 'pr-2573'
[java] DefaultPackage: Allow package default JUnit 5 Test methods #2573
2020-06-15 20:26:04 +02:00
Clément Fournier 62c5ebe482 Merge branch 'issue-2545' 2020-06-15 17:46:11 +02:00
Clément Fournier 527b75ceb4 Merge branch 'master' into issue-2545 2020-06-15 17:42:27 +02:00
Clément Fournier 2b19527649 Change property name to be camelCase 2020-06-15 17:41:30 +02:00
Artem Krosheninnikov 5706dbc4b8 fix issue #2570, add information about expected NPath complexity to rule violation message 2020-06-14 22:42:51 +03:00
Andreas Dangel b8e9ff19b2 [java] Fix rules InefficientStringBuffering and refactor existing rules
Rules affected additionally: AppendCharacterWithChar,
ConsecutiveLiteralAppends, InsufficientStringBufferDeclaration

Deprecate InefficientStringBuffering::isInStringBufferOperation
2020-06-14 12:59:06 +02:00
Craig Andrews 18191a1814 [java] Allow package default JUnit 5 Test methods
JUnit 5 allows test methods to be default / package scoped.
2020-06-13 23:19:51 -04:00
Clément Fournier 9fc15f0b91 Remove test
This is already tested in SourceCodeTest in pmd-core
2020-06-13 23:34:00 +02:00
Clément Fournier da371182aa Convert Go tests 2020-06-13 22:00:58 +02:00
Clément Fournier 0d23c04c1b Check-in reference files 2020-06-13 21:47:49 +02:00
Clément Fournier 6ff4a1c4d4 Rename test file 2020-06-13 21:37:47 +02:00
Clément Fournier 344d02600c Convert java tests 2020-06-13 21:09:31 +02:00
Andreas Dangel 67cca2a123 [java] Add test cases for InefficientStringBuffering
Originally from #1932

Author: jborgers <jborgers@jpinpoint.com>
2020-06-13 20:00:51 +02:00
Andreas Dangel 488f38871e [doc] Update release notes, refs #1932 2020-06-13 19:49:12 +02:00
Andreas Dangel 9dea892121 [java] Update rule AvoidCalendarDateCreation to use XPath 2.0 2020-06-13 19:48:50 +02:00
jborgers ca6a1b6b1f Add performance rule AvoidCalendarDateCreation
Including unit tests and examples. Originating from github.com/jborgers/PMD-jPinpoint-rules.
Links to more doc later.
2020-06-13 19:39:32 +02:00
Andreas Dangel b8e1ec95e1 [doc] Update release notes, refs #1932 2020-06-13 18:59:23 +02:00
Andreas Dangel 8132a4af8d [java] UseIOStreamsWithApacheCommonsFileItem - Upgrade to XPath 2.0 2020-06-13 18:51:30 +02:00
Andreas Dangel 0d4ed1a2ff [java] UseIOStreamsWithApacheCommonsFileItem - improve description 2020-06-13 18:47:25 +02:00
Andreas Dangel 48583f9f58 [java] Rename new rule to UseIOStreamsWithApacheCommonsFileItem 2020-06-13 18:44:07 +02:00
jborgers bb3223d92c Add performance rule AvoidApacheCommonsFileItemNonStreaming
Including unit tests and examples. Originating from github.com/jborgers/PMD-jPinpoint-rules.
Links to more doc later.
2020-06-13 18:36:52 +02:00
Andreas Dangel bff3bcb487 Merge branch 'pr-2349'
[java] Optimize UnusedPrivateMethodRule #2349
2020-06-13 18:14:53 +02:00
Andreas Dangel ae5fec78cd [java] UnusedPrivateMethod - improve javadoc 2020-06-13 18:12:20 +02:00
Clément Fournier 30f3d11795 Fix java test 2020-06-13 18:00:57 +02:00
Clément Fournier 6c51cec444 Merge branch 'master' into uselessoverridingmethod-false-negative 2020-06-12 17:36:38 +02:00