Juan Martín Sotuyo Dodero
be83d154d0
Don't assume the List supports random access
2016-10-13 17:17:43 -03:00
Juan Martín Sotuyo Dodero
a046b8f93d
Simplify lambda parsing
...
- Handle less scenarios
- Have scenarios be defined more broadly (ie: allow more than 3 params)
- This improves parsing performance by roughly ~10%
2016-10-13 14:53:51 -03:00
Juan Martín Sotuyo Dodero
61b55bd7e5
Minor improvements
...
- Use `Deque` and `ArrayDeque` instead of `Stack`
- Use presized `ArrayList` instead of a dynamic `LinkedList` when possible
- Don't create empty `HashSet` when `Collections.emptySet()` suffices
- User `Collections.singletonList()` were apropriate
2016-10-13 01:53:47 -03:00
Juan Martín Sotuyo Dodero
fccd26b2d0
Dont use synchronized structures onnon-shared data
...
- AFAIK ScopeAndDeclarationFinder is only used as a local,
used as alocal by SymbolFacade, used as a local by SourceCodeProcessor.
Synchronizing is needless.
2016-10-11 17:48:39 -03:00
Andreas Dangel
b773da1441
Merge branch 'bug-1529'
2016-10-01 17:58:53 +02:00
Andreas Dangel
1b52e0192a
Merge branch 'bug-1529' into pmd/5.4.x
2016-10-01 17:54:11 +02:00
Andreas Dangel
8667aea076
Fixes #1529 [java] UnusedImports: The created rule violation has no class name
2016-10-01 17:45:47 +02:00
Andreas Dangel
f9deb34809
Merge branch 'bug-1522'
2016-09-25 18:42:51 +02:00
Andreas Dangel
354b9a9cbc
Merge branch 'bug-1522' into pmd/5.4.x
2016-09-25 18:37:38 +02:00
Andreas Dangel
db44bc4745
Fixes #1522 [java] CommentRequired: false positive
2016-09-25 18:32:26 +02:00
Andreas Dangel
522d0ea311
Verify #1519 [java] UselessParenthesis: False Positive: "Prohibits the use of useless parentheses" when more than one line
2016-09-02 18:22:43 +02:00
Juan Martín Sotuyo Dodero
579853385d
Keep constructor names under ignoreIdentifiers
...
- Unrelated classes that just happen to have matching constructor types
(maybe sibling classes extening the same base class, and simply
calling super on all constructors) should not be reported as copy-paste
- If you copied a whole class, CPD should still match it due to other
member methods / fields, only case it would no longer catch is that of
a class exclusively containing constructors, but that should probably be
a PMD rule, and not catched by CPD itself
2016-09-01 16:57:24 -03:00
Andreas Dangel
c8a9f43ee0
Refactor InvalidSlf4jMessageFormatRule
2016-08-07 11:59:36 +02:00
Andreas Dangel
cd9a8186db
reformat, whitespaces
2016-08-07 11:52:50 +02:00
Andreas Dangel
a74105faa4
Fixes #1500 [java] InvalidSlf4jMessageFormat: doesn't ignore exception param
2016-08-05 11:08:36 +02:00
Andreas Dangel
869ee8569e
verify #1505 [java] ConstantsInInterface false negative
2016-08-03 20:06:02 +02:00
Andreas Dangel
a6acf7ca81
Fixes #1509 [java] InvalidSlf4jMessageFormat NPE
2016-08-03 19:43:10 +02:00
Andreas Dangel
6746b7522c
[maven-release-plugin] prepare for next development iteration
2016-07-27 20:40:56 +02:00
Andreas Dangel
cc3ad9aeb7
[maven-release-plugin] prepare release pmd_releases/5.5.1
2016-07-27 20:40:56 +02:00
Andreas Dangel
20c4f168c1
Merge branch 'close-read-files' of https://github.com/wolfs/pmd into pr-104
2016-07-26 22:10:15 +02:00
Andreas Dangel
a491cef61c
Merge branch 'bug-1508'
2016-07-26 21:56:14 +02:00
Andreas Dangel
42a5c6a537
Merge branch 'bug-1508' into pmd/5.4.x
2016-07-26 21:42:55 +02:00
Andreas Dangel
88d1823c2e
Fixes #1508 [core] [java] PMD is leaking file handles
...
Fixes InputStreams and Readers
2016-07-25 21:25:34 +02:00
Stefan Wolf
9fe399f3b3
Close classes read by PMDASMClassLoader
...
When having a long running process like the Gradle daemon,
then not closing read resources makes it impossible to delete
files on Windows.
2016-07-25 13:20:56 +02:00
Andreas Dangel
1916bcfd00
Merge branch 'pr-103'
2016-07-07 22:44:15 +02:00
Andreas Dangel
9240f98cce
Merge branch 'pr-103' into pmd/5.4.x
2016-07-07 22:35:26 +02:00
Andreas Dangel
0660097db2
Add unit test for #1501 [java] CyclomaticComplexity rule causes OOM when class reporting is disabled
2016-07-07 22:27:16 +02:00
Frits Jalvingh
afc0f25795
Fix for 1501: CyclomaticComplexity rule causes OOM when class reporting is disabled
2016-07-07 22:26:27 +02:00
Andreas Dangel
4d52be5cf2
PMDASMClassloader: minor refactoring
2016-07-07 20:47:53 +02:00
Andreas Dangel
9823f17cf8
Merge branch 'master' of https://github.com/fjalvingh/pmd into pr-101
2016-07-07 20:32:53 +02:00
Frits Jalvingh
46ad3a4700
Improve multithreading performance: do not lock on classloader.
2016-06-25 17:59:42 +02:00
Andreas Dangel
ef2a97d267
[maven-release-plugin] prepare for next development iteration
2016-06-25 17:53:11 +02:00
Andreas Dangel
64d9ef96fc
[maven-release-plugin] prepare release pmd_releases/5.5.0
2016-06-25 17:53:10 +02:00
Andreas Dangel
9d6692976a
Merge branch 'ignore-method-name-on-override' of https://github.com/Monits/pmd into pr-97
2016-06-12 19:03:15 +02:00
Juan Martín Sotuyo Dodero
fda753813b
Don't report bad method names on @Override
2016-06-08 19:59:58 -03:00
Andreas Dangel
5c9a8eb895
Merge branch 'pmd/5.4.x'
2016-05-29 21:17:50 +02:00
Andreas Dangel
4512da8f3f
[maven-release-plugin] prepare for next development iteration
2016-05-29 20:04:35 +02:00
Andreas Dangel
5fa4b309ed
[maven-release-plugin] prepare release pmd_releases/5.4.2
2016-05-29 20:04:34 +02:00
Andreas Dangel
8b34b2ef23
Merge branch 'bug-1479'
2016-05-29 18:37:19 +02:00
Andreas Dangel
be1a996ba5
Merge branch 'bug-1479' into pmd/5.4.x
2016-05-29 18:31:09 +02:00
Andreas Dangel
04f16d7627
Fixes #1479 CloseResource false positive on Statement
2016-05-29 18:20:04 +02:00
Andreas Dangel
e834003e20
Merge branch 'bug-1480'
2016-05-28 16:46:04 +02:00
Andreas Dangel
8f4a262e8e
Merge branch 'bug-1480' into pmd/5.4.x
2016-05-28 16:40:27 +02:00
Andreas Dangel
6afe513225
Fixes #1480 false positive on public modifier used with inner interface in enum
2016-05-28 16:33:10 +02:00
Andreas Dangel
c89d041e5c
Merge branch 'constant-interface' of https://github.com/Monits/pmd into Monits-constant-interface
2016-05-21 12:07:12 +02:00
Andreas Dangel
38f9d4361b
Merge branch 'bug-1484'
2016-05-21 11:45:09 +02:00
Andreas Dangel
a4baf5c2a8
Merge branch 'bug-1484' into pmd/5.4.x
2016-05-21 11:38:18 +02:00
Andreas Dangel
0d20fe7e1c
Fixes #1484 UnusedLocalVariable - false positive - parenthesis
2016-05-21 11:37:10 +02:00
Juan Martín Sotuyo Dodero
007f9b3921
Change default to match Effective Java
2016-05-20 17:12:26 -03:00
Juan Martín Sotuyo Dodero
2ec75e7050
Add ConstantsInInterface rule. Effective Java, 19
2016-05-20 16:59:02 -03:00