3685 Commits

Author SHA1 Message Date
Tom Copeland
051cac848d import cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3747 51baf565-9d33-0410-a72c-fc3788e3496d
2005-08-03 19:36:56 +00:00
Tom Copeland
28a4daa7f5 rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3746 51baf565-9d33-0410-a72c-fc3788e3496d
2005-08-03 17:58:29 +00:00
Tom Copeland
ed443b74bf rls preps
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3745 51baf565-9d33-0410-a72c-fc3788e3496d
2005-08-03 17:57:20 +00:00
Tom Copeland
51dad5d374 tweak to reflect symbol table being run on all source files
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3744 51baf565-9d33-0410-a72c-fc3788e3496d
2005-08-03 14:27:28 +00:00
Tom Copeland
de70994675 Renamed BasicScopeCreationVisitor to ScopeAndDeclarationFinder, refactored away one of the symbol table passes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3743 51baf565-9d33-0410-a72c-fc3788e3496d
2005-08-03 14:14:56 +00:00
Tom Copeland
ce6d4a5859 Symbol table now picks up class declarations and puts them in the right places - either in SourceFileScope if it's a top level class or ClassScope if it's a nested class. Prior to this, class declarations were added to SourceFileScope even if they were nested.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3742 51baf565-9d33-0410-a72c-fc3788e3496d
2005-08-03 13:28:12 +00:00
Tom Copeland
af0f04df4e Odds and ends as I'm working on book content
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3741 51baf565-9d33-0410-a72c-fc3788e3496d
2005-08-02 20:04:12 +00:00
Tom Copeland
53828d069c Fixed bug 1244443 - EqualsNull now catches more cases.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3740 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-30 03:04:34 +00:00
Tom Copeland
18811d0e40 Fixed bug 1225492 - ConstructorCallsOverridableMethod now reports the correct method name. dvholten's examples in RFE 1235562 also helped with this a great deal.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3739 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-29 21:29:55 +00:00
Tom Copeland
a496e92142 Fixed bug 1244428 - MissingStaticMethodInNonInstantiatableClass no longer reports warnings for nested classes. Some inner class cases will be missed, but false positives will be eliminated as well.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3738 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-28 19:44:41 +00:00
Tom Copeland
4f4bee7f12 Implemented RFE 1246338 - CPD now handles SCCS directories and NTFS junction points.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3737 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-27 21:23:37 +00:00
Tom Copeland
ea199cffc4 OK, now it's fixed
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3736 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-27 13:20:24 +00:00
Tom Copeland
7db7cce97f Fixed bug 1232648 - MethodReturnsInternalArray no longer reports false positives on return statement expressions that involve method invocations on an internal array.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3735 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-26 21:50:40 +00:00
Tom Copeland
dcf2463c01 Partially fixed bug 1244428 - MissingStaticMethodInNonInstantiatableClass no longer reports multiple warnings for nested classes.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3734 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-26 13:45:53 +00:00
Tom Copeland
7788457771 Oops
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3733 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-26 13:32:00 +00:00
Tom Copeland
6f67090854 oops, forgot to commit this yesterday
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3732 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-26 13:23:16 +00:00
Tom Copeland
c6669ee1a5 Fixed bug 1242946 - ArrayIsStoredDirectly no longer reports false positives for equality expression comparisons. As a bonus, it's message now includes the variable name :-)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3731 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-26 13:22:28 +00:00
Tom Copeland
ab61a34ff9 Wouter Zelle's UselessOverridingMethod, thanks Wouter!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3730 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-26 00:56:13 +00:00
Tom Copeland
fc511ec111 Fixed a bug in ImportFromSamePackage; now it catches the case where a class has an on-demand import for the same package it is in.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3729 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-26 00:05:43 +00:00
Tom Copeland
dc453cf103 Fixed bug 1242544 - SimplifyConditional no longer flags null checks that precede an instanceof involving an array dereference.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3728 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-25 13:19:33 +00:00
Tom Copeland
2c4cc3303f Fixed bug 1242290 - The JDK 1.5 parser no longer chokes on nested enumerations with a constructor.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3727 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-24 01:01:42 +00:00
Radim Kubacki
c4e2af98f1 removing custom progress component, now it uses NetBeans Progress API
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3726 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-22 07:46:45 +00:00
Radim Kubacki
7d09ccd0f1 fixing dependencies after openide split
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3725 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-21 18:35:40 +00:00
Radim Kubacki
7ac9af9528 #61150: modified shortcut so it does not clash with find in project
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3724 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-21 18:33:34 +00:00
Radim Kubacki
aeef1a59db avoid warning in log about backward compatibility
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3723 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-21 18:31:48 +00:00
Radim Kubacki
77224e2191 enhanced to show markers in error stripe when continous scan is turned on (applies to dev builds of NB only
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3722 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-21 18:30:04 +00:00
Radim Kubacki
bceac8e5f4 fixing licenses
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3721 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-21 18:26:40 +00:00
Tom Copeland
4f3f9fdec3 More rule XML cleanups
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3720 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-21 18:17:46 +00:00
Tom Copeland
151b30380d Cleaning up format, some examples tweaks
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3719 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-21 13:32:52 +00:00
Tom Copeland
6bc7b525da package -> private
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3718 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-21 01:43:42 +00:00
Tom Copeland
408870d846 Wouter Zelle's new ProperLogger rule; thanks Wouter!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3717 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-20 13:40:24 +00:00
Tom Copeland
b238b27130 Nicer examples
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3716 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-20 11:53:58 +00:00
Tom Copeland
5c0cd05599 Implemented RFE 1097090 - The PMD Report object now contains the elapsed time for running PMD. This shows up in the XML report as an elapsedTime attribute in the pmd element in the format '2m 5s' or '1h 5h 35s' or '25s' .
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3715 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-19 22:20:08 +00:00
Tom Copeland
2efab44902 Implemented RFE 1097090 - The Report object now contains the elapsed time for running PMD. This shows up in the XML report as an elapsedMilliseconds attribute in the pmd element.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3714 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-19 21:40:58 +00:00
Tom Copeland
e1181c7a03 Applied patch 1228834 - XPath rules can now use properties to customize rules. Thanks to Wouter Zelle for another great piece of work!
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3713 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-19 18:57:41 +00:00
Tom Copeland
b9eaa4d2f6 Implemented RFE 787860 - UseSingleton now accounts for JUnit test suite declarations.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3712 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-18 17:37:32 +00:00
Tom Copeland
97ac55669e Improved warning message from UnusedPrivateMethod.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3711 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-18 14:53:00 +00:00
Tom Copeland
b321459515 Fixed bug 1240201 - The UnnecessaryParentheses message is no longer restricted to return statements.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3710 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-18 12:53:44 +00:00
Tom Copeland
2bf8da4a41 Cleaning up some stuff PMD found
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3709 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-16 02:47:36 +00:00
Tom Copeland
573841bdec Refactoring away a bunch of casts... good times
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3708 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-16 02:31:26 +00:00
Tom Copeland
7817e05519 Refactoring away a bunch of casts... good times
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3707 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-16 01:29:44 +00:00
Tom Copeland
947c9c4b94 Added a new utility method to AbstractRule and modified a bunch of rules to use it
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3706 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-16 00:25:52 +00:00
Tom Copeland
18775865fa Added a new utility method to AbstractRule and modified a bunch of rules to use it
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3705 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-16 00:11:18 +00:00
Radim Kubacki
84064bbdcb adding few rules that are specific to NetBeans as a library that can be loaded by plugin
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3704 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-15 15:35:03 +00:00
Radim Kubacki
071b4468cf attempt to close output stream
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3703 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-15 15:30:58 +00:00
Tom Copeland
6b34b6048d Enhanced EmptyIfStmt to catch more cases
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3702 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-14 20:33:26 +00:00
Tom Copeland
9d95547246 Enhanced EmptyIfStmt to catch more cases
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3701 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-14 20:28:01 +00:00
Tom Copeland
227503bc31 Using the SimpleNameMapper in test case now
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3700 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-14 01:49:57 +00:00
Philippe Herlin
5b9fcc3c76 RFE#1231112-Make the rule table columns sortable (thanks to Brian R)
BUG#1231108-Fix the resizing issue


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3699 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-12 16:38:25 +00:00
Philippe Herlin
54a3243824 RFE#1231112-Make the rule table columns sortable (thanks to Brian R)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3698 51baf565-9d33-0410-a72c-fc3788e3496d
2005-07-12 16:34:25 +00:00