2365 Commits

Author SHA1 Message Date
Clément Fournier
7c77945164 #1921 - exclude ByteArrayInputStream from CloseResource 2019-07-21 16:38:35 +02:00
Andreas Dangel
1ef5079b29 [java] ATFD calculation problem
* Fixes #1910
* Method call chains are now considered
2019-07-20 11:35:27 +02:00
Andreas Dangel
b19b7474fe Merge branch 'pr-1924' 2019-07-19 11:17:38 +02:00
Juan Martín Sotuyo Dodero
cb62b7e472 Fix false positive on UnsynchronizedStaticFormatterRule 2019-07-18 19:35:09 -03:00
Juan Martín Sotuyo Dodero
ca34d4fa1c Add failing test case for #1903 2019-07-18 19:34:51 -03:00
YoonhoChoi96
33f3129562 Modify expected problems and exclude for-each case 2019-07-18 10:54:16 +09:00
YoonhoChoi96
82ea3ed51b Simplify nested loop 2019-07-17 19:49:08 +09:00
YoonhoChoi96
24cb0aa976 add test cases for reduce False Positive 2019-07-17 19:26:22 +09:00
YoonhoChoi96
d080e3cb48 add test cases for reduce False Positive 2019-07-17 19:02:54 +09:00
AnthonyKot
a9c68a55b3 issue-1833 2019-07-13 21:57:58 +02:00
Andreas Dangel
6c9ecfa7c1 [doc] Escape code examples for liquid with {%raw%}
Fixes #1898
2019-07-12 10:57:10 +02:00
Andreas Dangel
6cb0701498 [doc] Fix broken internal links
* Links to pages need to be relative...
* Fixes #1906
2019-07-06 11:15:30 +02:00
YoonhoChoi96
cf16484ec6 Modifiying for reduce Fasle Positive in DFA Analysis Rule 2019-07-05 10:04:37 +09:00
Clément Fournier
1a690ed1e8 Fix DoubleBraceInitialization example 2019-07-01 18:33:48 +02:00
Andreas Dangel
92184ba56f Merge branch 'pr-1539' 2019-06-30 09:28:16 +02:00
Andreas Dangel
210a3dc8f9 Merge branch 'pr-1894' 2019-06-30 09:25:45 +02:00
Andreas Dangel
da69dc777a [java] CloseResource: fix another FP 2019-06-29 15:29:03 +02:00
Andreas Dangel
c2a45c64ca [java] CloseResource: verify first argument for chained streams 2019-06-29 15:01:24 +02:00
Andreas Dangel
74f36bf18e [java] Deprecate AvoidFinalLocalVariable
Fixes #1612, Refs #1482
2019-06-29 14:34:36 +02:00
Karl-Philipp Richter
d10d522d1f Explain the existence of AvoidFinalLocalVariable in it's description 2019-06-29 14:20:36 +02:00
Andreas Dangel
40849dda65 [java] CloseResource: consider chained streams
This assumes that the underlaying stream is always the
first argument in the constructor call.
2019-06-29 14:13:42 +02:00
Andreas Dangel
5825f6190f Merge branch 'master' into close-resource-io 2019-06-29 12:30:18 +02:00
Andreas Dangel
18006de84c [java] CloseResource: Update release notes and rule documentation 2019-06-29 12:29:40 +02:00
Andreas Dangel
ae046bb516 [java] CloseResource: verify old behaviour can be restored 2019-06-29 12:19:24 +02:00
Andreas Dangel
62a2c12585 [java] CloseResource: consider javax.jms.Connection as before
Adding back the default types java.sql.Connection etc. so that
we also match javax.jms.Connection in case no type information
is available as before.

Also fix the reported type when method calls are involved.
2019-06-29 12:15:19 +02:00
Andreas Dangel
f6cc999f2c [java] CloseResource: Use simple class name in message
Report simple class name to retain same message as before.
This helps in comparing the reports.
2019-06-29 11:22:03 +02:00
Andreas Dangel
314bb71336 Fix reporting of nested classes inside interfaces/enums 2019-06-29 11:13:51 +02:00
Andreas Dangel
7db495f7aa [java] CommentDefaultAccessModifier: add new property "checkTopLevelTypes"
Fixes #1880
2019-06-29 10:30:45 +02:00
Andreas Dangel
c66fb768ef Merge branch 'pr-1889' 2019-06-28 21:10:55 +02:00
Andreas Dangel
d7b0a21f99 Merge branch 'pr-1887' 2019-06-28 20:59:39 +02:00
Clément Fournier
9cf19214ff Move to bestpractices 2019-06-26 22:18:45 +02:00
Clément Fournier
45331699ab Add to quickstart ruleset 2019-06-26 19:59:16 +02:00
Clément Fournier
8fc0e9c875 Add test cases 2019-06-26 19:53:18 +02:00
Clément Fournier
8e988fd7fd Add DoubleBraceInitialization to design.xml 2019-06-26 19:40:11 +02:00
Clément Fournier
6b3ccdf069 Add a test case 2019-06-24 12:11:12 +02:00
Andreas Dangel
86ce57ca3c [java] CloseResource: support try-with-resources 2019-06-22 19:01:24 +02:00
Andreas Dangel
1e03ae5c06 [java] CloseResource - add allowedResourceTypes property for exceptions
By default, ByteArrayOutputStream and StringWriter are excluded from
the rule.
2019-06-22 12:24:43 +02:00
Andreas Dangel
eab41508da [java] CloseResource: Use java.lang.AutoCloseable by default 2019-06-22 10:25:27 +02:00
Andreas Dangel
2da9708d20 [java] The rule CloseResource should deal with IO stream as default
Fixes #1000
2019-06-22 10:25:26 +02:00
Juan Martín Sotuyo Dodero
ecfcfaf8ae Merge branch 'pr-1851' 2019-06-16 21:44:11 -03:00
artem.krosheninnikov
fadaf07015 review fixes 2019-06-14 13:02:15 +03:00
artem.krosheninnikov
3e280cd9d0 Merge branch 'master' into 1845-fix-methodreturnsinternalarray-regression 2019-06-14 12:33:41 +03:00
artem.krosheninnikov
5f40ab11cf enum with array instead of copy, inner enums with error and no error 2019-06-14 01:47:17 +03:00
artem.krosheninnikov
c5a77fbc35 add inner interface, inner and top-level annotations 2019-06-13 01:04:50 +03:00
Andreas Dangel
427b5003a3 Merge branch 'pr-1829' 2019-06-08 17:22:18 +02:00
Andreas Dangel
142a706d5e Merge branch 'pr-1792' 2019-06-08 17:10:23 +02:00
Clément Fournier
348a9972e6 Fix #1853 false positive in NonStaticInitializer 2019-06-02 09:26:13 +02:00
Andreas Dangel
2bcb8dcfdc Merge branch 'pr-1849' 2019-06-01 19:41:20 +02:00
Andreas Dangel
fe420562a1 More deprecations of node setters and constructors 2019-06-01 19:16:37 +02:00
Andreas Dangel
2d60e2b822 Remove more unnecessary comments from javacc 2019-06-01 19:15:50 +02:00