168 Commits

Author SHA1 Message Date
5a4ee14831 code cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6904 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-28 23:15:12 +00:00
139871ffb5 merge of the violationsAsErrors config option from the 4.2.x branch
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6902 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-28 20:31:36 +00:00
fc3347d73a added 2009 in copyright
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6901 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-28 20:13:21 +00:00
6176b37e22 merge from 4.2.x branch: unpack after install to make sure code fragments can use PMD classes
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6900 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-28 20:11:03 +00:00
53776fc201 incorrect extension point in documentation
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6895 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-23 18:02:58 +00:00
ef36aee425 Misc for-loop conversions
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6886 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-09 22:46:03 +00:00
53dd793369 Restored ability add new variables for XPath rules, the dialog is raw but will be tweaked. Need to modify the Rule interface in PMD property to be able to drop them...upcoming.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6885 51baf565-9d33-0410-a72c-fc3788e3496d
2009-03-09 22:43:12 +00:00
1254933e74 misc loop conversion
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6878 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-27 16:17:05 +00:00
5c98ea43c1 Adjust field colouring to reflect overridden property values, added missing XPath version field.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6877 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-27 16:11:56 +00:00
491a6e34e8 Bugfix for disappearing rule after adding new one.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6876 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-25 02:25:12 +00:00
837c81cfb4 Added new panel to the preference page for XPath settings. Relevant tabs show "-----" when disabled now.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6875 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-24 00:17:17 +00:00
beb9f12d23 Loop conversions, extURL validation, minor ui cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6871 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 15:41:58 +00:00
37b2f9a3ab typos
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6870 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 15:28:59 +00:00
ba9ee69e86 Deprecation tags, for-loop and StringBuffer conversions
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6869 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 15:22:59 +00:00
b9ded04e51 For loop and StringBuffer->StringBuilder conversions
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6868 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-23 15:07:21 +00:00
461cf80bfd pmd.jar updated to snapshot version 6861
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6867 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-22 19:29:25 +00:00
c560315d0a Refactored packages, additional fields & panels, numerous bugfixes & improvements. Almost ready for prime time. Requires latest PMD 5.0 jar.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6866 51baf565-9d33-0410-a72c-fc3788e3496d
2009-02-22 09:28:09 +00:00
1884a2621e + support for multi-method properties and various bugfixes.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6796 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-18 22:42:51 +00:00
5643e06b8e use eclipse.home to set baseLocation
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6795 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-18 22:21:24 +00:00
177fa473dc Added edit support for Method property types, new selection widgets for types & methods.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6793 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-18 07:51:35 +00:00
6c6fbab9be Updated multi-value editors for String, Type, and Integer, no popup dialogs req'd :) Bugfixes for enumerated type, spinner widgets for floats & doubles. No support yet for editing method values, awaiting development of a class picker widget.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6792 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-18 03:31:21 +00:00
452e38a0d7 New Preference panel updates: revised rule columns, new compact colour-coded regex filter column. Reworked property tab resizing. Refactored editors into separate package.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6791 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-12 04:14:32 +00:00
aa07a15ae4 Bugfixes for new UI preferences panel: Fixed selection bug that resulted in a blank property field window, fixed text field lengths, all now span full width. Added sash/splitter bar between rule table and property tabs. Users can now edit xpath/exclusion property values for multiple rules at once.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6790 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-11 22:48:16 +00:00
3e28599cf1 Last missing class (I hope)
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6782 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-11 00:27:10 +00:00
c5beff7ad9 missing class, under development
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6781 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-11 00:16:13 +00:00
20ddc87817 Added new option to the rule context/popup menu that allows users to move rules between rulesets. I don't believe the underlying PMD system supports this at the moment though I believe we can do this - see my suggestion at https://sourceforge.net/forum/forum.php?thread_id=2824589&forum_id=188194
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6780 51baf565-9d33-0410-a72c-fc3788e3496d
2009-01-10 23:39:56 +00:00
6ee649a718 Update to current PMD 5.0, fixes issued with RuleSetFactory.getRegisteredRuleSets() due to missing ecmascript ruleset.properties.
Update PreferenceManagerImpl for RuleSetFactory changes.

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6765 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-31 08:01:24 +00:00
9ebf4a0f52 update PMD jar file to revision 6760
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6762 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-29 20:10:52 +00:00
2bb06bb210 Bugfix for property updates while in grouped rule mode, enabled multi-select in rule list - users can modify priority levels via new popup menu, bugfix for multi-value renderers, new RuleSelection class. I'm still waiting for usability/feature feedback comments!
Need to implement: scrolling panel for property values, a splitter bar between rules & property tabs below, proper editors for enum types and multi-values, especially classes & interfaces. Still need to deal with statistical value rules - they throw exceptions at the moment, those guys have no defaults for now (not necessary?)

*** Please to not update the old PMDPreferencesPage, apply any necessary changes to the class of the same name in the temporary .br package. The old one remains as is where it is for comparison with the new one that shows up in the Eclipse preference panel right below the PMD entry ("Ruleset preferences - br"). 

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6761 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-29 19:26:21 +00:00
09a89dd005 Fix tests because of removal of PluginConstants interface, which was replaced with a call to RuleSetFactory.getRegisteredRuleSets(). It is unclear to me why the plugin did explicit enumeration of the RuleSets, perhaps it was put in before the factory could enumerate them.
FYI, I am _not_ able to run these tests successfully.  There is something about how to run them that I do not currently grok, nor am I too worried about it at this time.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6743 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-05 08:05:50 +00:00
5a5ccf0a03 Open things up to support files other than .java files. This includes:
1) Allow the PMD context menu on any File type, not just *.java.
2) Modify some places which check for a .java extension to _not_ do so.
3) Modify some places to check with the PMDEngine whether a File "applies" (e.g. is it for a Language which is understood by PMD and are there any Rules in the RuleSet for that Language).

Expand the Rule table to have a Language column in the 1st column.  The table setup in this plugin/SWT still *sucks* as bad I remember it being the last time I added columns.

With these changes I can get both JS and XML Rules to work.  Violations show up, and for JS, I can be brought to the proper line number in the code!

Also fixed and issue with this plugin looking for a "maxViolations" property on the Rules, which given PMD 5.0 changes to require a propery to exist to ask for a value... needed some tweaking to first check for the value on the Rule.  More verbose, but a safer API than the Wild West style of pre-5.0.

The Rule Editor needs some work to account for the new structure of Rules in PMD 5.0.  Currently any Rule it creates causes things to blow up due to missing Language.  Easy enough to fix, but it's just the 1st of several things needing to be corrected.




git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6742 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-05 07:55:16 +00:00
72a6746f25 Update PMD version to current trunk. Add JARs for Saxon and Rhino.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6741 51baf565-9d33-0410-a72c-fc3788e3496d
2008-12-05 07:43:25 +00:00
66fd22b0cf code cleanup (eclipse warnings): unused imports, useless casts, ...
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6696 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-14 16:49:30 +00:00
61e992368b extra exported packages: rulesets and net.sourceforge.pmd.eclipse.plugin
patch submitted by Peter Hayes


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6695 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-14 03:21:34 +00:00
7249d54add bug fix: Reordered the ProjectPropertiesManagerImpl.fillProjectProperties method so that setRuleSetFile() comes before setRuleSetStoredInProject() (This fixes an issue when the project ruleset file is not the default name)
patch submitted by Peter Hayes


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6694 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-14 03:05:21 +00:00
38bbc268aa update pmd-5.0.jar to snapshot 6690, all compilation errors should be fixed now
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6691 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-04 17:41:08 +00:00
6ba0b1806b cleanup, commented-out final compilation issues. Still need to actually clean out the old property mgmt code once the new checked & finished.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6690 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-04 04:40:57 +00:00
88b0bffb90 generics cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6689 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-04 04:24:41 +00:00
fb6410394c import cleanup
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6688 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-04 04:12:18 +00:00
ec7c146f83 refactored editor factories, zapped redundancies
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6687 51baf565-9d33-0410-a72c-fc3788e3496d
2008-11-04 04:09:25 +00:00
f1ff5dcbf2 rm file utility method migrated to pmd proper
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6684 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-26 23:51:39 +00:00
2e62d043ca NumericConstants.floatZERO was renamed FLOAT_ZERO in PMD
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6682 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-26 19:49:09 +00:00
60314b66c4 Revised plugin to allow viewing of revised property preferences page. New page sits outside of the PMD parent node for now until we remove the old one.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6680 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-25 23:00:26 +00:00
72877f4679 refactored to handle move of Util class to new package
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6679 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-25 22:58:00 +00:00
90da682ebf optimizations, adaptations for new property mgmt framework. Some classes may still be removed.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6678 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-25 22:56:04 +00:00
7fa24a8af0 Code cleanup, deprecations, some adaptations for new properties. Some classes that currently have errors will soon be removed.
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6677 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-25 22:49:37 +00:00
3a29f39522 minor optimizations
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6676 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-25 22:45:36 +00:00
2c907a02fe typos & minor optimizations
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6675 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-25 22:43:36 +00:00
12c5faef85 typos & minor optimizations
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6674 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-25 22:41:39 +00:00
a91dad5f37 typos & minor optimizations
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6673 51baf565-9d33-0410-a72c-fc3788e3496d
2008-10-25 22:37:59 +00:00