Mykhailo Palahuta
aa3271978f
CloseResource: a method call as an allocation argument bug fix
2020-07-27 23:45:02 +03:00
Mykhailo Palahuta
4bb3759371
[java] CloseResource false positive when resource included in return value
2020-07-27 20:00:45 +03:00
Andreas Dangel
25405eb870
Merge branch 'pr-2643'
...
[java] AvoidCallingFinalize detects some false positives (2578) #2643
2020-07-17 20:30:01 +02:00
Andreas Dangel
db21d589d4
[java] AvoidCallingFinalizeRule - use rulechain
...
And improve tests
2020-07-17 20:28:55 +02:00
Andreas Dangel
585b9099ca
Merge branch 'pr-2640'
...
[java] NullPointerException in rule ProperCloneImplementation #2640
2020-07-17 19:47:30 +02:00
Andreas Dangel
7b3d31246e
Merge branch 'master' into pr-2624
2020-07-17 15:16:24 +02:00
Andreas Dangel
7ae424a35b
Add deprecation javadocs
2020-07-17 14:43:43 +02:00
Andreas Dangel
e24a26e211
Merge branch 'pr-2629'
...
[all] Dependencies cleanup #2629
2020-07-17 12:07:03 +02:00
Andreas Dangel
94afdb117d
Add test engines as surefire plugin dependencies
...
This removes junit-vintage-engine as a test dependency
as well as kotlintest-runner-junit5.
The engines are only needed during test execution, but should
not be available for test compilation.
For this to work, the latest surefire plugin is required.
2020-07-17 12:03:45 +02:00
Mykhailo Palahuta
01e48c882b
AvoidCallingFinalize: expected lines added to test
2020-07-17 11:05:55 +03:00
Andreas Dangel
9887d5a387
Merge branch 'pr-2618'
...
[java] New rule: UnusedAssignment #2618
2020-07-16 19:56:22 +02:00
Andreas Dangel
88ac918e4f
[java] UnusedAssignmentRule - add rule chain visit
2020-07-16 19:53:41 +02:00
Andreas Dangel
a8a3fccdf5
[doc] Update release notes, new rule UnusedAssignment
2020-07-16 19:22:38 +02:00
Mykhailo Palahuta
9bbb6aab4d
AvoidCallingFinalize: constructor false negative fix
2020-07-16 19:21:22 +03:00
Andreas Dangel
24af109454
Merge branch 'master' into pr-2560
2020-07-16 13:17:45 +02:00
Andreas Dangel
693c870f28
[java] LawOfDemeter - add test cases
2020-07-16 13:12:17 +02:00
Mykhailo Palahuta
2eedff056c
AvoidCallingFinalize: addViolation, getArgsCount fix
2020-07-16 11:55:09 +03:00
Andreas Dangel
a60615f542
[java] AvoidInstantiatingObjectsInLoopsRule - add test case for fixed FN
...
By changing this rule to use rule chain, this FN for anonymous classes
has been fixed as well.
2020-07-16 10:39:30 +02:00
Mykhailo Palahuta
5a6e3d609e
[java]AvoidCallingFinalize detects some false positives (2578)
2020-07-15 15:44:54 +03:00
Mykhailo Palahuta
782cb9d262
[java] NullPointerException in rule ProperCloneImplementation
2020-07-14 14:00:42 +03:00
Andreas Dangel
cc408d2876
[java] AvoidInstantiatingObjectsInLoopsRule - fix false negative
2020-07-13 20:00:46 +02:00
Andreas Dangel
c5364a81f8
[java] Fix and simplify AvoidInstantiatingObjectsInLoopsRule
2020-07-09 18:55:10 +02:00
Andreas Dangel
e48489450f
[java] Add test for #2207 : AvoidInstantiatingObjectsInLoops false positives
2020-07-09 18:54:53 +02:00
Andreas Dangel
8766d54a07
[java] Fix and simplify UseStringBufferForStringAppendsRule
2020-07-09 16:08:30 +02:00
Andreas Dangel
6f6f87c7dc
[java] Add test for #1736 : UseStringBufferForStringAppends false positive
2020-07-09 15:21:36 +02:00
Young Chan
e6c32ecbaa
Update UseStringBufferForStringAppendsRule.java
2020-07-09 15:12:32 +02:00
Young Chan
b782575951
Update AvoidInstantiatingObjectsInLoopsRule.java
2020-07-09 15:12:32 +02:00
Young Chan
6cff647681
fix issue #2207
2020-07-09 15:11:03 +02:00
Young Chan
f5ccc94130
fix issue #1736
2020-07-09 15:11:00 +02:00
Young Chan
11a0ec51fd
fix issue 1736
2020-07-09 15:10:40 +02:00
Andreas Dangel
370c0b0b6d
Remove unused dependency, explicitly declare used dependencies
2020-07-02 15:12:31 +02:00
Andreas Dangel
c7ccb8a087
javacc is only needed during parser generation
2020-07-02 10:27:26 +02:00
Andreas Dangel
43dd6567e2
[java] Update test dependency log4j
...
This fixes https://github.com/advisories/GHSA-vwqq-5vrc-xw9h
2020-07-02 10:13:08 +02:00
Andreas Dangel
f4bf540bc3
[java] Remove usages of DummyJavaNode
2020-07-02 09:48:23 +02:00
Clément Fournier
49635c2a66
Deprecate Rulechain visitors
2020-07-01 11:27:38 +02:00
Clément Fournier
659066ee02
Deprecate BaseLanguageModule constructor
2020-07-01 11:27:38 +02:00
Clément Fournier
d7f96e08d9
Uniformize apply across languages
2020-07-01 11:27:38 +02:00
Clément Fournier
556685de1b
Remove changes to VariableNameDeclaration
...
Probably this is what causes DFAAR to change
behavior. The current behavior is wrong (two
variables are not equal just from their name,
that doesn't account for whether they're declared
independently or shadow a declaration). But
whatever, this will be scrapped in 7.0
2020-06-28 18:41:42 +02:00
Clément Fournier
e04223356b
Merge branch 'master' into new-rule-UnusedAssignment
2020-06-28 18:19:40 +02:00
Clément Fournier
8c30440843
Move to bestpractices.xml
2020-06-28 18:15:04 +02:00
Clément Fournier
734da43fbf
Ignore vars that start with "ignore"
2020-06-28 18:11:14 +02:00
Clément Fournier
82995fbe07
Fix unused formal value FN
2020-06-28 17:57:45 +02:00
Clément Fournier
a6d9d595dd
Add test case for unused var
2020-06-28 17:26:23 +02:00
Clément Fournier
546c525ad0
Shorten messages a bit
2020-06-28 17:08:35 +02:00
Clément Fournier
3d7aaf7cda
Fix FPs with reportUnusedVariables & foreach vars
2020-06-28 17:03:57 +02:00
Clément Fournier
388e29a9de
Fix unused exception in loop
2020-06-28 16:35:53 +02:00
Clément Fournier
105f1a13a1
Implement loop condition flow
2020-06-28 02:22:06 +02:00
Clément Fournier
49f775be83
Disable reporting of unused vars by default
2020-06-28 00:26:22 +02:00
Clément Fournier
4207c36740
Fix some bugs
2020-06-27 23:34:29 +02:00
Clément Fournier
b049541126
Fix pmd warnings
2020-06-27 22:19:13 +02:00
Mykhailo Palahuta