Commit Graph

1387 Commits

Author SHA1 Message Date
Juan Martín Sotuyo Dodero b32644c744 Merge branch 'pr-775' 2017-12-07 22:48:36 -03:00
Juan Martín Sotuyo Dodero dc75904de6 Make sure we only recomend this to "modern" JVMs 2017-12-07 22:48:08 -03:00
Andreas Dangel 07cb937d6e [java] Update OptimizableToArrayCall rule for current JVMs
See https://sourceforge.net/p/pmd/bugs/1454/
and https://shipilev.net/blog/2016/arrays-wisdom-ancients/
2017-12-01 11:41:23 +01:00
Andreas Dangel 5e3b4504d8 [java] Remove old rules GuardDebugLogging and GuardLogStatementJavaUtil 2017-11-30 22:48:01 +01:00
Andreas Dangel 1447ac8a4a [java] Merge GuardDebugLogging and GuardLogStatementJavaUtil into
the rule GuardLogStatement
2017-11-30 22:38:14 +01:00
Andreas Dangel 8eb5170b31 Merge branch 'pr-736' 2017-11-27 20:47:27 +01:00
Andreas Dangel 456432ad6f Resolve deprecated usages 2017-11-24 20:48:02 +01:00
Andreas Dangel fa1e16fcf8 [java] Remove FUTURE comment from AccessNode 2017-11-24 20:15:58 +01:00
Andreas Dangel c49ae6b769 Merge branch 'pr-742' 2017-11-24 11:51:18 +01:00
Andreas Dangel 6c14880afa Merge branch 'pr-741' 2017-11-24 11:45:10 +01:00
Andreas Dangel 3bad361e2f [java] Change MoreThanOneLoggerRule to avoid classloader issues
refs #732
2017-11-24 11:43:23 +01:00
Andreas Dangel 8b77f6769e Merge branch 'pr-748' 2017-11-23 21:27:41 +01:00
Andreas Dangel 31725ae241 Merge branch 'pr-747' 2017-11-23 21:25:36 +01:00
Andreas Dangel 6136de2d28 Fix Metrics ruleset name 2017-11-23 20:30:32 +01:00
Juan Martin Sotuyo Dodero b4e0cd3649 [java] EmptyCatchBlock ignore expected by default
- We chnge the default to ignore exceptions named `ignore` or
   `expected`, users can still override this behaviour.
2017-11-21 18:30:50 -03:00
Juan Martin Sotuyo Dodero 4e29faa3eb [java] Merge EmptyStaticInitializer into EmptyInitializer 2017-11-21 17:51:59 -03:00
Juan Martín Sotuyo Dodero a9ce410845 Merge branch 'master' into api-ruleset-compatibility 2017-11-21 14:53:42 -03:00
Juan Martin Sotuyo Dodero 8edd3ed091 Merge branch 'pr-733' 2017-11-21 12:34:06 -03:00
Clément Fournier 5a978cb7b0 Make CommentRequirement private 2017-11-21 11:45:09 +01:00
Juan Martin Sotuyo Dodero 6028e77e62 [core] Improve classloaders
- Avoid a race condition that could produce multiple threads loading
   the same class at the same time.
 - Fixed a broken check on PMDASMClassLoader that would always return
   false.
2017-11-21 00:16:20 -03:00
Juan Martin Sotuyo Dodero 3ca4b71f72 [java] Don't expect to load classes from execution classpath
- We can't assume the classes needed for analysis will be available
in the execution classpath, we need to make sure to load them from the
same classloader / auxclaspath used during analysis.
 - Resolves #732
2017-11-21 00:12:52 -03:00
Juan Martin Sotuyo Dodero d8fdbde68d Merge branch 'pr-727' 2017-11-20 17:29:41 -03:00
Juan Martin Sotuyo Dodero 73df7d048a Merge branch 'pr-729' 2017-11-20 16:37:12 -03:00
Andreas Dangel 98ac510443 Merge branch 'pr-734' 2017-11-19 13:47:02 +01:00
Andreas Dangel fd0cdb9514 Mark property "reportLevel" of CyclomaticComplexityRule as deprecated 2017-11-19 13:39:21 +01:00
Clément Fournier 3055d25aac Fix doc 2017-11-18 15:34:42 +01:00
Clément Fournier 79dd6c525f Fix npath documentation bad rendering 2017-11-18 15:31:58 +01:00
Clément Fournier 652b80004d Make Saxon support multival properties as XPath sequences 2017-11-17 18:41:07 +01:00
Clément Fournier 7cab3cbc73 Move CyclomaticComplexity from metrics to design w/ deprecated property 2017-11-12 13:33:05 +01:00
Juan Martín Sotuyo Dodero 227a0046c5 Merge branch 'pr-726' 2017-11-11 19:14:02 -03:00
Clément Fournier 2eee7a1276 Decouple enum constants from their labels 2017-11-11 22:40:02 +01:00
Clément Fournier a9843c6a44 Add accessor comment requirement property 2017-11-11 22:17:11 +01:00
Clément Fournier 3e1a787f26 Fix override property 2017-11-11 22:17:11 +01:00
Clément Fournier 57deb9d78d Pretty print the messages 2017-11-11 22:17:11 +01:00
Clément Fournier e316fcc64f Remove some garbage 2017-11-11 22:17:00 +01:00
Clément Fournier 2efb52be14 Add ignore override property 2017-11-11 20:59:27 +01:00
Andreas Dangel 58b996a634 [core] Add all rules of a ruleset, if the ruleset itself is deprecated
that is: The ruleset only contains deprecated rules.
2017-11-11 14:06:50 +01:00
Clément Fournier b9a605c86a Shorten test case 2017-11-11 12:07:51 +01:00
Andreas Dangel 06a1244e15 [doc] Add unit test for all rulesets and fix existing rulesets 2017-11-10 14:03:05 +01:00
Andreas Dangel 3b624bf687 Merge branch 'pr-722' 2017-11-09 22:04:46 +01:00
Clément Fournier 947d4ab1a8 Fix issue #721 2017-11-09 20:54:03 +01:00
Clément Fournier 31696c7397 Deprecate compat property for 7.0.0 2017-11-09 20:28:09 +01:00
Clément Fournier 695defcc61 Add old property back and log warning + correct the property range 2017-11-09 15:02:59 +01:00
Andreas Dangel d0f0c467a0 Merge branch 'pr-717' 2017-11-08 20:54:12 +01:00
Clément Fournier f8bea7f580 Move NPathComplexity from metrics to design 2017-11-08 14:11:36 +01:00
Juan Martín Sotuyo Dodero 2c0957a07b Add back the removed UnnecessaryFinalModifier rule 2017-11-07 20:39:30 -03:00
Andreas Dangel 6bba28acbe Add categories.properties files 2017-11-07 22:23:17 +01:00
Juan Martín Sotuyo Dodero f9f96b84fe [java] merge UnnecessaryFinalModifier into UnnecessaryModifier
- I take the chance to also flag final resources in try-with-resources
 - This resolves #411
 - This resolves #676
 - The rule is now using the rulechain
2017-11-07 00:34:00 -03:00
Juan Martín Sotuyo Dodero 25da0c86f2 Merge branch 'pr-697' 2017-11-06 13:41:27 -03:00
Juan Martín Sotuyo Dodero 9e1342f30a Merge branch 'pr-696' 2017-11-04 19:48:28 -03:00