Commit Graph

2659 Commits

Author SHA1 Message Date
b71575fa36 [java] Cyclomatic complexity is misreported (lack of clearing metrics cache)
Fixes #1984
2020-01-17 11:35:32 +01:00
f53993427c Merge branch 'pr-2172'
[core] Deprecate jjtree methods from the Node interface
2020-01-17 08:18:50 +01:00
741bb0b218 Update usages 2020-01-16 22:29:41 +01:00
3062d59892 Merge branch 'master' of github.com:pmd/pmd 2020-01-16 22:28:52 +01:00
d9719e850c Deprecate ASTCatchStatement::getBlock for #2202 2020-01-16 22:28:40 +01:00
9c682e4a88 Merge branch 'pr-2200'
[java] InvalidLogMessageFormat: handle zero placeholders correctly
2020-01-16 18:08:26 +01:00
99fdede0aa Merge branch 'issue-2212' 2020-01-12 23:28:33 +01:00
904fb14e8b Use interface instead of AbstractAnyTypeDeclaration 2020-01-12 23:27:24 +01:00
820edada4f Add 'children' iterable method to Node interface 2020-01-12 18:18:38 +01:00
f7bd2d54b3 Add kotlin test sources to build-helper-mvn-plugin
Intellij doesn't pick up on the sources
correctly and classifies them as resources otherwise
2020-01-11 20:33:58 +01:00
bc92fa4590 [java] JavaRuleViolation reports wrong class name
Fixes #2212
2020-01-11 12:51:21 +01:00
398b683565 Merge branch 'pr-2177'
[lang-test] Factorize parsing logic for tests
2020-01-10 14:07:29 +01:00
c53d9508e9 Small changes from code review
* rename BaseParserHelper
* Not using org.jetbrains.annotations.NotNull
2020-01-10 12:18:43 +01:00
6bea1e618b [java] InvalidLogMessageFormat: handle zero placeholders correctly
Fixes #2196

Also refactors the implementation to not use a XPath query anymore.
2020-01-06 18:02:41 +01:00
e335e069f8 Merge branch 'master' into deprecate-jjtree-methods 2020-01-05 23:17:25 +01:00
0ff87229ff Remove TokenBasedNode
I don't think we should expose tokens as an API
yet. They're an implementation detail, not used
much, and the AST should be able to reflect all
the information that can be found in the tokens.

The methods of AbstractNode can be pulled down
to AbstractJjtreeNode and made protected.
2020-01-05 23:13:04 +01:00
a0d0a22e7b Merge branch 'pr-2190'
[java] Deprecations for statements PR

Prerequisite for #2164 for PMD 7.0.0
2020-01-05 19:30:52 +01:00
f973ad6ef3 Merge branch 'pr-2185'
[core] Internalize API that exposes ResourceLoader
2020-01-05 19:18:18 +01:00
4cf6291ecb Fix pmd 2020-01-05 18:20:26 +01:00
caaa5eba9a Fix issue with analysis of IPv6 mapper IPv4 2020-01-04 04:37:13 -03:00
3b8d694be3 Fix odd logic in AvoidUsingHardCodedIPRule 2019-12-29 22:00:13 +03:00
f33291e372 Deprecate ASTYieldStatement implementing TypeNode 2019-12-26 18:53:22 +01:00
0a0bb6e4bb Rename getGuardExpressionNode -> getCondition 2019-12-26 18:47:28 +01:00
41baa353b0 Deprecate API of TryStatement that will be renamed 2019-12-26 18:40:24 +01:00
05870c98cc Deprecate RulesetFactory constructors 2019-12-24 14:39:20 +01:00
9023d86945 Merge branch 'master' into deprecate-jjtree-methods 2019-12-23 12:41:08 +01:00
a7c5a1f0be Cleanup PMD.EOL in tests
Instead, normalize line endings in parse method.
This makes sure test code snippets are portable
and readable. For now they're platform-specific,
and assume that the resource files are saved with
the platform-specific line separator. This may not
be the case, as eg a git file may be checked out
with CRLF on a unix system.
2019-12-22 20:16:19 +01:00
80534a7e69 Fix line endings 2019-12-22 19:53:10 +01:00
5906564e23 Fix resource path 2019-12-20 19:01:10 +01:00
8afe5ae7a8 Abstract away parser utils
Convert a few pieces of code

Share with modelica

Remove yet another dup

Fix tests

Doc

Share with plsql

Fix tests

Fix build

Cleanup

Minimize diff

Share with JSP module

Share with JS module

Share with XML module

Share with VisualForce module

Share with Scala module

Fix last tests
2019-12-20 18:30:17 +01:00
f67819e05a Merge branch 'pr-2069'
[java] CommentRequired: make property names consistent
2019-12-20 11:38:03 +01:00
0ff3216b48 Merge branch 'pr-2150'
[java] Fix false negative in AvoidLiteralsInIfCondition
2019-12-18 09:50:19 +01:00
627e258458 Revert 2019-12-17 17:49:01 +01:00
86b274c681 Make generic visitor superclass
Use raw supertype to avoid conflicts
2019-12-17 17:39:13 +01:00
2f37e1c256 Deprecate jjt* methods 2019-12-17 17:39:13 +01:00
1aabc53fa2 Deprecate childrenAccept in all modules 2019-12-17 17:39:13 +01:00
98df6bda1c Add TokenBasedNode, AbstractJjtreeNode 2019-12-17 17:39:13 +01:00
d8ed0cf45e [java] CommentRequired: Deprecated property "headerCommentRequirement" 2019-12-17 15:44:02 +01:00
6cec74851a [java] CommentRequired: Make headerCommentRequirement ignored by default, make tests more targeted
Refs #1683
2019-12-17 12:31:17 +01:00
88ff3f0628 [java] CommentRequired: Separate header comment from class comment and header top-level comment
Refs #1683
2019-12-17 12:30:05 +01:00
1480bfeaa4 Merge branch 'pr-2165'
[java] Deprecate JavaQualifiedName and a few other things
2019-12-17 10:45:34 +01:00
6aadcb29a3 Fix UnnecessaryLocalBeforeReturn FP with method reference 2019-12-16 17:31:56 +01:00
50560e0aac Fix deprecated attribute usage 2019-12-16 16:23:27 +01:00
7b5e9703ec [java] AvoidLiteralsInIfCondition: add property ignoreExpressions
The property ignoreExpressions is set to true in order to keep
the rule backwards compatible.
2019-12-16 11:17:25 +01:00
1cfd14ec7c [java] AvoidLiteralsInIfCondition: add additional check for expressions 2019-12-16 11:17:21 +01:00
c0d0fd3fbe [java] AvoidLiteralsInIfCondition: report Literal rather than IfCondition
If the IfCondition spans multiple lines, it easier to spot the
literal, if the violation is reported on the correct line where
the literal is located.
2019-12-16 11:17:21 +01:00
ed253183aa [java] AvoidLiteralsInIfCondition: false negative for expressions
Fixes #2140
2019-12-16 11:17:17 +01:00
76d33ea3dd Fix checkstyle 2019-12-16 11:06:33 +01:00
eddff1449e Deprecate TypeKind and related 2019-12-16 00:26:05 +01:00
da194bf427 Merge branch 'pr-2148'
[java] Fix false negative for StringInstantion with array access
2019-12-13 20:14:52 +01:00