phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
15,629 Commits 16 Branches 123 Tags
Commit Graph

2629 Commits

Author SHA1 Message Date
Andreas Dangel
c53d9508e9 Small changes from code review 
* rename BaseParserHelper
* Not using org.jetbrains.annotations.NotNull
 2020-01-10 12:18:43 +01:00
Clément Fournier
a7c5a1f0be Cleanup PMD.EOL in tests 
Instead, normalize line endings in parse method.
This makes sure test code snippets are portable
and readable. For now they're platform-specific,
and assume that the resource files are saved with
the platform-specific line separator. This may not
be the case, as eg a git file may be checked out
with CRLF on a unix system.
 2019-12-22 20:16:19 +01:00
Clément Fournier
80534a7e69 Fix line endings 2019-12-22 19:53:10 +01:00
Clément Fournier
5906564e23 Fix resource path 2019-12-20 19:01:10 +01:00
Clément Fournier
8afe5ae7a8 Abstract away parser utils 
Convert a few pieces of code

Share with modelica

Remove yet another dup

Fix tests

Doc

Share with plsql

Fix tests

Fix build

Cleanup

Minimize diff

Share with JSP module

Share with JS module

Share with XML module

Share with VisualForce module

Share with Scala module

Fix last tests
 2019-12-20 18:30:17 +01:00
Andreas Dangel
f67819e05a Merge branch 'pr-2069' 
[java] CommentRequired: make property names consistent
 2019-12-20 11:38:03 +01:00
Andreas Dangel
0ff3216b48 Merge branch 'pr-2150' 
[java] Fix false negative in AvoidLiteralsInIfCondition
 2019-12-18 09:50:19 +01:00
Andreas Dangel
d8ed0cf45e [java] CommentRequired: Deprecated property "headerCommentRequirement" 2019-12-17 15:44:02 +01:00
snuyanzin
6cec74851a [java] CommentRequired: Make headerCommentRequirement ignored by default, make tests more targeted 
Refs #1683
 2019-12-17 12:31:17 +01:00
snuyanzin
88ff3f0628 [java] CommentRequired: Separate header comment from class comment and header top-level comment 
Refs #1683
 2019-12-17 12:30:05 +01:00
Andreas Dangel
1480bfeaa4 Merge branch 'pr-2165' 
[java] Deprecate JavaQualifiedName and a few other things
 2019-12-17 10:45:34 +01:00
Clément Fournier
6aadcb29a3 Fix UnnecessaryLocalBeforeReturn FP with method reference 2019-12-16 17:31:56 +01:00
Clément Fournier
50560e0aac Fix deprecated attribute usage 2019-12-16 16:23:27 +01:00
Andreas Dangel
7b5e9703ec [java] AvoidLiteralsInIfCondition: add property ignoreExpressions 
The property ignoreExpressions is set to true in order to keep
the rule backwards compatible.
 2019-12-16 11:17:25 +01:00
Andreas Dangel
1cfd14ec7c [java] AvoidLiteralsInIfCondition: add additional check for expressions 2019-12-16 11:17:21 +01:00
Andreas Dangel
c0d0fd3fbe [java] AvoidLiteralsInIfCondition: report Literal rather than IfCondition 
If the IfCondition spans multiple lines, it easier to spot the
literal, if the violation is reported on the correct line where
the literal is located.
 2019-12-16 11:17:21 +01:00
Andreas Dangel
ed253183aa [java] AvoidLiteralsInIfCondition: false negative for expressions 
Fixes #2140
 2019-12-16 11:17:17 +01:00
Clément Fournier
76d33ea3dd Fix checkstyle 2019-12-16 11:06:33 +01:00
Clément Fournier
eddff1449e Deprecate TypeKind and related 2019-12-16 00:26:05 +01:00
Andreas Dangel
da194bf427 Merge branch 'pr-2148' 
[java] Fix false negative for StringInstantion with array access
 2019-12-13 20:14:52 +01:00
Andreas Dangel
2b1e21bf11 Merge branch 'pr-2151' 
[java] Fix false-positive in JUnitAssertionsShouldIncludeMessage
 2019-12-13 20:10:50 +01:00
Clément Fournier
1f0caf5034 Merge branch 'master' into deprecate-rvf-impls 2019-12-09 01:09:27 +01:00
Clément Fournier
c5b332d7fd Also deprecate JavaDataFlowHandler 2019-12-08 14:17:56 +01:00
Clément Fournier
5545927bd9 Do the same for Java language handlers 2019-12-08 14:17:19 +01:00
Clément Fournier
088f077407 Deprecate AbstractJavaParser 
Internalize JavaLanguageParser
 2019-12-08 14:15:59 +01:00
Andreas Dangel
71bf676225 Remove unnecessary CDATA in JUnitAssertionsShouldIncludeMessage.xml 2019-12-08 12:15:03 +01:00
Andreas Dangel
9502cae042 [java] JUnitAssertionsShouldIncludeMessage - False positive with assertEquals and JUnit5 
Fixes #2149
 2019-12-08 12:10:32 +01:00
Andreas Dangel
b7d61fca94 [java] StringInstantiation: fix false negative with multi-dim arr access 2019-12-06 12:21:11 +01:00
Andreas Dangel
9616312de2 [java] Support type resolution for array access expressions 2019-12-06 12:21:06 +01:00
Andreas Dangel
3b6fcf4b7a [java] StringInstatiation: False negative with String-array access 
Fixes #2141
 2019-12-06 11:18:27 +01:00
Andreas Dangel
b1fc3110de [java] StringInstatiation tests - remove unnecessary CDATA 2019-12-06 10:52:43 +01:00
Clément Fournier
b1ba962ddf Deprecate RuleViolation impls 2019-12-05 15:26:03 +01:00
Clément Fournier
eb6ceef085 Add comments and update release notes 2019-12-05 15:23:07 +01:00
Clément Fournier
bb7478cd0a Deprecate RuleViolationFactory impls 
Internal APIs
 2019-12-05 15:18:35 +01:00
Andreas Dangel
00392cefc2 [maven-release-plugin] prepare for next development iteration 2019-11-29 19:46:14 +01:00
Andreas Dangel
78da370fb8 [maven-release-plugin] prepare release pmd_releases/6.20.0 2019-11-29 19:46:05 +01:00
Andreas Dangel
c5d79a0db4 Merge branch 'pr-2138' 
[java] Preserve possible type of the target reference for method invocations
 2019-11-29 18:41:20 +01:00
Andreas Dangel
3a2791007e Fix checkstyle 2019-11-29 10:39:51 +01:00
Andreas Dangel
a85638a0e0 [java] Preserve possible type of the target reference for method invocations 
We already resolved the result type of a method invocation,
but in some cases, we also need the type of the target reference
for static method calls.

Reverts the previously introduced fix in UnusedImportsRule.

Fixes #2016
 2019-11-29 10:27:19 +01:00
Andreas Dangel
e106e7ac12 [java] ImmutableField: False positive when variable is updated in conditional loop 
Fixes #2125
 2019-11-24 10:20:21 +01:00
Andreas Dangel
f013497b1c fix import 2019-11-22 15:10:55 +01:00
Andreas Dangel
dd391ab78e [java] UnusedImports: False positive if wildcard is used and only static methods 
Added workaround for wrong typeresolution
(method result vs. class of method)

Refs #2016
 2019-11-22 15:04:17 +01:00
Andreas Dangel
e485396b3a Merge branch 'pr-2121' 
[java] Predicates treated like booleans
 2019-11-21 20:23:06 +01:00
Andreas Dangel
f5dc2fe80f [java] LinguisticNaming: Add test case for method returning predicate 2019-11-21 20:20:21 +01:00
Andreas Dangel
f8bf862d43 Merge branch 'pr-2113' 
[java] UnnecessaryFullyQualifiedName false-positive for non-static
nested classes
 2019-11-21 20:09:15 +01:00
Andreas Dangel
9cf0083bce Merge branch 'pr-2112' 
[java] ImmutableField false positive with inner class
 2019-11-21 20:06:46 +01:00
Andreas Dangel
c25049a24b Merge branch 'pr-2111' 
[java] False positive MissingStaticMethodInNonInstantiatableClass ...
when inheritors are instantiable
 2019-11-21 20:05:20 +01:00
Andreas Dangel
b1b3b37095 Merge branch 'pr-2099' 
[java] UnnecessaryFullyQualifiedName: regression / false positive
 2019-11-21 20:00:49 +01:00
Ozan Gulle
533b32a992 Slight adjustments in the test cases 2019-11-19 21:13:58 +01:00
Ozan Gulle
6306809a8d Corrected naming 2019-11-19 20:50:34 +01:00