344 Commits

Author SHA1 Message Date
Andreas Dangel
5cc351f15b Merge branch 'pr-130'
Closes #130
Rebased for merging into 5.4.x/5.5.x/master
2016-11-26 17:23:47 +01:00
Andreas Dangel
987ba1931c Merge branch 'pr-130' into pmd/5.5.x 2016-11-26 17:15:58 +01:00
Juan Martín Sotuyo Dodero
eca1f7c8ef Remove synchronization from RuleContext 2016-11-26 17:07:05 +01:00
Juan Martín Sotuyo Dodero
87f26e57e7 Use a LRU cache in SaxonXPathRuleQuery 2016-11-26 17:07:05 +01:00
Juan Martín Sotuyo Dodero
49e3de4a06 Allow concurrency in AttributeAxisIterator 2016-11-26 17:03:32 +01:00
Andreas Dangel
6261706b2e Merge branch 'incremental-analysis' of https://github.com/Monits/pmd into pr-125 2016-11-25 17:52:45 +01:00
Andreas Dangel
c2cd2fb4bd Add the new apex rules to the releases ruleset for 5.5.3 2016-11-21 21:30:52 +01:00
Andreas Dangel
f3c919bf6e Add the new apex rules to the releases ruleset for 5.5.3 2016-11-21 21:24:24 +01:00
Andreas Dangel
8522bdaa78 Merge branch 'bug-1518' 2016-11-20 18:13:32 +01:00
Andreas Dangel
8e0effd917 Merge branch 'bug-1518' into pmd/5.5.x 2016-11-20 18:04:48 +01:00
Andreas Dangel
712f7ae06b Checkstyle fixes / enable suppressions 2016-11-20 15:05:15 +01:00
Andreas Dangel
4149d25018 Remove package/class name clash DBType 2016-11-20 12:16:47 +01:00
Andreas Dangel
93ad242e4b Fix checkstyle: ModifiedControlVariable 2016-11-20 12:05:56 +01:00
Andreas Dangel
46a7908885 pmd-core: Further code formatting, clean-up 2016-11-20 11:52:17 +01:00
Andreas Dangel
f1d795a260 pmd-core: Code formatting 2016-11-20 10:23:04 +01:00
Juan Martín Sotuyo Dodero
e4dc70c5d5 [java] Properly handle enums with ignore identifiers
- Right now it throws an NPE
 - Having fixed the NPE, it threw an ArrayIndexOutOfBounds
 - Finally, it was just not working as expected
 - Fixes https://sourceforge.net/p/pmd/bugs/1542/
2016-11-14 20:06:41 +01:00
Juan Martín Sotuyo Dodero
0abeb8d07e Make RuleSetFactory immutable
- By being thread-safe, we can stop synchronizing on all methods
2016-11-14 00:48:58 -03:00
Juan Martín Sotuyo Dodero
2deb07f312 Final touches & license
- indentation fixes, missing licenses, some javadoc, complete some TODOs
2016-11-11 20:39:15 -03:00
Juan Martín Sotuyo Dodero
8d29af42b3 Improve PMDConfiguration and javadocs 2016-11-11 20:39:15 -03:00
Juan Martín Sotuyo Dodero
4dad69c9de Tidy up final test cases 2016-11-11 20:39:15 -03:00
Juan Martín Sotuyo Dodero
bd574644d0 Remove FileAnalysisCache factory method
- A simple constructor will work just fine.
 - Plus, this makes it even more obvious that no exceptions / null values
    are to be expected when loading a cache from file, even when it's invalid
    or badly configured.
2016-11-11 20:39:15 -03:00
Juan Martín Sotuyo Dodero
0c9e7e7269 Order is important to checksum computation
- Make sure the `ruleSet` collection has a consistent access order.
2016-11-11 20:39:15 -03:00
Juan Martín Sotuyo Dodero
c0250a678b Refactor FileAnalysisCache
- Split the generic cache implementation from the file-backing persistence
    strategy. This could probably work better as a composition rather than
    inheritance, but we will take it one step at a time.
 - Took the chance to improve error messages produces by FileAnalysisCache
2016-11-11 20:39:15 -03:00
Juan Martín Sotuyo Dodero
71df067a0d Consider classpath and ruleset for cache invalidation
- Not completely convinced by this implementation, but is simple enough
    and it's working.
2016-11-11 20:39:15 -03:00
Juan Martín Sotuyo Dodero
cbb3d39e33 Basic analysis cache implementation
- Only invalidated by PMD version change.
 - Hooked to CLI and ANT.
 - A NOOP and a File based implementations available.
 - Unit tested where possible.
 - Still several TODOs to handle.
2016-11-11 20:39:15 -03:00
Juan Martín Sotuyo Dodero
a7b46723c8 [java] Properly handle enums with ignore identifiers
- Right now it throws an NPE
 - Having fixed the NPE, it threw an ArrayIndexOutOfBounds
 - Finally, it was just not working as expected
 - Fixes https://sourceforge.net/p/pmd/bugs/1542/
2016-11-10 10:41:50 -03:00
Andreas Dangel
35605a5801 Change version to 5.6.0-SNAPSHOT on master 2016-11-06 17:38:37 +01:00
Andreas Dangel
5f13cc20e9 [maven-release-plugin] prepare for next development iteration 2016-11-05 11:02:08 +01:00
Andreas Dangel
96fffcaadd [maven-release-plugin] prepare release pmd_releases/5.5.2 2016-11-05 11:02:08 +01:00
Andreas Dangel
e78f80416a [maven-release-plugin] prepare for next development iteration 2016-11-04 21:01:18 +01:00
Andreas Dangel
5019eb11e4 [maven-release-plugin] prepare release pmd_releases/5.4.3 2016-11-04 21:01:18 +01:00
Andreas Dangel
cec3e1a2ad plsql: add new rule "MisplacedPragma"
#1539 [plsql] Create new rule for strict syntax checking: MisplacedPragma
2016-11-04 11:19:52 +01:00
Andreas Dangel
9be65ef2eb Add unit test for #1537 Implement strict ruleset parsing 2016-11-01 18:30:39 +01:00
Andreas Dangel
c6680e2f66 Merge branch 'better-collections' of https://github.com/Monits/pmd into pr-116 2016-10-30 18:25:35 +01:00
Juan Martín Sotuyo Dodero
42277d7b8d Simplify collection expressions 2016-10-13 17:17:17 -03:00
Juan Martín Sotuyo Dodero
df9893099f No PMD version supports running on JRE5 anymore
- Remove dead code to guard against JRE5 issues
2016-10-13 01:59:19 -03:00
Juan Martín Sotuyo Dodero
61b55bd7e5 Minor improvements
- Use `Deque` and `ArrayDeque` instead of `Stack`
 - Use presized `ArrayList` instead of a dynamic `LinkedList` when possible
 - Don't create empty `HashSet` when `Collections.emptySet()` suffices
 - User `Collections.singletonList()` were apropriate
2016-10-13 01:53:47 -03:00
Andreas Dangel
2fc01fedb5 Add readme 2016-09-06 21:10:56 +02:00
Andreas Dangel
3e43fd8eb1 Update (old) changelog for new rules with PMD 5.5.1 2016-07-28 19:44:04 +02:00
Andreas Dangel
6746b7522c [maven-release-plugin] prepare for next development iteration 2016-07-27 20:40:56 +02:00
Andreas Dangel
cc3ad9aeb7 [maven-release-plugin] prepare release pmd_releases/5.5.1 2016-07-27 20:40:56 +02:00
Andreas Dangel
20c4f168c1 Merge branch 'close-read-files' of https://github.com/wolfs/pmd into pr-104 2016-07-26 22:10:15 +02:00
Andreas Dangel
39a9d99710 #1508 - Only close the classloader if its ours 2016-07-26 21:59:15 +02:00
Andreas Dangel
a491cef61c Merge branch 'bug-1508' 2016-07-26 21:56:14 +02:00
Andreas Dangel
7578875cbd #1508 - Only close the classloader if its ours 2016-07-26 21:49:33 +02:00
Andreas Dangel
42a5c6a537 Merge branch 'bug-1508' into pmd/5.4.x 2016-07-26 21:42:55 +02:00
Andreas Dangel
d76b689c07 Fixes #1508 [core] [java] PMD is leaking file handles
Closes class loader after PMD has processed all files
2016-07-25 21:42:21 +02:00
Andreas Dangel
293731f009 Fixes #1508 [core] [java] PMD is leaking file handles
Closes class loader after ant task is finished
2016-07-25 21:34:40 +02:00
Andreas Dangel
88d1823c2e Fixes #1508 [core] [java] PMD is leaking file handles
Fixes InputStreams and Readers
2016-07-25 21:25:34 +02:00
Stefan Wolf
23bee1cad1 Close the created URLClassLoader when finishing the Ant task 2016-07-25 14:08:04 +02:00