Commit Graph

2816 Commits

Author SHA1 Message Date
e2ec5450ff Update rules
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/AvoidEnumAsIdentifier, please use @Name instead
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/AvoidAssertAsIdentifier, please use @Name instead
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/ProperLogger, please use @Name instead
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/JumbledIncrementer, please use @Name instead
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/AvoidLosingExceptionInformation, please use @Name instead
WARNING: Use of deprecated attribute 'VariableDeclaratorId/@Image' by rule Error Prone/EmptyCatchBlock, please use @Name instead
2020-04-17 20:34:42 +02:00
f3db39641a Test with ASTVariableDeclaratorId#getName 2020-04-17 20:28:00 +02:00
be152e92a8 Output replacement as well 2020-04-17 20:18:32 +02:00
de875c955a [java] Convert JUnitStaticSuite to Java rule 2020-04-17 15:21:58 +02:00
c8bdc4fade [java] UseCorrectExceptionLogging - fix problem with multiple loggers 2020-04-17 14:53:26 +02:00
80a40c00ef [java] Convert AbstractClassWithoutAbstractMethod to Java rule 2020-04-17 12:01:27 +02:00
797a965c4b [java] Convert JUnitSpelling to Java rule 2020-04-17 11:51:06 +02:00
e81fee9ee5 [java] Convert PositionLiteralsFirstIn*Comparisons to Java rules 2020-04-17 11:24:23 +02:00
319fe80d85 [java] Simplify AvoidDecimalLiteralsInBigDecimalConstructor with type res 2020-04-16 18:57:36 +02:00
feee0b8f91 [java] Replace XPath ProperCloneImplementation with Java Rule 2020-04-16 18:57:10 +02:00
08d31c62a9 Merge branch 'master' into pr-2377 2020-04-16 17:52:03 +02:00
ea532e6d2d Rename RecordDeclaration::getComponentList to getRecordComponents
This name is clearer when seen from the
interface ASTAnyTypeDeclaration, also
it matches the Class API
2020-04-16 14:28:59 +02:00
ac21dc95b1 Merge branch 'pr-2407'
[core] Deprecate Jaxen and XPath internal API #2407
2020-04-13 12:17:58 +02:00
0726496726 Merge branch 'pr-2409'
[java] ClassNamingConventions suggests to add Util for class containing only static constants, fixes #1164 #2409
2020-04-13 12:06:01 +02:00
8c2edd625f Fix UseAssertEqualsInsteadOfAssertTrue Example
String used ? instead of "
2020-04-11 14:32:43 +02:00
f4b95a3ae3 [java] ClassNamingConventions suggests to add Util for class containing only static constants, fixes #1164 2020-04-09 19:15:39 +05:30
60d443963c Call default ctor
Defines properties
2020-04-09 15:28:20 +02:00
5067c79eb2 Cleanup a test 2020-04-08 21:38:10 +02:00
961e78954a Update some tests 2020-04-08 21:35:34 +02:00
c7941638e8 Merge branch 'pr-2401'
[doc] Update DoNotUseThreads rule documentation #2401
2020-04-06 20:21:32 +02:00
f28bdbed5e issue 2402 fix false-positives on Primitive Streams 2020-04-05 19:47:52 +02:00
dcde4258b3 Update DoNotUseThreads rule documentation
Fixes #2313 [java] Documentation for DoNotUseThreads is outdated
2020-04-05 11:46:51 +05:30
69ed0464a7 Merge branch 'pr-2385'
[java] Make yield statements more conditional #2385

Fixes #2319
2020-04-04 18:20:49 +02:00
a04964c32a Merge branch 'pr-2392'
[java] Fix UseDiamondOperator false positive inside lambda #2392
2020-04-04 10:44:32 +02:00
ad82444087 [java] Optimize some XPath 2.0 rules
ProperCloneImplementation,
JUnit4SuitesShouldUseSuiteAnnotation,
AbstractClassWithoutAbstractMethod,
AvoidDecimalLiteralsInBigDecimalConstructor,
JUnitStaticSuite
2020-04-03 20:38:46 +02:00
256a7cd565 [java] Fix annotation check for unit test rules 2020-04-03 19:48:46 +02:00
6e38eaec31 [java] Optimize XPath rules that use count(x)=0 2020-04-03 18:29:00 +02:00
4c712d467d [java] Refactor JUnit specific rules that use ancestor axis 2020-04-03 17:03:00 +02:00
3e932de647 Merge branch 'master' into pr-2377 2020-04-03 16:25:22 +02:00
04f0bb78b9 Merge branch 'pr-2380'
[java] Make TypeHelper use the class loading cache of ClassTypeResolver #2380
2020-04-03 15:41:09 +02:00
4d17358746 Fix FP with array creation 2020-03-30 16:48:42 +02:00
eb7949045f Isolate version-sensitive tests 2020-03-30 10:23:41 +02:00
e58eb0f017 Fix UseDiamondOperator
Fixes #1723
2020-03-30 09:59:23 +02:00
a3cd0cf47d Merge branch 'pr-2384' #2384
[java] Performance improve xpath based rules
2020-03-29 17:26:26 +02:00
b7af5fb4db Fix ClassWithOnlyPrivateConstructorsShouldBeFinal
Refs #1938
2020-03-28 17:41:10 +01:00
01c2389f58 Merge branch 'master' into xpath-update-rules 2020-03-28 17:32:22 +01:00
e1a4b8ae97 Forbid type params for record ctors 2020-03-28 11:43:20 +01:00
7c433f8820 Remove import to reduce diff 2020-03-28 11:36:42 +01:00
b01d4dc0d7 Test 2020-03-28 11:36:42 +01:00
9e9c370a4a Make yield more conditional
Refs #2319
2020-03-28 11:36:38 +01:00
485fa4ad50 Fix test case name 2020-03-28 11:06:10 +01:00
552931d965 Fix AbstractClassWithoutAnyMethods FN with inner classes 2020-03-28 11:03:40 +01:00
25ef59d5a7 [java] Performance improve xpath based rules
If an unbounded path expression like

    //PrimaryExpression[//ClassOrInterfaceDeclaration]

is used, then this will search the whole document again.
It will also avoid using rule chain later on, see #2382
2020-03-27 18:41:05 +01:00
105e48b8e1 Fix TypeHelper array loading 2020-03-23 23:00:39 +01:00
acbecf3e65 Add tests 2020-03-23 22:05:29 +01:00
549a49790c Doc 2020-03-23 21:44:10 +01:00
633319015b Fix when the type is nullable 2020-03-23 21:04:34 +01:00
a2994a97d9 Fast path annotation types 2020-03-23 20:57:51 +01:00
96532f26cc Make typeIs XPath functions use the typeres cache 2020-03-23 20:49:43 +01:00
3d429019ee Fix rules 2020-03-20 18:47:40 +01:00