phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
17,319 Commits 16 Branches 123 Tags
Commit Graph

17319 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andreas Dangel
250501a3d1 Merge branch 'pr-2791' into master 
[apex] Analyze inner classes for sharing violations #2791
 2020-09-24 11:55:11 +02:00
Andreas Dangel
eb0f7e4f99 [doc] Update release notes, refs #2791, fixes #2774 2020-09-24 11:54:35 +02:00
Jeff Bartolotta
5429cebf38 Add issue reproducers as standard rule tests 
Added false negative and false positive test cases that were logged with
the original issue.
 2020-09-21 20:11:07 -07:00
Andreas Dangel
54a5b03ccd Merge branch 'pr-2792' into master 
[java] Fix TypeTestUtil for arrays #2792
 2020-09-21 19:58:05 +02:00
Andreas Dangel
f046268058 [java] CloseResource: add simple test case for var 2020-09-21 19:47:42 +02:00
Andreas Dangel
87890b852a [java] CloseResource: Fix test code 2020-09-21 19:39:24 +02:00
rmohan
5ea116fa52 First draft of change to allow dotted attributes in Visualforce 2020-09-18 13:45:43 -07:00
Andreas Dangel
59f1fe251e Update ant from 1.10.1 to 1.10.8 
Fixes CVE-2020-1945 (Moderate severity)
 2020-09-18 15:53:33 +02:00
Clément Fournier
8c97300af8 Fix doc 
Parameters were in the wrong order.
 2020-09-18 04:04:35 +02:00
Clément Fournier
2093011913 Fix array & annot subtyping 2020-09-18 03:58:05 +02:00
Andreas Dangel
7ed238a384 Merge branch 'pr-2789' into master 
Add badge for reproducible build #2789
 2020-09-17 19:00:19 +02:00
Andreas Dangel
c21146019a [doc] Update release notes, refs #2789 2020-09-17 19:00:11 +02:00
Andreas Dangel
81a72cb43e [java] CloseResource: Fix NPE in case of "var" 2020-09-17 18:49:21 +02:00
Dan Rollo
d421927547 Add badge for reproducible build 2020-09-17 12:04:14 -04:00
Jeff Bartolotta
c6b7a723be Analyze inner classes for sharing violations 
Fixes https://github.com/pmd/pmd/issues/2774, false positives and false
negatives for ApexSharingViolationsRule.

Sharing settings are not inherited by inner classes. Sharing settings
need to be declared on the class that contains the Database method, DML,
SOQL, or SOSL.

The change inverts the direction from which nodes are found and
analyzed. The previous code visited the ASTUserClass and then searched
for descendant nodes that met a certain criteria. It did not visit inner
ASTUserClass nodes because it didn't use rule chains or call the super's
visit moethod for ASTUserClassi.

The new implementation visits all nodes that correspond to Database
method, DML, SOQL, or SOSL nodes and then finds the nearest ASTUserClass
parent node. This ASTUserClass is examined to determine if it has
declared a sharing setting as required.
 2020-09-17 08:36:45 -07:00
Andreas Dangel
f00e9744ea Merge branch 'pr-2784' into master 
[java] Lambda parsing bug #2784
 2020-09-17 14:58:32 +02:00
Andreas Dangel
d81731ed6c [doc] Update release notes, refs #2784, fixes #2783 2020-09-17 14:57:55 +02:00
Clément Fournier
3c1b0afcf6 Fix #2783 2020-09-16 15:40:45 +02:00
Andreas Dangel
7a1e3caba0 Add deprecations for antlr lexers that will be moved with PMD 7 
Refs pmd/pmd#2753
 2020-09-13 11:28:07 +02:00
Andreas Dangel
04592c8038 [core] Deprecate RuleReference#getOverriddenLanguage() and #setLanguage() 
Refs #2742
 2020-09-13 09:18:34 +02:00
Andreas Dangel
dacfff1abf Merge branch 'pr-2758' into master 
[cpd] Improve AnyTokenizer #2758
 2020-09-12 19:25:47 +02:00
Andreas Dangel
d261f44696 [doc] Update release notes, refs #2758, fixes #2760 2020-09-12 19:24:34 +02:00
Andreas Dangel
3f69e9188b [core] AnyTokenizer: add TODO for PMD7 2020-09-12 19:14:00 +02:00
Andreas Dangel
5192fdc0f9 [core] AnyTokenizer: Add testcase to verify #2760 is fixed 2020-09-12 19:13:43 +02:00
Andreas Dangel
53f3759ede Merge branch 'pr-2776' into master 
Bump actions/setup-java from v1.4.0 to v1.4.2 #2776
 2020-09-12 18:42:24 +02:00
dependabot[bot]
72f9d0f90a Bump actions/setup-java from v1.4.0 to v1.4.2 
Bumps [actions/setup-java](https://github.com/actions/setup-java) from v1.4.0 to v1.4.2.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](https://github.com/actions/setup-java/compare/v1.4.0...8bb50d97d6b4d316daf284fdf8eafbfc988421fc)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-09-12 10:46:46 +00:00
Andreas Dangel
352760c09c [ci] Fix dependabot schedule interval 2020-09-12 12:45:52 +02:00
Andreas Dangel
516fa5e01a Merge branch 'pr-2735' into master 
[ci] Add github actions for a fast view of pr succeed/not #2735
 2020-09-12 12:14:37 +02:00
Andreas Dangel
c3b5e1a5c1 [doc] Update release notes, refs #2735 2020-09-12 12:13:44 +02:00
Andreas Dangel
b247d616d9 [ci] github actions: Build on push and pull requests 2020-09-12 12:13:28 +02:00
Andreas Dangel
2093f6c82a [ci] dependabot: don't open PRs for maven dependencies 
We might enable this for PMD 7 later
 2020-09-12 12:13:04 +02:00
Andreas Dangel
66a97f6686 Merge branch 'pr-2741' into master 
[core] Deprecate ruleviolation comparator #2741
 2020-09-12 11:51:19 +02:00
Andreas Dangel
d039605747 [doc] Mention replacement for deprecated RuleViolationComparator 2020-09-12 11:51:11 +02:00
Andreas Dangel
606d25de82 Merge branch 'pr-2761' into master 
[java] Fix #2759, UnusedAssignment false positive #2761
 2020-09-12 11:37:09 +02:00
Andreas Dangel
20d48caa65 [doc] Update release notes, fixes #2759 2020-09-12 11:36:20 +02:00
Andreas Dangel
9ed79f46fd Merge branch 'pr-2770' into master 
[java] Fix #2767, PMD cannot parse a local var with final in instance initializer #2770
 2020-09-11 17:52:25 +02:00
Andreas Dangel
a13f88de5f [doc] Update release notes, fixes #2767 2020-09-11 17:51:36 +02:00
Andreas Dangel
6af4f1ecea Merge branch 'pr-2771' into master 
[java] Fix #2756, NPE in TypeTestUtil #2771
 2020-09-11 17:40:43 +02:00
Andreas Dangel
4f53b77045 [doc] Update release notes, fixes #2756 2020-09-11 17:40:04 +02:00
Andreas Dangel
d752b2c424 Merge branch 'pr-2773' into master 
[java] issue-2738: Adding null check to avoid npe when switch case is default #2773
 2020-09-11 17:15:03 +02:00
Andreas Dangel
7cea1d684c [doc] Update release notes, fixes #2738, refs #2773 2020-09-11 17:02:40 +02:00
Andreas Dangel
2d0d098d2c [java] Add test case for #2738 2020-09-11 16:59:16 +02:00
Nimit
fedea535b5 issue-2738: Adding null check to avoid npe when switch case is default 2020-09-10 19:19:43 -07:00
Clément Fournier
46933e666d Fix #2756, NPE in TypeTestUtil 2020-09-10 12:49:45 +02:00
Clément Fournier
fc759db5ca Fix #2767 
Problem was the stack is empty if the local var declaration
is the first node of the compilation unit to be pushed.
 2020-09-10 12:24:03 +02:00
Clément Fournier
d6ba977bb8 Merge branch 'ollieabbey-master' into master 
Refs #2747
 2020-09-06 18:32:56 +02:00
Clément Fournier
bcb04df160 Merge branch 'master' into ollieabbey-master 2020-09-05 18:38:44 +02:00
Clément Fournier
dddbaf0a6a Merge branch 'master' into deprecate-rv-comparator 2020-09-03 12:17:05 +02:00
Clément Fournier
b0f924495b Fix bug 
Problem was, isInTryBlock didn't ask for parent
states, even though abruptCompletionByThrow does.
 2020-09-03 12:13:37 +02:00
Clément Fournier
a43dea916d Fix JS tests 
Rewrite assertions for better error messages
The difference is 32 tokens instead of 30;
this is because previously, AnyTokenizer
tokenized `window.alert` as a single token. Now
it tokenizes it a `window`, `.`, `alert`.
 2020-09-03 11:40:03 +02:00