sandey/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

Code cleanup: reflect_v3_v3v3 made redundant copies

Browse Source
This commit is contained in:
Campbell Barton 2014-03-30 12:23:19 +11:00
parent 3bd15fcf15
commit 480c5019bb
1 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
source/blender/blenlib/intern/math_vector.c
View File

@ -471,25 +471,19 @@ void bisect_v3_v3v3v3(float out[3], const float v1[3], const float v2[3], const
normalize_v3(out); normalize_v3(out);
} }
/* Returns a reflection vector from a vector and a normal vector /**
* Returns a reflection vector from a vector and a normal vector
* reflect = vec - ((2 * DotVecs(vec, mirror)) * mirror) * reflect = vec - ((2 * DotVecs(vec, mirror)) * mirror)
*/ */
void reflect_v3_v3v3(float out[3], const float v1[3], const float v2[3]) void reflect_v3_v3v3(float out[3], const float vec[3], const float normal[3])
{ {
float vec[3], normal[3]; const float dot2 = 2.0f * dot_v3v3(vec, normal);
float reflect[3] = {0.0f, 0.0f, 0.0f};
float dot2;
copy_v3_v3(vec, v1); BLI_ASSERT_UNIT_V3(normal);
copy_v3_v3(normal, v2);
dot2 = 2 * dot_v3v3(vec, normal); out[0] = vec[0] - (dot2 * normal[0]);
out[1] = vec[1] - (dot2 * normal[1]);
reflect[0] = vec[0] - (dot2 * normal[0]); out[2] = vec[2] - (dot2 * normal[2]);
reflect[1] = vec[1] - (dot2 * normal[1]);
reflect[2] = vec[2] - (dot2 * normal[2]);
copy_v3_v3(out, reflect);
} }
void ortho_basis_v3v3_v3(float v1[3], float v2[3], const float v[3]) void ortho_basis_v3v3_v3(float v1[3], float v2[3], const float v[3])