sandey/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

Fix T47837: Filtering UIList broken with recent master.

Browse Source 
Using 32nd bit of integer with our int RNA prop is not a good idea, it does not
really support unsigned int even with PROP_UNSIGNED type...

Most likely this has been unveiled by recent work over property clamping in RNA.

Not critical, but should be backported should we make an 'a' release.
This commit is contained in:
Bastien Montagne 2016-03-19 17:06:32 +01:00
parent 26f2fe9528
commit 7f03e7cc3c
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/makesdna/DNA_screen_types.h
View File

@ -344,8 +344,10 @@ enum {
#define UI_LIST_AUTO_SIZE_THRESHOLD 1
/* uiList filter flags (dyn_data) */
/* WARNING! Those values are used by integer RNA too, which does not handle well values > INT_MAX...
* So please do not use 32nd bit here. */
enum {
UILST_FLT_ITEM = 1 << 31, /* This item has passed the filter process successfully. */
UILST_FLT_ITEM = 1 << 30, /* This item has passed the filter process successfully. */
};
/* uiList filter options */
@ -356,7 +358,7 @@ enum {
/* uiList filter orderby type */
enum {
UILST_FLT_SORT_ALPHA = 1 << 0,
UILST_FLT_SORT_ALPHA = 1 << 0,
UILST_FLT_SORT_REVERSE = 1 << 31 /* Special value, bitflag used to reverse order! */
};