sandey/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

Cleanup: Add some notes in code for upcoming graph simplification process.

Browse Source
This commit is contained in:
Thomas Dinges 2015-11-18 17:20:39 +01:00
parent 38bbc920a6
commit 836c69c92f
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
intern/cycles/render/graph.cpp
View File

@ -576,9 +576,25 @@ void ShaderGraph::break_cycles(ShaderNode *node, vector<bool>& visited, vector<b
void ShaderGraph::clean() void ShaderGraph::clean()
{ {
/* remove proxy and unnecessary nodes */ /* Graph simplification:
* 1: Remove unnecesarry nodes
* 2: Constant folding
* 3: Simplification
* 4: De-duplication
*/
/* 1: Remove proxy and unnecessary nodes. */
remove_unneeded_nodes(); remove_unneeded_nodes();
/* 2: Constant folding. */
/* TODO(dingto): Implement */
/* 3: Simplification. */
/* TODO(dingto): Implement */
/* 4: De-duplication. */
/* TODO(dingto): Implement */
/* we do two things here: find cycles and break them, and remove unused /* we do two things here: find cycles and break them, and remove unused
* nodes that don't feed into the output. how cycles are broken is * nodes that don't feed into the output. how cycles are broken is
* undefined, they are invalid input, the important thing is to not crash */ * undefined, they are invalid input, the important thing is to not crash */