sandey/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

bugfix [#26502] segmentationfault on pressing button to browse existing images for UV window

Browse Source 
really old one!, since initial commit blender would crash scaling down large sizes eg: 60962 -> 128 (width or height).

the problem is scaledownx/y doesn't check buffer endpoints, with really large images theres a loop on a float value which can fail with large image sizes.

previous commit added asserts if the buffer runs over (assuming it doesnt crash),
This commit changes an epsilon value, tested this with random small images as well as images over 200,000 px, and it works fine, this is still flakey though and for really really big images it probably still fails.
This commit is contained in:
Campbell Barton 2011-03-17 11:08:25 +00:00
parent 172f3337ce
commit e0871e07df
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/imbuf/intern/scaling.c
View File

@ -863,7 +863,7 @@ static struct ImBuf *scaledownx(struct ImBuf *ibuf, int newx)
rectf_end= ibuf->rect_float + (ibuf->x * ibuf->y * sizeof(float) * 4);
}
add = (ibuf->x - 0.001) / newx;
add = (ibuf->x - 0.01) / newx;
if (do_rect) {
rect = (uchar *) ibuf->rect;
@ -993,7 +993,7 @@ static struct ImBuf *scaledowny(struct ImBuf *ibuf, int newy)
rectf_end= ibuf->rect_float + (ibuf->x * ibuf->y * sizeof(float) * 4);
}
add = (ibuf->y - 0.001) / newy;
add = (ibuf->y - 0.01) / newy;
skipx = 4 * ibuf->x;
for (x = skipx - 4; x>=0 ; x-= 4) {