sandey/blender
1
0
Fork 0
forked from bartvdbraak/blender
Code Pull Requests Activity

More AutoSnap Bugfixes: Time Stepping in Graph Editor

Browse Source 
* Frame Step now works correctly and as expected
* Second Step kindof works, but the handles are not well behaved.
This commit is contained in:
Joshua Leung 2014-04-25 02:17:12 +12:00
parent 9c28a24153
commit e80fbf8674
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
source/blender/editors/transform/transform_conversions.c
View File

@ -4130,6 +4130,28 @@ void flushTransGraphData(TransInfo *t)
else else
td2d->loc2d[0] = td2d->loc[0]; td2d->loc2d[0] = td2d->loc[0];
/* Time-stepping auto-snapping modes don't get applied for Graph Editor transforms,
* as these use the generic transform modes which don't account for this sort of thing.
* These ones aren't affected by NLA mapping, so we do this after the conversion...
*
* NOTE: We also have to apply to td->loc, as that's what the handle-adjustment step below looks
* to, otherwise we get "swimming handles"
*/
if ((td->flag & TD_NOTIMESNAP) == 0 && ELEM(sipo->autosnap, SACTSNAP_STEP, SACTSNAP_TSTEP)) {
switch (sipo->autosnap) {
case SACTSNAP_STEP: /* frame step */
td2d->loc2d[0] = floor((double)td2d->loc[0] + 0.5);
td->loc[0] = floor((double)td->loc[0] + 0.5);
break;
case SACTSNAP_TSTEP: /* second step */
/* XXX: the handle behaviour in this case is still not quite right... */
td2d->loc[0] = floor(((double)td2d->loc[0] / secf) + 0.5) * secf;
td->loc[0] = floor(((double)td->loc[0] / secf) + 0.5) * secf;
break;
}
}
/* if int-values only, truncate to integers */ /* if int-values only, truncate to integers */
if (td->flag & TD_INTVALUES) if (td->flag & TD_INTVALUES)
td2d->loc2d[1] = floorf(td2d->loc[1] + 0.5f); td2d->loc2d[1] = floorf(td2d->loc[1] + 0.5f);