There was a bug with Flying Edges checking the boundary conditions in
the z-direction. It was comparing the z index to the size of the y
dimension, not the z dimension. This simple typo was probably missed
because most of the tests use square meshes. To catch the problem, you
need a mesh that has a different number of points in the y and z
directions and the contour has to go past the positive z boundary.
When this error was hit, the indices for the edges on that boundary were
not recorded, and later interpolation used garbage values for edge's
point ids.
The scalar field difference along x, y, and z should be divided by the
spacing not multiplied. This was causing some test failures in VTK and
ParaView when overriding the default contour filter with `vtkmContour`.
`RectilinearLocator::LocateCell` and `UniformLocator::LocateCell` assume
that the point in inside the bounds of the cell set, but may return a
cell location that does not exist, i.e., cell location that is outside
of the bounds of the cell set due to errors from floating point
operations.
This fix, given the assumption above, bounds the calculated cell
location to within the cellset by capping the indices to within the
limits.
Although it is generally wrong to try to call `ResetToBounds` with a
`Bounds` object that does not have a valid range, there are cases where
the range might not be valid. (For example, if `ResetToBounds` was
called in a routine that is rendering an empty scene, it would be best
not to crash.)
* commit '04c43e4c5': (376 commits)
Batch line and text annotations for View1D
Update code to follow styling and worklet invoker guidelines
CI: move from only to rules
CI: fix dependencies in CI jobs
CI: adjust parallel param hip build
Adding changelog for cell centered velocities
added changelog
Removing unnecessary header
Updating particle advection filters to use field associativity
minor fix
make most of the vtkm_io library not DEVICE_SOURCE
fixed single/double precision converstion
add include sstream and see if it clears the dashboard
remove comment about DeviceAdapter.h
include DeviceAdapter.h in StorageVirtual.h
CI: add HIP builing build
add missing #include
decouple Timer.h from device compiler
do not use device compiler to compile source unit tests
Fix dropped UnknownArrayHandle symbols
...
c62998bd1 Batch line and text annotations for View1D
f7c43960e Update code to follow styling and worklet invoker guidelines
b7470b0af Remove leftover debug statement
8f025a2c5 Batch text and line annotation rendering
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !2594
a5aeda724 CI: move from only to rules
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !2610
81fe1254e Merge branch 'master' into vtkm_io_sans_device_source
2c33a23d3 added changelog
1de5fef12 minor fix
5e87ed858 make most of the vtkm_io library not DEVICE_SOURCE
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !2607
