Shuenhoy/vtk-m
1
0
Fork 0
mirror of https://gitlab.kitware.com/vtk/vtk-m synced 2024-09-19 10:35:42 +00:00
Code Issues 2 Actions Packages Projects Releases Wiki Activity
e74c0732c5
vtk-m/docs/changelog/precompiled-array-get-values.md
Kenneth Moreland e1ac918bc7 Compile ArrayGetValues implementation in library 
Previously, all of the `ArrayGetValues` implementations were templated
functions that had to be built. That meant that any code using them had
to be compiled with a device compiler and create special code for it.
This change uses an `UnknownArrayHandle` to encapsulate the
`ArrayHandle` and call a per-compiled library function. This means that
the code only has to be compiled once.
2021-08-11 07:56:32 -06:00

980 B
Raw Blame History

Compile ArrayGetValues implementation in a library

Previously, all of the ArrayGetValue implementations were templated functions that had to be built by all code that used it. That had 2 negative consequences.

  1. The same code that scheduled jobs on any device had to be compiled many times over.
  2. Any code that used ArrayGetValue had to be compiled with a device compiler. If you had non-worklet code that just wanted to get a single value out of an array, that was a pain.

To get around this problem, an ArrayGetValues function that takes UnknownArrayHandles was created. The implementation for this function is compiled into a library. It uses UnknownArrayHandle's ability to extract a component of the array with a uniform type to reduce the number of code paths it generates. Although there are still several code paths, they only have to be computed once. Plus, now any code can include ArrayGetValues.h and still use a basic C++ compiler.