Shuenhoy/vtk-m
1
0
Fork 0
mirror of https://gitlab.kitware.com/vtk/vtk-m synced 2024-09-08 13:23:51 +00:00
Code Issues 2 Actions Packages Projects Releases Wiki Activity
fc3845ec89
vtk-m/docs/changelog/deprecate-reduce-by-key-count.md
Kenneth Moreland d77c5812c3 Deprecate the GetCounts() method in Keys objects 
The `vtkm::worklet::Keys` object held a `SortedValuesMap` array, an
`Offsets` array, a `Counts` array, and (optionally) a `UniqueKeys` array.
Of these, the `Counts` array is redundant because the counts are trivially
computed by subtracting adjacent entries in the offsets array. This pattern
shows up a lot in VTK-m, and most places we have moved to removing the
counts and just using the offsets.

This change removes the `Count` array from the `Keys` object. Where the
count is needed internally, adjacent offsets are subtracted. The deprecated
`GetCounts` method is implemented by copying values into a new array.
2024-01-25 16:13:54 -05:00

670 B
Raw Blame History

Deprecate the GetCounts() method in Keys objects

The vtkm::worklet::Keys object held a SortedValuesMap array, an Offsets array, a Counts array, and (optionally) a UniqueKeys array. Of these, the Counts array is redundant because the counts are trivially computed by subtracting adjacent entries in the offsets array. This pattern shows up a lot in VTK-m, and most places we have moved to removing the counts and just using the offsets.

This change removes the Count array from the Keys object. Where the count is needed internally, adjacent offsets are subtracted. The deprecated GetCounts method is implemented by copying values into a new array.