TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Remove AbstractMysqlAdapterTest

Browse Source 
This test was added in 8f5095a to ensure that there was coverage
for `AbstractMysqlAdapter#execute`, but 63c0d6b refactored `#execute`
to be defined at the Abstract adapter level, and rely on concrete MySQL
adapters to implement `#raw_execute`.

This test won't pass without having the `ExampleMysqlAdapter` implement
`#raw_execute`, but this test is obsolete now that AbstractMysql2Adapter
doesn't implement `#execute` directly.
This commit is contained in:
Adrianna Chang 2023-05-02 09:15:01 -04:00
parent 8bdf5e3557
commit abe0b123bc
No known key found for this signature in database
GPG Key ID: 6816AFC60CB96DE5
1 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
activerecord/test/cases/adapters/abstract_mysql_adapter_test.rb
View File

@ -1,24 +0,0 @@
# frozen_string_literal: true
require "cases/helper"
class AbstractMysqlAdapterTest < ActiveRecord::Mysql2TestCase
if current_adapter?(:Mysql2Adapter)
class ExampleMysqlAdapter < ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter; end
def setup
@conn = ExampleMysqlAdapter.new(
ActiveRecord::ConnectionAdapters::Mysql2Adapter.new_client({}),
ActiveRecord::Base.logger,
nil,
{ socket: File::NULL }
)
end
def test_execute_not_raising_error
assert_nothing_raised do
@conn.execute("SELECT 1")
end
end
end
end