TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
29,436 Commits 2 Branches 0 Tags 294 MiB
0183193a6a
Commit Graph

29436 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jon Leighton
0183193a6a Allow Relation#merge to take a hash 2012-04-13 13:17:42 +01:00
Jon Leighton
e4f0fbd994 we have no need for the ASSOCIATION_METHODS constant 2012-04-13 13:17:42 +01:00
Jon Leighton
a258c27653 we don't need to test that constant assignment works 2012-04-13 13:17:42 +01:00
Jon Leighton
88d1fafc22 refactoring 2012-04-13 13:17:42 +01:00
Jon Leighton
3b86336694 Extract clusterfuck method for surgery 2012-04-13 13:17:42 +01:00
Xavier Noria
4e3e5138b5 Merge pull request #5830 from raganwald/master 
Update RDoc to mention integer coercion in ActiveRecord’s find by id
 2012-04-12 19:58:08 -07:00
Reg Braithwaite
dcb2279674 mention that coercion only happens when the primary key is an integer and use +to_i+ formatting 2012-04-12 22:55:11 -04:00
Reg Braithwaite
859a91b59a Documents that ActiveRecord's find by id uses to_i to coerce its arguments to integers 2012-04-12 22:24:21 -04:00
Jon Leighton
8c2c60511b Add bang versions of relation query methods. 
The main reason for this is that I want to separate the code that does
the mutating from the code that does the cloning.
 2012-04-12 17:57:54 +01:00
Jeremy Kemper
5c51cd0b2f #send_file leans on Rack::Sendfile to X-Accel-Redirect the file's path, so opening the file to set the response body is wasteful. Set a FileBody wrapper instead that responds to to_path and streams the file if needed. 2012-04-12 09:53:00 -07:00
Vijay Dev
8248f4202d Merge branch 'master' of github.com:lifo/docrails 2012-04-12 21:44:11 +05:30
Vijay Dev
6cab7602bb avoid autolinking by rdoc [ci skip] 2012-04-12 21:36:46 +05:30
Jon Leighton
018e832d84 Merge pull request #2733 from dasch/improve-delegate 
Improve the performance of #delegate
 2012-04-12 09:02:39 -07:00
Jon Leighton
65be11ffec Merge pull request #5722 from kennyj/some_refactor_for_association 
Some refactor for association.
 2012-04-12 09:01:10 -07:00
Alfonso Cora
05ac3921f8 Fixed markup in security guide 2012-04-12 12:20:12 -03:00
kennyj
1e417d5cd2 Some refactor for association. 
* Remove unused association_class method.
* Remove a unnecessary assignment.
* Move @updated to BelongsToAssociation that only reference this instance variable.
* Reset @stale_state at the reset method. I think this place is right place.
 2012-04-12 23:28:31 +09:00
Jon Leighton
eda65f391e move apply_finder_options to active_record_deprecated_finders 2012-04-12 15:02:00 +01:00
Jon Leighton
dd2c9b9578 add active_record_deprecated_finders as a dep 2012-04-12 15:01:43 +01:00
Daniel Schierbeck
300868d9cb Remove the addition to the guides 2012-04-12 15:03:19 +02:00
Daniel Schierbeck
1d48e50284 Add changelog entry 2012-04-12 14:59:21 +02:00
Daniel Schierbeck
5fb6bd8b22 Remove Module#delegate! 2012-04-12 14:55:30 +02:00
Daniel Schierbeck
402a119ddb Add back the old deprecate method as deprecate! 2012-04-12 13:47:52 +02:00
Daniel Schierbeck
3b1537a7d1 Document the changes to delegate in the guides 2012-04-12 13:47:52 +02:00
Daniel Schierbeck
2310db373b Change API docs regarding delegation to non-public methods 2012-04-12 13:47:52 +02:00
Daniel Schierbeck
1bac04e854 Optimize the performance of #delegate 
Remove the use of #__send__ in order to boost performance. This also
means that you can no longer delegate to private methods on the
target object.
 2012-04-12 13:47:52 +02:00
Santiago Pastorino
1db54dffaf Merge pull request #5746 from jmbejar/index_method_form_builder 
Add method FormBuilder#index
 2012-04-11 19:43:50 -07:00
Jorge Bejar
47cbfbb98a Add index method to FormBuilder. Useful when you use field_for and need to know the index number into the iteration. 2012-04-11 23:11:38 -03:00
Jon Leighton
e177525d6f Merge pull request #5736 from oscardelben/configuration_errors_reporting 
Add better errors reporting for ActiveModel::Configuration
 2012-04-11 16:20:42 -07:00
Jon Leighton
19ecde00ff Merge pull request #5720 from kennyj/should_use_klass_method 
Get a properly aliased_table_name, when we use a polymorphic association.
 2012-04-11 16:18:36 -07:00
Jon Leighton
ddefdd7086 Merge pull request #5809 from xuanxu/null_relation_methods 
Override AR::Relation methods in NullRelation.
 2012-04-11 15:41:02 -07:00
Tim Harvey
63bd01d82f Grammar fix in 3.2 Release Notes guide 
Could also be worded 'as an option', but plural made more sense given 
the mention of ':handlers and :formats'.
 2012-04-11 17:10:21 -03:00
Vijay Dev
3bcfa614af copy editing [ci skip] 2012-04-11 22:43:50 +05:30
Vijay Dev
4fb6527e2c Revert "add instructions for adding additional manifests" 
This reverts commit f28f1d70b3f3dd9f694067f7cab2e717e302ee2b.

Reason: This is already covered in this guide elsewhere.
 2012-04-11 22:39:36 +05:30
Vijay Dev
02a5847d32 fix bad format [ci skip] 2012-04-11 22:37:17 +05:30
Xavier Noria
6da500279b Merge pull request #5792 from lest/patch-4 
no need in temporary array in number_to_phone helper
 2012-04-11 09:04:31 -07:00
Juanjo Bazán
1a20683f09 Override AR::Relation methods in NullRelation. 
So a NullRelation (Relation#none) is chainable with database methods.
 2012-04-11 15:24:23 +02:00
Xavier Noria
b79b784f72 Merge pull request #5805 from dcurtis/master 
Corrected grammatical errors in schema_dumper and scoping/default
 2012-04-11 04:24:13 -07:00
dcurtis
248fa70ccd Corrected grammatical errors in schema_dumper and scoping/default 2012-04-10 22:05:43 -07:00
Aaron Patterson
1c8e222cea Merge pull request #5649 from rafaelfranca/fix-delete_all 
Fix delete_all when chained with joins.
 2012-04-10 19:57:27 -07:00
Rafael Mendonça França
6f6c2909dc Fix delete_all when chained with joins. 
Closes #5202 and #919
 2012-04-10 23:45:01 -03:00
Jonathan Mazin
729890469d Fix small markup error; fix incorrect link 2012-04-09 15:41:50 -03:00
Sergey Nartimov
332c3e14ce no need in temporary array in number_to_phone helper 2012-04-09 21:40:54 +03:00
Santiago Pastorino
84adc21498 Merge pull request #5788 from Ask11/rails_new_help 
"rails new -h" shows message in rails directory
 2012-04-09 10:21:28 -07:00
Santiago Pastorino
e065312a14 Merge pull request #5787 from frankieroberto/itemscope-patch 
Adding itemscope to list of boolean attributes.
 2012-04-09 09:52:28 -07:00
ask
4bb76eecfe "rails new -h" shows message in rails directory 2012-04-09 22:26:52 +06:00
Xavier Noria
68a9788cdb rewords the section about default_url_options in the Action Controller Overview guide 2012-04-09 18:26:23 +02:00
Patrick Sharp
bdac19e6c8 Merge branch 'master' of github.com:lifo/docrails 2012-04-09 08:54:22 -05:00
Patrick Sharp
f28f1d70b3 add instructions for adding additional manifests 2012-04-09 08:54:02 -05:00
Prem Sichanugrist
cf03daa5f5 Fix code example in generator test case 2012-04-09 09:48:30 -04:00
Frankie Roberto
283133a59c Adding itemscope to list of boolean attributes. 
'itemscope' is defined within HTML5 for use in microdata markup. See
http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.ht
ml#attr-itemscope
 2012-04-09 12:23:46 +01:00